From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B20893D8121 for ; Mon, 25 May 2026 08:03:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779696229; cv=none; b=m/+uXjZZjIW8PBvFuRMDmz/sFjaZkh3/16BHa7IRsR2iVLV85YctCH7t6XB6gl7yu9jWkZ5pnCKnhN3rVqKSb7OVUD5uFH7ayPMouzWRdeGSxCkGw2n58UzyYOq+hKLeKNyyTO7gPv/1YVZV6YvChaxN8vsWVptwAMUbVxVlbm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779696229; c=relaxed/simple; bh=fr+e8jSWCvLEvrBnINuh9xFjLCo/RmOfgTIeNe9+zvA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=b6ZQpI0g4ZshFjzXZdGLHA1AOMhkqqEtA8arxy5sWWirvPqAGlNX/oRJli1E7G+n30Nd+2dkBdtk1vIP8sckxeJaSgfdKZV9W5PbPU3gcrL8Woxcyg+Rlk9Q5++m0UwS54tzPESeaVPyNXvCj0eXQxW9H5XBsKgZkbp8gAUQndE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TafdsHjD; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=aBXmbBUq; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TafdsHjD"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="aBXmbBUq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779696226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rsukF4dZCU0ZbqW5zX/pXif2FwbM6n8OKZoQAtV0fvI=; b=TafdsHjDiLAG/wq/o0SaXtcX11/Oz+Ackr7m/psJX1UpdJbq/VJegqCfhZqs0ty9xVhWR0 3zs7jJjDLwtoAitsRhtpm+CuyuSkSqinofvO0dB6CpJwHDYcqpnabeaMpCtrAXo2OO22PC w1RyBOuA5vpITdlVQnSTAC3k13Fb+sg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-413-lN3YxHpfME6JWykQ1HMHZQ-1; Mon, 25 May 2026 04:03:44 -0400 X-MC-Unique: lN3YxHpfME6JWykQ1HMHZQ-1 X-Mimecast-MFC-AGG-ID: lN3YxHpfME6JWykQ1HMHZQ_1779696224 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-49045f93baeso19499255e9.1 for ; Mon, 25 May 2026 01:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779696223; x=1780301023; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=rsukF4dZCU0ZbqW5zX/pXif2FwbM6n8OKZoQAtV0fvI=; b=aBXmbBUqg79QgCvQMVq/cvZVxxpfYxm8fVzt6xubTsEqUF/MtMQQVDmJsh5N//i92x eVojfEGwEKoiwHThWWuAsNKEE0oilapt+tG0bx1KD36JEgnIfH1izCqcpxcUAD07TQMk h6yNclIsDFUlFf+n5Dd1SFlbxFeg6En/XmGLlVosWDqE/zahf8pvg/ouxBuM8Kq57aa+ xaFL3xnosbWmtnXLbPBkzdjtrIhSlskZhsaO1PNW7A1MzeuxeEouY/nQBOyrtvOJJHcn hKXgVep973lR/wQjX2wYy9IwJ5TIwCzyDZnDXNAUrh6HE/EKnVhnRtmwncNs/vp2Bj7x ynGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779696223; x=1780301023; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rsukF4dZCU0ZbqW5zX/pXif2FwbM6n8OKZoQAtV0fvI=; b=R8BMxx0otNa0xXwhVjObWNcGPndvHbkN8YL3w1JDQtlLL5vRafn80HvxUA7Gbzi+HM BAaYYdc5kL5mj88jG4shEC6Y6Ckks71l7lvGtkJ7MApbyJX7rnyxMEM8MbwwnU3jLu2l YIYa0AVZvB1UyGIdU/TPSV8oELcrpXZa9P8LSDc4KXYt6RvqT3UH5UBitjPelWbHunOf WAZNG1Kij3ezEWJ1RlROZGjyxXt4iIVtbJe/mK1QDEkUbAny2QUPskb680is6j6M4Cil cpTx+bVp33Y5wyinvdKxWeEcIoACC7jbiSjr5sHVsOTQOP9Gjwj8CKbAfnQjPJ4Y5Cj9 hy5Q== X-Forwarded-Encrypted: i=1; AFNElJ+GD306UItKG99X2hLmpa1ztwBYXpcKjEozUCFJDPussGNf15vzkYcFBbr49qFMn5poOKDD87dOq1Fd8og=@vger.kernel.org X-Gm-Message-State: AOJu0YzXsA61pqH2w+PTct9vrgjkj078eiUxLBNlT/spA677FLG7gIfe dEzs06P5RH2E4A+rUoZNKqddmSWHp/BtRF5vtMLMywmoh8v65Ka3h1EzMMFt8W22WePlI9V8Fe9 +0b5AlWRDWbrWXi5jVMj9ODYTBaYqN54K2vmWTdP1dui10jn/TxHXaXH2bZzCPM8yehX2gAh0LQ qU X-Gm-Gg: Acq92OFPRZwTMkKHSbWyHKZSuzyRtYxMnZNVJvYvAqlNioqI9cONBlgB0vKcugVj02T lBNOq7sueFy8vWPZ25cXZnOOE+i/yCB7IoKN8SP482D71GwYn74vkzyPUMOVBkKa1T8QvE2xB5p AW0bT/phtnigatKZSgIwbNsH0nr9yD0b2n2BRED68mQM+cXdSSZl0RyK9Q2m1O7XS25jont+csQ zEOnJ9l3+uhtO0XOJ1TEW1LF7iz/r157XxwmqQjjM+F6IyxZk5WXfaxq4pfZ6I8koQCnBBsugDc NIHpS1Vn7y90CHL/UhKa3/5cQzBCf+74owxiNTa+i2jTjA/UUaZaV4dwbx7Ve0FWkKZDwTDDIPM Zjjus7zmRe+DUw+ybahJXqpRRCmHX1sFeZWFrRj38jzqAzqsOIgBtPyILGDZzQOQN9ndSya8IZI m1Ec+taSjjJq+VpY4= X-Received: by 2002:a05:600c:3e0d:b0:490:4e3e:b483 with SMTP id 5b1f17b1804b1-4904e3eb5abmr160515815e9.22.1779696223543; Mon, 25 May 2026 01:03:43 -0700 (PDT) X-Received: by 2002:a05:600c:3e0d:b0:490:4e3e:b483 with SMTP id 5b1f17b1804b1-4904e3eb5abmr160515155e9.22.1779696222950; Mon, 25 May 2026 01:03:42 -0700 (PDT) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (212-8-243-115.hosted-by-worldstream.net. [212.8.243.115]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4904561f2dfsm217801585e9.12.2026.05.25.01.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 01:03:42 -0700 (PDT) Message-ID: <054cfff25288a98a7d7922de149be91fcbc79bc0.camel@redhat.com> Subject: Re: [PATCH 07/13] rv: Simply hybrid automata monitors's clock variables From: Gabriele Monaco To: Nam Cao Cc: Steven Rostedt , Wander Lairson Costa , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 25 May 2026 10:03:40 +0200 In-Reply-To: References: Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.1 (3.60.1-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-05-05 at 08:59 +0200, Nam Cao wrote: > -static inline bool ha_check_invariant_ns(struct ha_monitor *ha_mon, > - enum envs env, u64 time_ns) > +static inline bool ha_check_invariant_ns(struct ha_monitor *ha_mon, enum= envs > env, > + u64 time_ns, u64 expire_ns) > =C2=A0{ > - return READ_ONCE(ha_mon->env_store[env]) >=3D time_ns; > + return time_ns - READ_ONCE(ha_mon->env_store[env]) <=3D expire_ns; > =C2=A0} This function had the silent assumption that invalid/uninitialised values (max u64) pass the check. This is no longer working (see nomiss) but could be restored by doing: READ_ONCE(ha_mon->env_store[env]) >=3D time_ns - expire_ns But.. Yeah, that's a weak assumption. We should probably refactor the thing to use ha_reset_env() in ha_monitor_reset_all_stored(), then variables are never going to be uninitialised. It needs a bit of tinkering but it's definitely better than now. I'll try and add that to my fixes series. And I should add some nomiss and stall selftest.. > -static inline bool ha_check_invariant_jiffy(struct ha_monitor *ha_mon, > - =C2=A0=C2=A0=C2=A0 enum envs env, u64 time_ns) > +static inline bool ha_check_invariant_jiffy(struct ha_monitor *ha_mon, e= num > envs env, > + =C2=A0=C2=A0=C2=A0 u64 time_ns, u64 expire_jiffy) > =C2=A0{ > - return time_after64(READ_ONCE(ha_mon->env_store[env]), > get_jiffies_64()); > - > + return time_after64(READ_ONCE(ha_mon->env_store[env]) + expire_jiffy, > get_jiffies_64()); > =C2=A0} I'd prefer if this was consistent with the above as in (now - env <=3D expire) or (env >=3D now - env), whichever you prefer but let's keep it equivalent. Or do you have a reason to rearrange it here? Thanks, Gabriele