From: Pavel Begunkov <asml.silence@gmail.com>
To: Josef Bacik <josef@toxicpanda.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
dennis@kernel.org
Subject: Re: [PATCH 0/2] Fix misuse of blk_rq_stats in blk-iolatency
Date: Thu, 20 Jun 2019 20:18:55 +0300 [thread overview]
Message-ID: <054f3ab6-0a03-ff0e-ac46-5d0fba012cf0@gmail.com> (raw)
In-Reply-To: <20190614134037.ie7zs4rb4oyesifr@MacBook-Pro-91.local>
[-- Attachment #1.1: Type: text/plain, Size: 1040 bytes --]
Hi,
Josef, thanks for taking a look.
Although, there is nothing critical yet -- just a not working / disabled
optimisation, but changes in stats could sublty break it. E.g. grouping
@batch and @mean into a union will increase estimated average by several
orders of magnitude.
Jens, what do you think?
On 14/06/2019 16:40, Josef Bacik wrote:
> On Fri, Jun 14, 2019 at 02:44:11PM +0300, Pavel Begunkov (Silence) wrote:
>> From: Pavel Begunkov <asml.silence@gmail.com>
>>
>> There are implicit assumptions about struct blk_rq_stats, which make
>> it's very easy to misuse. The first patch fixes consequences, and the
>> second employs type-system to prevent recurrences.
>>
>>
>> Pavel Begunkov (2):
>> blk-iolatency: Fix zero mean in previous stats
>> blk-stats: Introduce explicit stat staging buffers
>>
>
> I don't have a problem with this, but it's up to Jens I suppose
>
> Acked-by: Josef Bacik <josef@toxicpanda.com>
>
> Thanks,
>
> Josef
>
--
Yours sincerely,
Pavel Begunkov
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-06-20 17:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 11:44 Pavel Begunkov (Silence)
2019-06-14 11:47 ` [PATCH 1/2] blk-iolatency: Fix zero mean in previous stats Pavel Begunkov (Silence)
2019-07-24 21:35 ` [RESEND RFC PATCH " Pavel Begunkov (Silence)
2019-06-14 11:47 ` [PATCH 2/2] blk-stats: Introduce explicit stat staging buffers Pavel Begunkov (Silence)
2019-07-24 21:35 ` [RESEND RFC PATCH " Pavel Begunkov (Silence)
2019-06-14 13:40 ` [PATCH 0/2] Fix misuse of blk_rq_stats in blk-iolatency Josef Bacik
2019-06-20 17:18 ` Pavel Begunkov [this message]
2019-06-29 15:37 ` Pavel Begunkov
2019-07-11 1:17 ` Pavel Begunkov
2019-07-24 21:35 ` [RESEND RFC PATCH " Pavel Begunkov (Silence)
2019-09-30 8:29 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=054f3ab6-0a03-ff0e-ac46-5d0fba012cf0@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=dennis@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome