From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2DBA305065 for ; Wed, 10 Dec 2025 09:05:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765357529; cv=none; b=fUfuo5PJSKX1h9/YjOYeT8IYLDmB2SJ04Fca/AKFWljA5INPwva5qE0d/10vODuI6IhP4NLZ7F4Il8BN0vINb96+CMfIBll5v0rNkm4gLzYLOws58y+3wtsZzKlmbUSk+TyZql1pN6t4xIAdkGDvkwb7C/IKrsEWF5NmYzKSjUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765357529; c=relaxed/simple; bh=tlcfNNvjCSuBgJw7ZQvJsY15oU0+a6o3yjIKfQ4dKlU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L2P00lrI58B7nwmEOMcbo6OIyBh0nJxsdYhQNT4E6Q8woH2Hmw9POl7QnHktFWFelaExbLeXLSBYfsghyHD6RrBEF1O+Y8ogMoC7J1zmTQc6pfbEopI84Orpa0Y8ZRLSw1wtRF7CDM4t2eAK4sLldvLF/zJ4JH6upuB+chCcdrk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MHkK0kWs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HOI8djgr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MHkK0kWs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HOI8djgr" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BA8e2t02669277 for ; Wed, 10 Dec 2025 09:05:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wqiA46dwUtdNEG3pj3Yg2uzx7d3+KbQKXu2IT3gW7Ek=; b=MHkK0kWsdTlYtPZT pw2i7g6xzT1r8OFyUFyDgWy0UAAz8nVp071Piv3qcf/i9HKjkYQU/KzvcG8yfTeW +pn6RRXAh3HSKHhRx2A9qdNq40svFFFHUuwY71ut/fu7zKLVqlLk/tNTeS6xFZgo qsyTRntjFxmSjBlZTOeLutZrNo9qOt0dy21EwteoqF+j6xHCjrMfPnIwNF6kktKy OvAOQiabGgLlMNAR4Mnq1CDoa4Q78cH474ZMpJDw0X2++cr/Nvb3MOpRp2yLnSTR hAXMAG01DZswLJOI1I6DXuonTs2R6aBMZb0ukxSJ0QB9UVfl2g5ICL7pubPBN3SY cyiQ7g== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ay4ykg6wv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Dec 2025 09:05:26 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-34a1bca4c2aso6582632a91.1 for ; Wed, 10 Dec 2025 01:05:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765357525; x=1765962325; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wqiA46dwUtdNEG3pj3Yg2uzx7d3+KbQKXu2IT3gW7Ek=; b=HOI8djgrhQQ7rEPtA89sigT9uQYWGTGwhvRSE0nVrXaJG+HkK1uZTMz2NvMaANXdSR tFTRjIg+raSL2btSdZ9m2RPvUuCqQCdfVk1PDyD7w5J4shFZuOv+P+FB0okfWODGhWDz ZR4OYJwbMFed2WBzGcxXMM2ph1lZA4XUusg7LAlw6BGiREkrVBqpHPjUbLzNDxAPfnVA jQqDeeBxSq8MJ06YS8r3A7rq7Y/sT6PycBia4HsnI6KfNF+xuUbqmhfYzHA2TJEVbG3d Q25Tf1yn9SBEg/qSo7mURJPalVbYPHnDOdkLJ0yQT9hrovcDK4CB8zWj4+67cYw2tAbe kgqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765357525; x=1765962325; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wqiA46dwUtdNEG3pj3Yg2uzx7d3+KbQKXu2IT3gW7Ek=; b=UGePYeVnSeBjELujw3HQYB4vTWIq7PVePFk8/ruWQwRD44+cxuStRE+/U/NKbf8ucN U19F8toBnsUo61Y/5gHueykJr6WD4g8dHSxDJRXmhJ4UeKgCNiOjjgYMtKpU0ojEDMyq EPESa54d/bMjkPdWr+b0e5smToHSyQQNNFC5Xke0ijQqgOJjXRrqrrQKKTlKX/ZGekv+ Ne0pemittLzZoYLaa1JIJcFIn7a1ZAdc9YFocjpIcbO258Hl/VV4Z9HAGA8SX+CBgDJj V/SUU6BvSB2StrrvaGfy1GQEkwdQpLlXR9TlNd9fg5KufjoacSRLqCXNLw11ZAf7tMhs k6Xw== X-Forwarded-Encrypted: i=1; AJvYcCV29/9noFplowGKKu7Wlcm7RYz02DYeIS9uyQKRhfdkf/GijOc8n7QvFzfeHiKLLp+pufuCAnGkrhlOg5M=@vger.kernel.org X-Gm-Message-State: AOJu0YwLK0mkkJzDpLiCsvzoPhg8c88CfHzECjLNNPduUZCestlNi//j Nk/EgVysYUZWvIEfWnX8Xb17cQuhnWf1cdNbOLCLoIqaxFxrfveL7EJsQW7ePnwcq1msENeNdJj AeCq0k6vQl3JT7qMz2I9JmHDaqwXEJ4C45ZDMcn9/4+Ebzu4uxvXhTZmDALtfUtb3ATc= X-Gm-Gg: AY/fxX511H642kV6WHOP8+07/N72KS4c8Cjd7PhyAEaXuF8frLngmfEMJi4TRbxmpzb Kh/qckk+S7mrwf42QUhRBDIeFhDqWPrNw0oRhYly1VtMFS/BCEX0/Zebky/JW2J56errdGaxntE f/VWHFB2efK7Z3Eq/xDG5rptRkH3NtCjnBtT4/fEZ17lmSIieZ3nxOERnpvFc1IXSSXDq7KbS87 IrhxC61kAcMtWKJ3xQE6PRs/lf0Oqip6ADz7A/ZzVMMLRBk3sscCHR6vfZN0GLBsmLhgFrPMmu3 XsjCxNgQYql3Tql7yjYyHaxup4SWj0NV+OxJxP+rZHW3Z28JE09f/BFoi+WxENyOKOa1gCEJoLR /u/CY4fhaakut2RF5U5FGygszUXQ2iejXFrznaYw= X-Received: by 2002:a17:90b:5388:b0:340:d1a1:af6d with SMTP id 98e67ed59e1d1-34a72883621mr1523341a91.36.1765357525393; Wed, 10 Dec 2025 01:05:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IE41gJN3yfndXfDh0Cw/GjZLd2NoFlvGIUFNVasqzCHoMkBAfdcn9k6a9O8IluhRLdFqv3daQ== X-Received: by 2002:a17:90b:5388:b0:340:d1a1:af6d with SMTP id 98e67ed59e1d1-34a72883621mr1523307a91.36.1765357524793; Wed, 10 Dec 2025 01:05:24 -0800 (PST) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34a7000c984sm1910606a91.6.2025.12.10.01.05.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Dec 2025 01:05:24 -0800 (PST) Message-ID: <05581cbd-dfcc-41ac-9020-b1590b8ed7a8@oss.qualcomm.com> Date: Wed, 10 Dec 2025 14:35:19 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] arm64: defconfig: Enable QCOMTEE on Qualcomm SM8650+ To: Bjorn Andersson , Dmitry Baryshkov Cc: Krzysztof Kozlowski , Konrad Dybcio , Sumit Garg , Jens Wiklander , Amirreza Zarrabi , Arnd Bergmann , Geert Uytterhoeven , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org References: <20251208-qcom_qcomtee_defconfig-v3-1-b50dcf8ab45e@oss.qualcomm.com> <309e0391-58a3-466b-a113-ab864188f6fe@kernel.org> Content-Language: en-US From: Harshal Dev In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: -6dKYB9oDwK8uV6BtCzvZ8uDMpydJF4m X-Authority-Analysis: v=2.4 cv=Mfthep/f c=1 sm=1 tr=0 ts=693937d6 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=brTnQUUJkzy-kVnKapkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: -6dKYB9oDwK8uV6BtCzvZ8uDMpydJF4m X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjEwMDA3OCBTYWx0ZWRfXxFLG+OPbwEmD T6e+nAQOmusiwiM6UgZnQ2kbAcYcFMKMYgvgtwuY6Oy1MhnFVhl2CtnMv6Odbj57TL5o3LWC1B5 X6Z6bvcPR87iJMarVisYOzSE0N+lx9t4EkFxDWznZjFYJwAvOsp2p0Ja8uXcNmsCLDmWDMErwXi 5ghezcU6Qk/823s9owuARCsge6TS9IGA3t8HfZC1bXj1mKsT2Wyjecl5wwixBY1MQoIUYkgWYaq 4/jgGmhcfWpf/FCT7Cqvpa2FjpQWFOa7pNWhzmQRAuiBmb4yJylz3ggyt+1X/3Ddv6skq30EMJB Z7PixKEaKLBIvFBb/mL1KfbY7WD+5m0HGfzgooOBmkMQaw7wc7jpapHXGIcgH4tV3j84AL7Ey1U 1V19pdz78HSDt4TMmCHnCtBUqK0BOw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-09_05,2025-12-09_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 adultscore=0 spamscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512100078 Hi Bjorn, On 12/10/2025 9:21 AM, Bjorn Andersson wrote: > On Mon, Dec 8, 2025 at 10:14 PM Dmitry Baryshkov > wrote: >> On Tue, 9 Dec 2025 at 07:58, Krzysztof Kozlowski wrote: >>> >>> On 08/12/2025 13:18, Harshal Dev wrote: >>>> Enable QCOMTEE driver on Qualcomm SM8650+ SoCs to facilitate communication >>>> with the Qualcomm Trusted Execution Environment (QTEE). >>>> (No enablement required in DTS files since QCOMTEE device is dynamically >>>> registered by the QCOM_SCM firmware driver) >>>> >>>> Signed-off-by: Harshal Dev >>>> --- >>>> Changes in v3: >>>> - Updated the commit message to reflect the supported Qualcomm platforms. >>>> - Link to v2: https://lore.kernel.org/r/20251205-qcom_qcomtee_defconfig-v2-1-c92560b0346e@qti.qualcomm.com >>>> >>> >>> I gave you the exact example to follow. Maybe it is not that important >>> for others, so I will not object, but OTOH it is important for me, thus >>> I will not give reviewed by. I damn asked VERY CLEARLY: >>> >>> "Just mention which UPSTREAM boards (which you called Qualcomm >>> platforms) use this driver." >> >> +1 Here. Defconfig changes mention devices, not SoC families. >> > > I don't agree that you have to mention a specific board, if the > feature is used by all boards. But I think the commit message should > make _that_ clear. > Thanks for this input Bjorn. I gather we are now aligned that the board information is not required. Then the other part to this is how to provide information on the particular SoCs using this. > On the contrary, the commit message says that we're enabling > CONFIG_QCOMTEE because it's used on "SM8560+". What does the plus > mean? I took reference from similar commits merged earlier where the plus seemed to indicate that all Qualcomm SoCs from 'SM8650' on-wards, that is, SM8750, SM8850 and so on. It felt that the plus sign is self-explanatory since it has been used already. But sure, maybe we can be explicit from now on and say from 'Qualcomm SM8650 onwards'. commit c5d02bbaa217b2454ba1ce7528113aa2ecf14f3c > Also, the driver isn't enabled "on Qualcomm SM8650+", it's enabled in > the Am64 defconfig, i.e. it's enabled on all Arm64 boards - the > question that should be answered by the commit message is "why?". > Even though we are enabling this via the arm64 defconfig, it is not true that the driver is applicable for all arm64 boards. The simple reason being that the QTEE firmware OS that the driver communicates with runs only on Qualcomm SoCs using arm64 CPUs with ARM TrustZone technology. This is why I would try to avoid a commit message which claims the the driver is applicable to all arm64 boards. Based on all this, I am thinking perhaps it would be better to say that the patch enables QCOMTEE driver for Qualcomm SoCs with arm64 CPUs? We could drop mentions of specific SM8x50 models with HDK/MTP boards since the feature is agnostic to those? > > PS. When you then run "git log arch/arm64/config/defconfig", the > information that enabling QCOMTEE doesn't require DeviceTree changes > is not useful. > Sure, I will drop the info on DTS files I added in the commit message. Thanks, Harshal > Regards, > Bjorn > >>> >>> Usage of something on SoC is not a proof that it actually is used by >>> upstream platforms and we absolutely do not care at all about downstream >>> users. I spent way too much time on this and even very specific >>> instructions were not working, so I don't know how else I can help. >>> >>> Best regards, >>> Krzysztof >> >> >> >> -- >> With best wishes >> Dmitry