From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3685B40C5C0 for ; Tue, 9 Jun 2026 12:17:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781007449; cv=none; b=iWXbocNZKI0VW8vS9eX30bZuUzV0Z3wv4MWRgzV/CahAwDuFb5ZSbb7CYBNiVxMaWuMDx53vvhepwcJLCovHoglpw2bpPGXycRGhGyvBA7i0sZgledb3cwKcAuVRIfWmeNEoPzZLuCEeFcI4iNByNXXBql3KDPAZ4NtBlAg0i5I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781007449; c=relaxed/simple; bh=7mY4ZLLEtPhXCIzYG6qT0auuWpAN+xsmJ6MePgj9U70=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EAuMQQaK3KaRpE7bqS1wQbuJYIPshCHnYUK/183Q7cEZNXD/sZj8Zm8FdpmKiIjj2oRuaqCrPrkOzT1LSfIxbKUjRH4/AwDqg9+oZNR9OF8P0xNtChohqkrI5Br/Hb0OLq1aHPtYC0EJwlFUgFjDHO4zfRSU3BYLYVFCCGTCd6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PVQVXxTM; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PVQVXxTM" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-45ef6565cfdso2564392f8f.0 for ; Tue, 09 Jun 2026 05:17:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781007446; x=1781612246; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0sf15Qn18zljQFqjYtY+ttqovVDRkyxEeVFCISge3H8=; b=PVQVXxTMsOamZccx0PR52rnSacwaUSO0Wr8g9gKplkHQsHXGFHmztBfWlAmYdrvIj1 NQnlcqGUaSmWhMklqIUXg/8am1A5naQQroZJjRXXxGUkNNF9bNL9HqP0QAqGFRLsXG6u BP8Gj4goS8iZYmWkLfFlpqYu6sEaphoZKRQixRRxIfRvirMBcANrqa2sgOenQ1mH4GYQ aqwkrx9GznkR2vNunSOS324nJbdoseEnm8lwSxxyaX5lPMvOpDELaExK5Nx8h/q4O4Lz zG1kavv7BZoyoSggAFlBDWCBD2ceGj+Wifkc6jg4iYytXxbFp2YGNFcqr8jvWOFoWM30 gAcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781007446; x=1781612246; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0sf15Qn18zljQFqjYtY+ttqovVDRkyxEeVFCISge3H8=; b=SK2SbuSt/x7yQFbMInQJzee72tDCNXXllTGUJxki8ZC7/SIxnhs81fqjMjqskGwgwp oi9s58+P74K60wqk+L5Vv42WBcNMUBJzIhSOv0QG4G/b+iojcNPl/PjvjmMjS/nLTekK K6kCAzpVvg0AGsT0cPwYKWk+gKJ2Tdsq/voWOFThXclizhm7dY/dpxHoYdcvT1lj0fkZ HdhH7w0oFXPl4wJKS5G4xzSDhokPg+iMfpJl+EaI3cosu6xfh4IkhNgs//F7jsQqgaJP p1FPkGg3uOdagV/iap72oucGDwOdkbZZpPVw9juzacc6v6aAAZAMIlo0xqZru7WLsHbE lEZg== X-Forwarded-Encrypted: i=1; AFNElJ/Kg6VGu5lMpc+67gNAu4rTmIgvcCXJn44kfLwL35gA3/40litZK37ArP94kTQk6oWeGo0+3SIml6nVfQE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2hSuoIIba0g2r4fw0GEF0Eci+J0HSLWVHQiIBzcg2L5Y+vXkD SNwK6yzCWIkFZJCg9KzgGc4VKxKQftFuifZX8dR+7bxPr3QP60I7X4Phs/yjEQe7+34= X-Gm-Gg: Acq92OGlnr/+87D5fQ1IokN7RDZ0xjibZwYTvH54dveUbi6H7Aee4BM+JW4HmSmE6QC NvBGvhBQBTJtUpCXtNi+ipeOyTZafqzbyPMyQb+t/csxgL0VhHK9+0zFwNqhMYYu0Bt2k7PFBt7 WzUpuIw2NLrUuTlAUez0wWrFyWEBS/zVL8Ofn1W5mQ8SaFqJnj4eXTRs23aZDi9O6pSBYTWXBks O6bGWfE+YAVpR9kaHsBbxBjKJgfoNU3BApIW2/9cl5tqA2Tut5/giiFYXoaJg4ejjwF0Zkz5C9e sOYV5dxW2vJNn9/+HnaHilLRNNlYzhzyGVluEof9pFuEw6bIDBHMICw7SPe0Pl81VeIgI2NClCP dCFMsfK1rjvxa3h0vyT53K6IlOoudRKInEF/C6QwJTneTz2DgMubv9ktLniV0VJPQug8RDgg+MF s1WHiJKYlsFWDHOb4jjACgdW7BMGkGH1t/RWb8oBU0qu4SOjicBEOR X-Received: by 2002:a05:6000:25e7:b0:460:3233:beef with SMTP id ffacd0b85a97d-460566dc381mr3315017f8f.43.1781007445883; Tue, 09 Jun 2026 05:17:25 -0700 (PDT) Received: from [10.11.12.110] ([82.76.215.73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f351ac0sm110033645f8f.27.2026.06.09.05.17.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 05:17:25 -0700 (PDT) Message-ID: <055b5f99-887d-473e-8211-aefb253cb549@linaro.org> Date: Tue, 9 Jun 2026 15:17:21 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 4/5] arm64: dts: exynos: gs101: Add thermal management unit To: =?UTF-8?Q?Andr=C3=A9_Draszik?= , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Kees Cook , "Gustavo A. R. Silva" , Peter Griffin , Alim Akhtar Cc: jyescas@google.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20260603-acpm-tmu-v8-0-0f1810a356e6@linaro.org> <20260603-acpm-tmu-v8-4-0f1810a356e6@linaro.org> <08d7299968e14e5fc07fa4791479abd9a2b11c2d.camel@linaro.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: <08d7299968e14e5fc07fa4791479abd9a2b11c2d.camel@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/9/26 2:44 PM, André Draszik wrote: > Hi Tudor, > Hi! > On Wed, 2026-06-03 at 13:00 +0000, Tudor Ambarus wrote: > >> >> [...] >> >> diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi >> index 86933f22647b..b6866ef99fb3 100644 >> --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi >> +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi >> >> [...] >> >> @@ -639,6 +647,15 @@ watchdog_cl1: watchdog@10070000 { >>   status = "disabled"; >>   }; >>   >> + tmu_top: thermal-sensor@100a0000 { >> + compatible = "google,gs101-tmu-top"; >> + reg = <0x100a0000 0x800>; >> + clocks = <&cmu_misc CLK_GOUT_MISC_TMU_TOP_PCLK>; >> + interrupts = ; >> + samsung,acpm-ipc = <&acpm_ipc>; >> + #thermal-sensor-cells = <1>; > > Vendor-specific properties should always come after generic ones > (samsung,... to move to end here). Yes, thanks! I'll address this after I get some feedback on the driver from the thermal maintainers. Cheers, ta