From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B033C04A68 for ; Thu, 28 Jul 2022 18:44:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232120AbiG1Sok (ORCPT ); Thu, 28 Jul 2022 14:44:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232100AbiG1Soi (ORCPT ); Thu, 28 Jul 2022 14:44:38 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1F9DB7539C for ; Thu, 28 Jul 2022 11:44:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659033876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i5DZbLJbyft2xfK4rEmaQLiZfAqfd5MekksSTpFvPNo=; b=Nw6/R/5pAYigatyEYVPeZRI3CxT34tvswSjl+Hhz+Xi7dvOzUhoEqSp9axHhJQAvdr6MHV 1WtgbTSmp1NCDJcuixwe0/U2fLLi3WTAyG1PkMI2jH1zhAXiTx76lDVgUQh0/Yb/5dntLC qstTL5ElKEprXKDljLLRq5iie2HfFNo= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-37-I9Mc_KvMMpeMfNJzPiygIg-1; Thu, 28 Jul 2022 14:44:34 -0400 X-MC-Unique: I9Mc_KvMMpeMfNJzPiygIg-1 Received: by mail-ed1-f71.google.com with SMTP id e6-20020a056402190600b0043bde36ab23so1625407edz.11 for ; Thu, 28 Jul 2022 11:44:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=i5DZbLJbyft2xfK4rEmaQLiZfAqfd5MekksSTpFvPNo=; b=cJR6BZrA7zgXKGR8wZ4m6suJAXlCUe9JGvTvJ5gtAWxq2IBympAisq9jWnf8LIAXmT NqmuJtViETUluChOEAnegSMU5ZF1A0WSxsddZ42j1nCWLWU+NZCdHdzH5Qsj0h3ZSW9t oxNSGwWx7lk10zC2qcIbzE6HvWmQrVxxkfkIukVHdDinOZ3WKkxSyLpav3TvHXH3IGx7 ZZtE1O3IuE2fvlcSXFE5QPxRLAwL7CmuUutOT7G5II5ApPDJ8zq+IRwUSFFce7DeZzeZ xkRhdzqexdX1bbK+NSKDUMDiVceJcgWgg1hMSSOoa3tE58w7UQJ6QcebeoZRKEvPvYgV 2tqg== X-Gm-Message-State: AJIora+7aKr6pZMf+iXr+JTMhu7Y7WLwS2M8XomiAD2BHSJbRocfJrcp NMnZya/2s0Y1s6MTnKSJ+m8DS3yg9wUbzAhDQkwmoWq/bwzGmj+hjQPRcE2FQt2GVhn7FkgjfTS LUp3kl+Uv22UhyHIRoTpjc3ad X-Received: by 2002:a05:6402:3511:b0:43b:c84c:e233 with SMTP id b17-20020a056402351100b0043bc84ce233mr267140edd.211.1659033873557; Thu, 28 Jul 2022 11:44:33 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sDDQj1w6C4bmpLIJZ5NoEIbhdwKazzBeLPMikzRKiO1K6X2FI580MhCxThPTmuwssGg2ZUBg== X-Received: by 2002:a05:6402:3511:b0:43b:c84c:e233 with SMTP id b17-20020a056402351100b0043bc84ce233mr267129edd.211.1659033873394; Thu, 28 Jul 2022 11:44:33 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id a8-20020aa7d908000000b0043bc33530ddsm1153823edr.32.2022.07.28.11.44.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 11:44:32 -0700 (PDT) Message-ID: <055c43cb-26f3-9a51-8e59-e0133e3839c1@redhat.com> Date: Thu, 28 Jul 2022 20:44:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] platform/surface: gpe: Add support for 13" Intel version of Surface Laptop 4 Content-Language: en-US To: Maximilian Luz Cc: Mark Gross , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220721121120.2002430-1-luzmaximilian@gmail.com> From: Hans de Goede In-Reply-To: <20220721121120.2002430-1-luzmaximilian@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 7/21/22 14:11, Maximilian Luz wrote: > The 13" Intel version of the Surface Laptop 4 uses the same GPE as the > Surface Laptop Studio for wakeups via the lid. Set it up accordingly. > > Signed-off-by: Maximilian Luz Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/surface/surface_gpe.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/platform/surface/surface_gpe.c b/drivers/platform/surface/surface_gpe.c > index 27365cbe1ee9..c219b840d491 100644 > --- a/drivers/platform/surface/surface_gpe.c > +++ b/drivers/platform/surface/surface_gpe.c > @@ -171,6 +171,18 @@ static const struct dmi_system_id dmi_lid_device_table[] = { > }, > .driver_data = (void *)lid_device_props_l4D, > }, > + { > + .ident = "Surface Laptop 4 (Intel 13\")", > + .matches = { > + /* > + * We match for SKU here due to different variants: The > + * AMD (15") version does not rely on GPEs. > + */ > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"), > + DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "Surface_Laptop_4_1950:1951"), > + }, > + .driver_data = (void *)lid_device_props_l4B, > + }, > { > .ident = "Surface Laptop Studio", > .matches = {