From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Rob Herring <robh@kernel.org>
Cc: Wei Xu <xuwei5@hisilicon.com>,
Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Libin <huawei.libin@huawei.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: Re: [PATCH v4 12/20] dt-bindings: arm: hisilicon: convert hisilicon,hi3798cv200-perictrl bindings to json-schema
Date: Tue, 29 Sep 2020 11:18:14 +0800 [thread overview]
Message-ID: <0568ed90-c6ac-ae1c-45ee-cdc6526d3fcf@huawei.com> (raw)
In-Reply-To: <20200928191425.GA3099266@bogus>
On 2020/9/29 3:14, Rob Herring wrote:
> On Mon, Sep 28, 2020 at 11:13:16PM +0800, Zhen Lei wrote:
>> Convert the Hisilicon Hi3798CV200 Peripheral Controller binding to DT
>> schema format using json-schema.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>> .../controller/hisilicon,hi3798cv200-perictrl.txt | 21 ----------
>> .../controller/hisilicon,hi3798cv200-perictrl.yaml | 45 ++++++++++++++++++++++
>> 2 files changed, 45 insertions(+), 21 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,hi3798cv200-perictrl.txt
>> create mode 100644 Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,hi3798cv200-perictrl.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,hi3798cv200-perictrl.txt b/Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,hi3798cv200-perictrl.txt
>> deleted file mode 100644
>> index 0d5282f4670658d..000000000000000
>> --- a/Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,hi3798cv200-perictrl.txt
>> +++ /dev/null
>> @@ -1,21 +0,0 @@
>> -Hisilicon Hi3798CV200 Peripheral Controller
>> -
>> -The Hi3798CV200 Peripheral Controller controls peripherals, queries
>> -their status, and configures some functions of peripherals.
>> -
>> -Required properties:
>> -- compatible: Should contain "hisilicon,hi3798cv200-perictrl", "syscon"
>> - and "simple-mfd".
>> -- reg: Register address and size of Peripheral Controller.
>> -- #address-cells: Should be 1.
>> -- #size-cells: Should be 1.
>> -
>> -Examples:
>> -
>> - perictrl: peripheral-controller@8a20000 {
>> - compatible = "hisilicon,hi3798cv200-perictrl", "syscon",
>> - "simple-mfd";
>> - reg = <0x8a20000 0x1000>;
>> - #address-cells = <1>;
>> - #size-cells = <1>;
>> - };
>> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,hi3798cv200-perictrl.yaml b/Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,hi3798cv200-perictrl.yaml
>> new file mode 100644
>> index 000000000000000..4e547017e368393
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,hi3798cv200-perictrl.yaml
>> @@ -0,0 +1,45 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/arm/hisilicon/controller/hisilicon,hi3798cv200-perictrl.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Hisilicon Hi3798CV200 Peripheral Controller
>> +
>> +maintainers:
>> + - Wei Xu <xuwei5@hisilicon.com>
>> +
>> +description: |
>> + The Hi3798CV200 Peripheral Controller controls peripherals, queries
>> + their status, and configures some functions of peripherals.
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - const: hisilicon,hi3798cv200-perictrl
>> + - const: syscon
>> + - const: simple-mfd
>> +
>> + reg:
>> + description: Register address and size
>> + maxItems: 1
>> +
>> + '#address-cells':
>> + const: 1
>> +
>> + '#size-cells':
>> + const: 1
>
> That implies child nodes. You need some sort of schema for them.
OK, I will drop #address-cells and #size-cells in this binding.
>
>> +
>> +required:
>> + - compatible
>> + - reg
>> +
>> +examples:
>> + - |
>> + perictrl: peripheral-controller@8a20000 {
>> + compatible = "hisilicon,hi3798cv200-perictrl", "syscon", "simple-mfd";
>> + reg = <0x8a20000 0x1000>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + };
>> +...
>> --
>> 1.8.3
>>
>>
>
> .
>
next prev parent reply other threads:[~2020-09-29 3:18 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 15:13 [PATCH v4 00/20] add support for Hisilicon SD5203 SoC Zhen Lei
2020-09-28 15:13 ` [PATCH v4 01/20] dt-bindings: arm: hisilicon: split the dt-bindings of each controller into a separate file Zhen Lei
2020-09-28 19:05 ` Rob Herring
2020-09-29 3:05 ` Leizhen (ThunderTown)
2020-09-28 15:13 ` [PATCH v4 02/20] dt-bindings: arm: hisilicon: convert Hisilicon board/soc bindings to json-schema Zhen Lei
2020-09-28 19:06 ` Rob Herring
2020-09-28 15:13 ` [PATCH v4 03/20] dt-bindings: arm: hisilicon: add binding for SD5203 SoC Zhen Lei
2020-09-28 19:07 ` Rob Herring
2020-09-29 3:05 ` Leizhen (ThunderTown)
2020-09-28 15:13 ` [PATCH v4 04/20] ARM: hisi: add support " Zhen Lei
2020-09-28 15:13 ` [PATCH v4 05/20] ARM: debug: add UART early console support for SD5203 Zhen Lei
2020-09-28 15:13 ` [PATCH v4 06/20] ARM: dts: add SD5203 dts Zhen Lei
2020-09-28 15:13 ` [PATCH v4 07/20] dt-bindings: arm: hisilicon: convert system controller bindings to json-schema Zhen Lei
2020-09-28 19:13 ` Rob Herring
2020-09-29 3:09 ` Leizhen (ThunderTown)
2020-09-28 15:13 ` [PATCH v4 08/20] dt-bindings: arm: hisilicon: convert hisilicon,peri-subctrl " Zhen Lei
2020-09-28 15:13 ` [PATCH v4 09/20] dt-bindings: arm: hisilicon: convert hisilicon,pcie-sas-subctrl " Zhen Lei
2020-09-28 15:13 ` [PATCH v4 10/20] dt-bindings: arm: hisilicon: convert hisilicon,cpuctrl " Zhen Lei
2020-09-28 15:13 ` [PATCH v4 11/20] dt-bindings: arm: hisilicon: convert hisilicon,pctrl " Zhen Lei
2020-09-28 15:13 ` [PATCH v4 12/20] dt-bindings: arm: hisilicon: convert hisilicon,hi3798cv200-perictrl " Zhen Lei
2020-09-28 19:14 ` Rob Herring
2020-09-29 3:18 ` Leizhen (ThunderTown) [this message]
2020-09-29 9:21 ` Leizhen (ThunderTown)
2020-09-29 13:25 ` Leizhen (ThunderTown)
2020-09-29 13:52 ` Rob Herring
2020-09-30 1:59 ` Leizhen (ThunderTown)
2020-09-28 15:13 ` [PATCH v4 13/20] dt-bindings: arm: hisilicon: convert hisilicon,dsa-subctrl " Zhen Lei
2020-09-28 15:13 ` [PATCH v4 14/20] dt-bindings: arm: hisilicon: convert hisilicon,hip04-fabric " Zhen Lei
2020-09-28 15:13 ` [PATCH v4 15/20] dt-bindings: arm: hisilicon: convert hisilicon,hip04-bootwrapper " Zhen Lei
2020-09-28 15:13 ` [PATCH v4 16/20] dt-bindings: arm: hisilicon: convert hisilicon,hi6220-aoctrl " Zhen Lei
2020-09-28 15:13 ` [PATCH v4 17/20] dt-bindings: arm: hisilicon: convert hisilicon,hi6220-mediactrl " Zhen Lei
2020-09-28 15:13 ` [PATCH v4 18/20] dt-bindings: arm: hisilicon: convert hisilicon,hi6220-pmctrl " Zhen Lei
2020-09-28 15:13 ` [PATCH v4 19/20] dt-bindings: arm: hisilicon: convert hisilicon,hi6220-sramctrl " Zhen Lei
2020-09-28 15:13 ` [PATCH v4 20/20] dt-bindings: arm: hisilicon: convert LPC controller " Zhen Lei
2020-09-28 19:16 ` Rob Herring
2020-09-29 3:11 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0568ed90-c6ac-ae1c-45ee-cdc6526d3fcf@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=huawei.libin@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®