From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A4B02D060B for ; Sat, 18 Jul 2026 03:14:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784344471; cv=none; b=By7Jl08UaBerIjTPK++E2VUwYv+GgzlVh5ghrBYLFjeYTruq29YKs21jaCFoIgnBRIhWoW9yGthphqXHVUq631FlV5++7Wwcg+lYu2MZovojbAYIaPPoi0knx3g0JGxJHJp83tnQ+bWH07fiqD4VspVV4s3RirtAJeoG4tJzF3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784344471; c=relaxed/simple; bh=75OM78mDBv7m0To6+md2VJeNP93zZkpntH2fn/Xm0mk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ft4BxjrMmOtS7lq6eVA45bSAn47Gk9CdOFTaE63UYis9X19XufqncuWlEMBHXBugQ1MyPnkkwB9Y/MuRuXLpvgjQHEvYn1xLHMsDXA8Fe8P8NUvtHXAsgV9Q9HhmQfVOI8zEfjH/sIu9KvZJqwBwytoBKj6bANdlr0BOd2qLnBc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TjX+oiiL; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TjX+oiiL" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2ccf2360620so46202695ad.3 for ; Fri, 17 Jul 2026 20:14:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784344468; x=1784949268; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7Bsb8pItnWyhU9Za19CXZcnsh1n2I7MhDPWvur0EhQA=; b=TjX+oiiLQl6GUiTULDN3gUzFxL0eAVI08RuwxeHRnKGSnmL4J4CdBGBI27FXKcmDl1 W6P6hpDkQ6l5Y7b365i+PflYM9yYFvC55DPwIZL8IAXXAvqfgYZT71TKm7lKIQuCcdJp Vrog++Ahu5uq3oIb6mQGFFpHnJyazm+2sliBWD0d85doatXcLIZ2FwUtxRHGf7bPpxJx bct29DMYajyD2oiGbdMknH64u7l7EnZm6kA2OcjxzO3HKVl5baLQwdAn6lbej0143nZU lYeEAEKJ5q6tGASkUjnkWZipV57k6Twk9u6ptlWAjFawWM263FPwkaFic6gi5vCh9C6x fU8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784344468; x=1784949268; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7Bsb8pItnWyhU9Za19CXZcnsh1n2I7MhDPWvur0EhQA=; b=RPx+wW4ntaFSH0kPaDWtNzK7Tequ7eo///PEgFAmco/R/tzxHcJ+7R4NUQ/hkD782J VPjIw0l3nMNBhEfBMU36jxS5ChYesr+cQNpKd1YeDr7IH9aGEg2DuEfe0haidG0lWhRs mi6yEqolfgTwILkZ80nkHDhZtYRZRrSz5cLXbz5T6VqMHECp5FMyavjFQDEMKu72OgGr I4om1J0F/j0+a3LoC6LRyfZLsmx9WjJAxZUL86KX9SIE9iODFyn5mxyz/HDKIohvtYPH NyEd4phRFWa9D9Lpw57oICcjVe8fUqNKJt+Ik31WD4g/VXO4xnPPb3Tm/G4lrPOWYwjz EW1w== X-Forwarded-Encrypted: i=1; AHgh+RpH7iDjLZxiuivEdLelpvS+XY4JuryVUc0scbLKlgU+2rTmJGYrdVJ95glfLgS1uDwHOeNPEeRnp0gwSQ8=@vger.kernel.org X-Gm-Message-State: AOJu0Yzv8AXN0nu6IvRA0HGXng+UN7wgLOHzpRTJ/Ez3I6oV0xm8bpiB ASvNK7kXsMlLGZr4m5spO3FJsipyj0eh6fnZRABwLdQyicIbDkHzE5eiRDaLFQ== X-Gm-Gg: AfdE7ckTFWPA/q5x5mWluhImm7Rl96jWijYylHRegNfCxru3PQSxLL6xp2KJYUdHBhM 8h+s4L1lrPjrrOdp6SNZS8ND8iAfHzfAbfWAQbxV8N3IOD8xNqiaNd8H09gIw5utdHzCmtzuG3T 2i8DzjKQY/ZlXRdcMAc0nou4Nm5z7y0HmTtGDfldDWrR7AgjuUagMOWKjsXwXGiyF99WZAs0g3h PielRtmnzOeUWeY+EGb0+zn8t5fW2+SUX6zf/xBrwQPQjkKMUOAxT8qWBZlQEQJt6sZBFYg901L WtBH69z5iwrA0nrZjfVDE6pmG1VDBLPoo0npJ9k9MMF7XmD8HY0/LnOrSzWqxhibaCIUFFVGvqj TtCPMz6ZlOn3VRho0cIrJhZS+xC2U6sqBTu7MBkEuqW1x4N6VfYSSv4RVyFCJbqGEwkVFFZtnWN 5IIYgUcHR7n3MqxF9O4nA= X-Received: by 2002:a17:903:a90:b0:2ca:bf8e:35fe with SMTP id d9443c01a7336-2cf348917fcmr55314575ad.16.1784344467742; Fri, 17 Jul 2026 20:14:27 -0700 (PDT) Received: from [192.168.86.23] ([136.25.189.61]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13ce29c2dcdsm8895519c88.1.2026.07.17.20.14.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2026 20:14:27 -0700 (PDT) Message-ID: <056b1312-f6f5-4c85-adae-d9b9ce6857b5@gmail.com> Date: Fri, 17 Jul 2026 20:14:23 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] platform/x86: hsmp: Check ACPI_COMPANION() against NULL To: Jiale Yao , platform-driver-x86@vger.kernel.org Cc: Naveen Krishna Chatradhi , Carlos Bilbao , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , linux-kernel@vger.kernel.org References: <20260713151422.82947-1-yaojiale02@163.com> <20260713151422.82947-3-yaojiale02@163.com> Content-Language: en-US From: Carlos Bilbao In-Reply-To: <20260713151422.82947-3-yaojiale02@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/13/26 08:14, Jiale Yao wrote: > Add a requisite ACPI_COMPANION() check against NULL to the > AMD HSMP acpi probe, aligning with the fix applied to > asus-wireless driver. The commit message makes no sense. > > Assisted-by: claude:deepseek-v4-pro > Signed-off-by: Jiale Yao > --- > drivers/platform/x86/amd/hsmp/acpi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/platform/x86/amd/hsmp/acpi.c b/drivers/platform/x86/amd/hsmp/acpi.c > index 97ed71593bdf..615b3ebe66e7 100644 > --- a/drivers/platform/x86/amd/hsmp/acpi.c > +++ b/drivers/platform/x86/amd/hsmp/acpi.c > @@ -71,6 +71,8 @@ static inline int hsmp_get_uid(struct device *dev, u16 *sock_ind) > { > char *uid; > > + if (!ACPI_COMPANION(dev)) > + return -ENODEV; Check uid != NULL after the assignment below too, then? > /* > * UID (ID00, ID01..IDXX) is used for differentiating sockets, > * read it and strip the "ID" part of it and convert the remaining Thanks, Carlos