mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Colin King (gmail)" <colin.i.king@gmail.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: re: drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API
Date: Wed, 2 Jul 2025 10:41:52 +0100	[thread overview]
Message-ID: <056b34c3-c1ea-4b8c-9672-c98903ffd012@gmail.com> (raw)


[-- Attachment #1.1.1: Type: text/plain, Size: 913 bytes --]

Hi,

I believe there is a regression in linux-next caused by the following 
commit:

commit a59a271769149f0b8258507276f3d2a24370cbdb
Author: Luca Ceresoli <luca.ceresoli@bootlin.com>
Date:   Wed May 28 11:29:36 2025 +0200

     drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API


the issue is as follows:

static int tc_probe_bridge_endpoint(struct tc_data *tc, enum tc_mode mode)
{
         struct device *dev = tc->dev;
         struct of_endpoint endpoint;
         struct device_node *node = NULL;

         for_each_endpoint_of_node(dev->of_node, node) {
                 if (endpoint.port == 2) {
			...
			...

The check for endpoint.port == 2 is checking an uninitialized field in 
the uninitialized structure endpoint. The code before this commit called 
  of_graph_parse_endpoint(node, &endpoint) to fetch endpoint and now 
this seems to be missing.

Colin



[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 4901 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

             reply	other threads:[~2025-07-02  9:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02  9:41 Colin King (gmail) [this message]
2025-07-03 16:09 ` Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=056b34c3-c1ea-4b8c-9672-c98903ffd012@gmail.com \
    --to=colin.i.king@gmail.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®