mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zhantao Tang <zhantao.tang@windriver.com>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	linux-kernel@vger.kernel.org
Cc: bigeasy@linutronix.de, tglx@linutronix.de, rostedt@goodmis.org,
	linux-rt-users@vger.kernel.org
Subject: Re: [PATCH linux-5.2.y-rt only] hrtimer: correct the logic for grab expiry lock
Date: Thu, 13 Aug 2020 09:57:19 +0800	[thread overview]
Message-ID: <05700b0e-1edf-ab5c-ea81-4d4f8f2c20b6@windriver.com> (raw)
In-Reply-To: <86790e56-9cec-5cea-8387-f7010b88708b@prevas.dk>


在 2020/8/12 下午7:45, Rasmus Villemoes 写道:
> On 12/08/2020 12.50, zhantao.tang@windriver.com wrote:
>> From: Zhantao Tang <zhantao.tang@windriver.com>
>>
>> In commit: 47b6de0b7f22 ("hrtimer: Add a missing bracket and hide `migration_base' on !SMP")
>> a inline function is_migration_base() is introduced. But
>> the logic of the hrtimer_grab_expiry_lock was changed.
>>
>> This patch is to correct it.
>>
> Yup, same patch sent back in April, which also had a fixes tag for 5.2.
>
> https://lore.kernel.org/lkml/20200428144026.5882-1-rasmus.villemoes@prevas.dk/
>
> It got picked up for 4.19-rt, dunno why it wasn't for 5.2-rt.

Yes， currently 5.2 rt kernel not fix the issue.

And I checked the 4.19 rt kernel, but  did not find the implementation 
of hrtimer_grab_expiry_lock().

It used hrtimer_wait_for_timer() and the logic is OK.


Thanks,

Zhantao

>
> Rasmus

      parent reply	other threads:[~2020-08-13  1:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-12 10:50 zhantao.tang
2020-08-12 11:45 ` Rasmus Villemoes
2020-08-12 15:08   ` Steven Rostedt
2020-08-13  1:57   ` Zhantao Tang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05700b0e-1edf-ab5c-ea81-4d4f8f2c20b6@windriver.com \
    --to=zhantao.tang@windriver.com \
    --cc=bigeasy@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®