From: "James R. Bergsten" <jim@thebergstens.com>
To: "'Keith Busch'" <keith.busch@intel.com>,
"'Javier González'" <javier@paletta.io>
Cc: hch@infradead.org, "'Matias Bjørling'" <m@bjorling.me>,
axboe@fb.com, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org
Subject: RE: [PATCH 5/5 v2] nvme: LightNVM support
Date: Thu, 16 Apr 2015 09:01:35 -0700 [thread overview]
Message-ID: <057301d0785e$9f8e81c0$deab8540$@thebergstens.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1504161528010.32385@localhost.lm.intel.com>
My two cents worth is that it's (always) better to put ALL the commands into one place so that the entire set can be viewed at once and thus avoid inadvertent overloading of an opcode. Otherwise you don't know what you don't know.
-----Original Message-----
From: Linux-nvme [mailto:linux-nvme-bounces@lists.infradead.org] On Behalf Of Keith Busch
Sent: Thursday, April 16, 2015 8:52 AM
To: Javier González
Cc: hch@infradead.org; Matias Bjørling; axboe@fb.com; linux-kernel@vger.kernel.org; linux-nvme@lists.infradead.org; Keith Busch; linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 5/5 v2] nvme: LightNVM support
On Thu, 16 Apr 2015, Javier González wrote:
>> On 16 Apr 2015, at 16:55, Keith Busch <keith.busch@intel.com> wrote:
>>
>> Otherwise it looks pretty good to me, but I think it would be cleaner
>> if the lightnvm stuff is not mixed in the same file with the standard
>> nvme command set. We might end up splitting nvme-core in the future
>> anyway for command sets and transports.
>
> Would you be ok with having nvme-lightnvm for LightNVM specific
> commands?
Sounds good to me, but I don't really have a dog in this fight. :)
next prev parent reply other threads:[~2015-04-16 16:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 12:34 [PATCH 0/5 v2] Support for Open-Channel SSDs Matias Bjørling
2015-04-15 12:34 ` [PATCH 1/5 v2] blk-mq: Add prep/unprep support Matias Bjørling
2015-04-17 6:34 ` Christoph Hellwig
2015-04-17 8:15 ` Matias Bjørling
2015-04-17 17:46 ` Christoph Hellwig
2015-04-18 6:45 ` Matias Bjorling
2015-04-18 20:16 ` Christoph Hellwig
2015-04-19 18:12 ` Matias Bjorling
2015-04-15 12:34 ` [PATCH 2/5 v2] blk-mq: Support for Open-Channel SSDs Matias Bjørling
2015-04-16 9:10 ` Paul Bolle
2015-04-16 10:23 ` Matias Bjørling
2015-04-16 11:34 ` Paul Bolle
2015-04-16 13:29 ` Matias Bjørling
2015-04-15 12:34 ` [PATCH 3/5 v2] lightnvm: RRPC target Matias Bjørling
2015-04-16 9:12 ` Paul Bolle
2015-04-15 12:34 ` [PATCH 4/5 v2] null_blk: LightNVM support Matias Bjørling
2015-04-15 12:34 ` [PATCH 5/5 v2] nvme: " Matias Bjørling
2015-04-16 14:55 ` Keith Busch
2015-04-16 15:14 ` Javier González
2015-04-16 15:52 ` Keith Busch
2015-04-16 16:01 ` James R. Bergsten [this message]
2015-04-16 16:12 ` Keith Busch
2015-04-16 17:17 ` Matias Bjorling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='057301d0785e$9f8e81c0$deab8540$@thebergstens.com' \
--to=jim@thebergstens.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=javier@paletta.io \
--cc=keith.busch@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=m@bjorling.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®