From: David Laight <David.Laight@ACULAB.COM>
To: 'Julian Vetter' <jvetter@kalrayinc.com>,
Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, "Guo Ren" <guoren@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
Andrew Morton <akpm@linux-foundation.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
Richard Henderson <richard.henderson@linaro.org>,
Niklas Schnelle <schnelle@linux.ibm.com>,
Takashi Iwai <tiwai@suse.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Johannes Berg <johannes@sipsolutions.net>,
Christoph Hellwig <hch@infradead.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-csky@vger.kernel.org" <linux-csky@vger.kernel.org>,
"loongarch@lists.linux.dev" <loongarch@lists.linux.dev>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
Yann Sionneau <ysionneau@kalrayinc.com>
Subject: RE: [PATCH v10 0/4] Replace fallback for IO memcpy and IO memset
Date: Mon, 21 Oct 2024 14:16:51 +0000 [thread overview]
Message-ID: <0577266edb9440acb082c9e02c0a73b9@AcuMS.aculab.com> (raw)
In-Reply-To: <20241021133154.516847-1-jvetter@kalrayinc.com>
From: Julian Vetter
> Sent: 21 October 2024 14:32
>
> Thank you again for your remarks Arnd and Christoph! I have updated the
> patchset, and placed the functions directly in asm-generic/io.h. I have
> dropped the libs/iomem_copy.c and have updated/clarified the commit
> message in the first patch.
Apart from build 'issues' what is the justification for inlining
these functions?
They are quite large for inlining and some drivers could easily
call them many times.
The I/O cycles themselves are likely to be slow enough that
the cost of a function call is pretty much likely to be noise.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2024-10-21 14:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 13:31 Julian Vetter
2024-10-21 13:31 ` [PATCH v10 1/4] " Julian Vetter
2024-10-21 13:31 ` [PATCH v10 2/4] arm64: Use new fallback IO memcpy/memset Julian Vetter
2024-10-21 13:31 ` [PATCH v10 3/4] csky: " Julian Vetter
2024-10-21 13:31 ` [PATCH v10 4/4] loongarch: " Julian Vetter
2024-10-21 14:16 ` David Laight [this message]
2024-10-25 14:20 ` [PATCH v10 0/4] Replace fallback for IO memcpy and IO memset Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0577266edb9440acb082c9e02c0a73b9@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=geert@linux-m68k.org \
--cc=guoren@kernel.org \
--cc=hch@infradead.org \
--cc=johannes@sipsolutions.net \
--cc=jvetter@kalrayinc.com \
--cc=kernel@xen0n.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=miquel.raynal@bootlin.com \
--cc=richard.henderson@linaro.org \
--cc=schnelle@linux.ibm.com \
--cc=tiwai@suse.com \
--cc=will@kernel.org \
--cc=ysionneau@kalrayinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®