From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5AC43AEF4C for ; Thu, 28 May 2026 10:13:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779963195; cv=none; b=Aq89qQSYlapCNv1P5N6kxu1QhB7ET1ZKen2395Anxo6KpuaAX/Ifjc4SSDIXOSrY5B4EIQZPeYppGEJKnrGCVLkcZItrLCPi5BI6Y4vLn6TRczatbCnlh59ze8lepq+g4ga07jdTZ7ersMQYNPUC6JscpzRH9GrtGRwoUfTwYr0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779963195; c=relaxed/simple; bh=JFl9SLagFHstVkYll1Bjr2kunrMsRs9NnKMig1aEYqs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uwguTtAtE+B1PPUf3wbfx3+gjiOBuyJlo2Fl09w5pDDMKjyDlLhr3e1tDNHdQ4LeF3E44C0NiSN1D9Ry7TsrL/I5eHI3YyZGqyaT0y6zLMqz7lo+rQlDkmyH7CUj81GieegL01txS0xmKgDILHHUwMQd5BnvkdtGQZjVm2LFuGc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WUETkDiH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NTfnEpL7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WUETkDiH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NTfnEpL7" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64S8wMSZ382529 for ; Thu, 28 May 2026 10:13:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Tw9BCq69+vPICTaEPFF13m6QUIzPyxrc7hFFrxx7Wfk=; b=WUETkDiHdPqIxrha Bj+BG/eb1EQsF8AVbKSyChhywX+y9FhIinp8B1Pcq3eS9+wb1NzQIA3v3DQE34pX IG/Q4RFInaqDfwleMWDFrU7qQ9ZqGTZnwK9qEHs+EdMmwsCM/VNdNpYpjn8fn9Fi AGpJs0INzoYxSdYPtCL9wHp62mAiiEtqvUT+pIWFSXIeTp0nQF7rU7/SN4OxMm1y NeGyvKWaNsjcFtiuqdfDI40PrMuIHWy+m6WOxFNsUaggK1s5Cov4JqdRW5Qkrnsz j6sr1abSMYCACx3U/SeUOmWe94EO7/DwkPllUdm5NbSDAggELQ2OqLvWXzFL8hL3 oGdqOw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ee7yrjb7u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 28 May 2026 10:13:13 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-516d13328dcso131074421cf.1 for ; Thu, 28 May 2026 03:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779963192; x=1780567992; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Tw9BCq69+vPICTaEPFF13m6QUIzPyxrc7hFFrxx7Wfk=; b=NTfnEpL74zfKuFHKSwaNqfgd9YrnbX30lXVzGPyqrsqrP4LSZ+tFiTkligrr/IpjB6 ug8PVa+Ubkq83sHqMIAZQ4i1POBMSrxyLQ1iwmdOrKN3Y+Ymimh30PxUHUZ1Zw6NDYxX Q25rO6H9GxaqYDF2QK4qtaQFZPTJRrEy3TVdqk+E7oN0N9R2gCI75V8savOF+SaGGb26 uAJcRyQPMhTM6EtbZhxxryRKGmdz6/W8RLSbGO4HjdzSOOaUicbdK9qamfWYNPrzFbd/ 8zrEEjVxvFAYB2qX19PGdldY+4cuKwArHS+icWl6wJhHyyyDhzdxYa+7/oxSig6VkfnT /bmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779963192; x=1780567992; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Tw9BCq69+vPICTaEPFF13m6QUIzPyxrc7hFFrxx7Wfk=; b=ANfi4xvby3z1LwDkv8wTXGCc6P673sPAwfoj6MCc2sLqxyLqXpWXhI9ZjOlshKoUIk iYnshy+SFUnYiv8o+X+YUvmENOAxTESRJuKVOIL5SW/XirXU+E7Rf2+ThRyANW7wrnpD Pc4CkOFERQtrhiGKpaTO/pmqWgIDP2fwpDz0gywQbsTtqUcw4cTtkN6h9iFoUan7yc9C MDJBCdTUW85fABQWluxlTRSncSTGy2+MiDqlFFr3vav+MXvhV3AMK6oQtI0PQMHhyV5H XfHarYHy19NssC+o39Lglq53UgnU+wjyC6MBV8uEvSZ5/2edbtb/3qI5njVC/gMx5/ox 0olA== X-Forwarded-Encrypted: i=1; AFNElJ8DcMZN0xeSNKQ3A/AXrWVIFQsiQ4oYB7/89Y364ibe7IAyQU84mBRln93jCDLAicVcojAK2VUtEz6CZik=@vger.kernel.org X-Gm-Message-State: AOJu0YwJ56bvDX6FWA1YtX5qKW1G+fGYSgwGCv3ej75vjD04UaMrfwIe 9BbD7ocZVrCVfUkVY1oVFPj48m7SW4UbsM+604CZM2GVFOmvHPSLQ00S/wSki1AsuGclvZw48ri bqTK5T5U8V3Eo7kjRnm1eBhd2sb7u6GJIC4NS3B0yf8xsnfw2z8NqfhKDRmYLGaYHl+7D5w90LZ I= X-Gm-Gg: Acq92OEtoB0ZwET//oj2IIPruU9PSGU7AUMmS1sKgVEdJ4PsAelp4Ao9XjFxNylkpoa pnMP5zKnz2fAOF0LymVTjr9HAsqNc8sfpWS0L68diZn7MtZGuUDVaXxOqXRFfNxNDUVOyzRh/oN UMfJ5Z4RUa8s/P1baLGyrD7k6b0wCI8NXfXpMavPFP742fGeslPFAIHg3Z32t3GKscN5Fp3g+0q pJEcnIxBSV45wFd4+lOGFbqrKFxFVfVaFV60oSEamkouFUnJ8Wh1WJNPvG8e/mXjE5NusGmVc+e 6kdE2+vV3lE1eeV+P78aBbQsBJaDCRSZxY9LPKrmt8D37exKVuf5m8VujmygHTakp6nL/zTIMXr 8XTCECG7MVEIsYBebfUpYjd28yOVUYcvyQPfC2UWS63vluOxbd37IocPDzrSnfYlXTPaHqhrVfx mL2VWbi5C2aBlHnw5ze7cTRQ== X-Received: by 2002:a05:622a:d0e:b0:516:e96b:2356 with SMTP id d75a77b69052e-516e96b277fmr252286991cf.24.1779963192101; Thu, 28 May 2026 03:13:12 -0700 (PDT) X-Received: by 2002:a05:622a:d0e:b0:516:e96b:2356 with SMTP id d75a77b69052e-516e96b277fmr252286591cf.24.1779963191696; Thu, 28 May 2026 03:13:11 -0700 (PDT) Received: from [10.111.173.202] (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8cc80ded529sm195589336d6.16.2026.05.28.03.13.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 May 2026 03:13:11 -0700 (PDT) Message-ID: <057742e8-9de9-4aa0-ac5d-8ddf44cf467d@oss.qualcomm.com> Date: Thu, 28 May 2026 18:13:04 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 25/39] drm/msm/dp: pass panel to display enable/disable helpers To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> <20260410-msm-dp-mst-v4-25-b20518dea8de@oss.qualcomm.com> <7dxlzm5hm2uq7ai56lmvzyjntn4kprdg5bp6qr77cqetku4hgu@iom7kqnfn4eo> Content-Language: en-US From: Yongxing Mou In-Reply-To: <7dxlzm5hm2uq7ai56lmvzyjntn4kprdg5bp6qr77cqetku4hgu@iom7kqnfn4eo> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI4MDEwMyBTYWx0ZWRfX4L4Ib9l31oCU JVCZaGBCgwd6nxXq3xKTCvfvBtlXy7kp3Ush/Q3jI0JAOABOdvy+Z2Qw8MfgHhrm1SeEz0h8yTm UNAM5njspEOuCRoBWX/SPfI+C0xYuLrer3DynYWa9XCEKrgUfLZMrjnE5TclVH47UoskVoc4328 WPlp5x9pBTmHB2Os+hYE5AKK2OHR6t5ZSuersC1MiuFicJdLohBa4lf5GpYAv6hl+ZAYB2rWUXJ 15XpuMW1yIPzIXxgh/6H97oemgK9Qmq2Epi/EU6j9qRQkOJEP58FRH/HjgW5KZEROZZJKImViRe VCUuQ2u54ULRNRhznSv99xfcZI6XBZtuv0moMVE6xXMQo6q/Hxe8/gFoPw5fddSQO7Wo4MQuZ7N C02js+qLYElksEp1RIFgYXmbc8b+x4ubyGxnv6hJk6paTs8Uco/u7adGf0E/7iAkphHAhrlljlN rVIHLBpiKw0vYWILHQw== X-Authority-Analysis: v=2.4 cv=PLo/P/qC c=1 sm=1 tr=0 ts=6a181539 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=keVsun0R0cJNlHGda80A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: sADfqyqb9HUxf2LUCo6S3dDh4l71TDs4 X-Proofpoint-ORIG-GUID: sADfqyqb9HUxf2LUCo6S3dDh4l71TDs4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-28_03,2026-05-26_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 malwarescore=0 spamscore=0 bulkscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605280103 On 4/12/2026 8:05 AM, Dmitry Baryshkov wrote: > On Fri, Apr 10, 2026 at 05:34:00PM +0800, Yongxing Mou wrote: >> Pass struct msm_dp_panel to the display enable/disable helpers to make >> them easier to reuse for MST stream handling. >> >> Signed-off-by: Yongxing Mou >> --- >> drivers/gpu/drm/msm/dp/dp_display.c | 18 ++++++++++-------- >> 1 file changed, 10 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c >> index 7b3b9160e005..88a078e53dc1 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_display.c >> +++ b/drivers/gpu/drm/msm/dp/dp_display.c >> @@ -668,7 +668,8 @@ static int msm_dp_display_prepare(struct msm_dp_display_private *dp) >> return msm_dp_ctrl_prepare_stream_on(dp->ctrl, force_link_train); >> } >> >> -static int msm_dp_display_enable(struct msm_dp_display_private *dp) >> +static int msm_dp_display_enable(struct msm_dp_display_private *dp, >> + struct msm_dp_panel *msm_dp_panel) > > Where is it being used? > Got it..That was my mistake — I’ll pass it inside the function. >> { >> int rc = 0; >> struct msm_dp *msm_dp_display = &dp->msm_dp_display; >> @@ -725,20 +726,21 @@ static void msm_dp_display_audio_notify_disable(struct msm_dp_display_private *d >> msm_dp_display->audio_enabled = false; >> } >> >> -static int msm_dp_display_disable(struct msm_dp_display_private *dp) >> +static int msm_dp_display_disable(struct msm_dp_display_private *dp, >> + struct msm_dp_panel *msm_dp_panel) >> { >> struct msm_dp *msm_dp_display = &dp->msm_dp_display; >> >> if (!msm_dp_display->power_on) >> return 0; >> >> - msm_dp_panel_disable_vsc_sdp(dp->panel); >> + msm_dp_panel_disable_vsc_sdp(msm_dp_panel); >> >> - msm_dp_ctrl_off_pixel_clk(dp->ctrl, dp->panel->stream_id); >> + msm_dp_ctrl_off_pixel_clk(dp->ctrl, msm_dp_panel->stream_id); >> >> /* dongle is still connected but sinks are disconnected */ >> if (dp->link->sink_count == 0) >> - msm_dp_link_psm_config(dp->link, &dp->panel->link_info, true); >> + msm_dp_link_psm_config(dp->link, &msm_dp_panel->link_info, true); >> >> msm_dp_ctrl_off_link(dp->ctrl); >> >> @@ -1529,14 +1531,14 @@ void msm_dp_display_atomic_enable(struct msm_dp *msm_dp_display) >> >> msm_dp_display_set_stream_info(msm_dp_display, dp->panel, 0, 0, 0, 0); >> >> - rc = msm_dp_display_enable(dp); >> + rc = msm_dp_display_enable(dp, dp->panel); >> if (rc) >> DRM_ERROR("DP display enable failed, rc=%d\n", rc); >> >> rc = msm_dp_display_post_enable(msm_dp_display); >> if (rc) { >> DRM_ERROR("DP display post enable failed, rc=%d\n", rc); >> - msm_dp_display_disable(dp); >> + msm_dp_display_disable(dp, dp->panel); >> } >> >> drm_dbg_dp(msm_dp_display->drm_dev, "type=%d Done\n", msm_dp_display->connector_type); >> @@ -1573,7 +1575,7 @@ void msm_dp_display_atomic_post_disable(struct msm_dp *dp) >> >> msm_dp_display_audio_notify_disable(msm_dp_display); >> >> - msm_dp_display_disable(msm_dp_display); >> + msm_dp_display_disable(msm_dp_display, msm_dp_display->panel); >> >> msm_dp_display_unprepare(msm_dp_display); >> } >> >> -- >> 2.43.0 >> >