From: Sven Peter <sven@svenpeter.dev>
To: Nick Chan <towinchenmi@gmail.com>
Cc: Hector Martin <marcan@marcan.st>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
konrad.dybcio@somainline.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 2/4] irqchip/apple-aic: Skip unnecessary setting of use_fast_ipi
Date: Sat, 31 Aug 2024 08:48:23 +0200 [thread overview]
Message-ID: <05775A47-1FA8-47BF-9449-351CB35B9A42@svenpeter.dev> (raw)
In-Reply-To: <20240831055605.3542-3-towinchenmi@gmail.com>
> On 31. Aug 2024, at 07:57, Nick Chan <towinchenmi@gmail.com> wrote:
>
> use_fast_ipi is true by default and there is no need to "enable" it.
>
> Signed-off-by: Nick Chan <towinchenmi@gmail.com>
> ---
Acked-by: Sven Peter <sven@svenpeter.dev>
> drivers/irqchip/irq-apple-aic.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
> index 5c534d9fd2b0..8d81d5fb3c50 100644
> --- a/drivers/irqchip/irq-apple-aic.c
> +++ b/drivers/irqchip/irq-apple-aic.c
> @@ -987,9 +987,7 @@ static int __init aic_of_ic_init(struct device_node *node, struct device_node *p
> off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_CLR */
> off += sizeof(u32) * (irqc->max_irq >> 5); /* HW_STATE */
>
> - if (irqc->info.fast_ipi)
> - static_branch_enable(&use_fast_ipi);
> - else
> + if (!irqc->info.fast_ipi)
> static_branch_disable(&use_fast_ipi);
>
> irqc->info.die_stride = off - start_off;
> --
> 2.46.0
>
next prev parent reply other threads:[~2024-08-31 6:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-31 5:48 [PATCH v2 0/4] Add support for A7-A11 AIC Nick Chan
2024-08-31 5:48 ` [PATCH v2 1/4] dt-bindings: apple,aic: Document A7-A11 compatibles Nick Chan
2024-08-31 6:34 ` Krzysztof Kozlowski
2024-08-31 6:43 ` Sven Peter
2024-08-31 5:48 ` [PATCH v2 2/4] irqchip/apple-aic: Skip unnecessary setting of use_fast_ipi Nick Chan
2024-08-31 6:48 ` Sven Peter [this message]
2024-08-31 5:48 ` [PATCH v2 3/4] irqchip/apple-aic: Add a new "Global fast IPIs only" feature level Nick Chan
2024-08-31 7:05 ` Sven Peter
2024-08-31 5:48 ` [PATCH v2 4/4] irqchip/apple-aic: Only access system registers on SoCs which provide them Nick Chan
2024-08-31 10:01 ` Sven Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05775A47-1FA8-47BF-9449-351CB35B9A42@svenpeter.dev \
--to=sven@svenpeter.dev \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
--cc=towinchenmi@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®