From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932790AbcFBN1o (ORCPT ); Thu, 2 Jun 2016 09:27:44 -0400 Received: from lists.s-osg.org ([54.187.51.154]:39349 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932346AbcFBN1m (ORCPT ); Thu, 2 Jun 2016 09:27:42 -0400 Subject: Re: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem to Exynos5410 To: Krzysztof Kozlowski , Kukjin Kim , Sylwester Nawrocki , Tomasz Figa , Michael Turquette , Stephen Boyd , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <1464774351-23604-1-git-send-email-k.kozlowski@samsung.com> <1464774351-23604-3-git-send-email-k.kozlowski@samsung.com> <574FCFB2.1080607@samsung.com> Cc: Bartlomiej Zolnierkiewicz From: Javier Martinez Canillas Message-ID: <057fb9e8-002a-0aac-a36d-ef074ab2111e@osg.samsung.com> Date: Thu, 2 Jun 2016 09:27:28 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <574FCFB2.1080607@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 06/02/2016 02:18 AM, Krzysztof Kozlowski wrote: > On 06/01/2016 05:16 PM, Javier Martinez Canillas wrote: [snip] >>> >>> +&watchdog { >>> + clocks = <&clock CLK_WDT>; >>> + clock-names = "watchdog"; >>> + samsung,syscon-phandle = <&pmu_system_controller>; >>> +}; >>> + >> >> Since you used the same ID than Exynos5420 for the SSS and WDT clocks, >> I wonder if the clock and clock-names shouldn't be just defined in the >> shared exynos54xx.dtsi as is the case for the interrupts that are also >> the same? >> >> The patch looks good to me though, so whatever you decide: >> >> Reviewed-by: Javier Martinez Canillas > > Thanks for review and comments. > > The 'clock' property cannot be moved - there is no clock phandle and the > clock IDs are not included in 54xx. > You are right, I missed that. Thanks a lot for the clarification. > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America