From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3F0B333439 for ; Tue, 10 Feb 2026 22:09:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770761372; cv=none; b=heBj5qvRraicslGrikaQnfVnsznZL21rtNAdnV4w8EUvMs09xndKoWtxoUqYO9Etrq4Wh2xDrRCH3QWFLG6+csK/XCMPM/y662hXErT9mTXfvblM71/89SU06pg6n0KGgwb7dWob6gnu3NQzk7Awk+1HuauQ3uYNu1loCkelq0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770761372; c=relaxed/simple; bh=tLQSLJrMEtZUg27Vws1N7+NzNoLYTyrWQYqabNq0AoU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=c9vHuK6h6lWWv0T3V+pfhlJLUBAVnpa6zFnroL09x6Nlv1x0v+uQ956rF60GzBPb/a/5BK5A3X7bvEcpqhW77HNYrkCoE9gLSLDBizoK/E2a6ohn2XSowUxAht2TGUR3I3OTnWzqsozcZI/v8Kko5izaXmre3OpO24smj9efYQQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RxGB+Dqt; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RxGB+Dqt" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-1271257ae53so1642915c88.1 for ; Tue, 10 Feb 2026 14:09:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770761371; x=1771366171; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZyWovkRTm+VBO7EWXfO8gUOOoB2/pAnZYbbbLZ/pIDI=; b=RxGB+Dqt5QWyBkuXBD8tIfplDViSCtzzlydw/MBdFFtlcIpWdX94NacOu8CWB9AJCo 3I+3LHl59x7XowWjfQnu8BVgk6rHKqA/SQ4UhC2FA/jIcV0xAgTUy70rl6QHEjJuQTCU hdm+Z3C35BeNCgyuCSvr8dL0AtNkM0SAte5mTCmCq9caj7zcvVW2NgvOnNB39j5VxQuV XUY/vv+mskQjPUCB05wX9eCtDFuM51Rpwqq/bvTrVO6/3zeonmx9Z6GSNQrWsmYxO8Iz EapnG0P7xyDH/3F35iUOmNiC6QKEKaoUo5CLK62mqyqcE+M2MuDxqUB2RxaXI01qxUBE Enlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770761371; x=1771366171; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZyWovkRTm+VBO7EWXfO8gUOOoB2/pAnZYbbbLZ/pIDI=; b=lqNvOzyvWSDvgsezCxlQw0SDfttrXCdQ1m9p8hWusgOI2jrsivF7CvY7US5U/ZfZK9 e5luGpXjbsjrKjm+UB8KaC4H8/RwB1IhpvNBpM0wGF9waPJSVpLy5Wz037OEqStvsplO gW5L2nyJsXkmVYSxN5rvu8GCEMV3nXc5436kOKjI9+VjSKyEx7uNmReUFefO+0gEe9cg 6vZvKmox6zoqNkjEEEWoFjr+aSAyvY9VlEY/mjkuQCKBzaywGauhu7LvaTHNwSfOxvAT eNEEnUHJ3ipzguJGEM2tys9bKQjGObbCW23rvS/KyqueJs+KVW6b5EYT454SSeaLqBrC TYtQ== X-Forwarded-Encrypted: i=1; AJvYcCVMoMZdzTS3msNv2PG0jTrLjniTlnuWnW6W7zC9JR6UOCpZxGRx3mPqaG+5xaEsT1GWzLNVHb+ADqCajKw=@vger.kernel.org X-Gm-Message-State: AOJu0YyPGKGC5r6KnvlIgTX/jg++LoQfGJTsQrFpDKk6fz+yDfvbB5y3 SnVRjaXY0dPosr73PM/l/pAtLPTfU0n3i5lVyCiYiFlxJz0BmWgcKGRW X-Gm-Gg: AZuq6aIuy0yvmBe23jdqAz0ZN1U+N2YVqyWvee3qGvYz1mjWsIoEqaE8UvvKZcxcp4N MN8YWKfHLg0kfdcnCWspkEAOT1zYr6QN2BAGXo+POHIoTgSXO8Uv7n+A6inR05epyQK+reTeCmn 8SZh4FFOsEJmh/t+jrZ9rIRtDcmLtfUSffimVTtxptJFvLLLsz4sPLwRdNU9xdNSZqtHfoA6/s5 Cr1KRj/M8W4WGG3Iz3Eh0Y9MBd+Z5Cq/Jhh64P1o7FCGps3iU68QoubSd6bXyMUUjPXOXnHXN9l KAk6XSd3z+UjfewrjEGqIpXxhviiGasvJbIiZSvRSWMFNUH6TobmEkc790kEnQxsJh1BzO0DaBW T+9L0Ku94EllMXAn3Xg3v04y8JttNSb+OJlK0LQcpQQ+okAE1fQw0bF/5e8IWvs54eWm2WG+E3o J+tKQlMxM0ToWWMpBo95wX6Hog++umI81W16vRo64FzNb1Mj74xjvCqw== X-Received: by 2002:a05:693c:60c3:b0:2b8:6b32:1d16 with SMTP id 5a478bee46e88-2b86b3225eemr3692263eec.30.1770761370711; Tue, 10 Feb 2026 14:09:30 -0800 (PST) Received: from [10.69.50.72] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b855b1a6d3sm10586261eec.15.2026.02.10.14.09.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 14:09:30 -0800 (PST) Message-ID: <05875e07-b908-425a-ba6f-5e060e03241e@gmail.com> Date: Tue, 10 Feb 2026 14:09:27 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 08/14] nvme: Implement cross-controller reset recovery To: Mohamed Khalfella , Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg Cc: Aaron Dailey , Randy Jennings , Dhaval Giani , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, jsmart833426@gmail.com References: <20260130223531.2478849-1-mkhalfella@purestorage.com> <20260130223531.2478849-9-mkhalfella@purestorage.com> Content-Language: en-US From: James Smart In-Reply-To: <20260130223531.2478849-9-mkhalfella@purestorage.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/30/2026 2:34 PM, Mohamed Khalfella wrote: ... > +unsigned long nvme_fence_ctrl(struct nvme_ctrl *ictrl) > +{ > + unsigned long deadline, now, timeout; > + struct nvme_ctrl *sctrl; > + u32 min_cntlid = 0; > + int ret; > + > + timeout = nvme_fence_timeout_ms(ictrl); > + dev_info(ictrl->device, "attempting CCR, timeout %lums\n", timeout); > + > + now = jiffies; > + deadline = now + msecs_to_jiffies(timeout); > + while (time_before(now, deadline)) { Q: don't we have something to identify the controller's subsystem supports CCR before we starting selecting controllers and sending CCR ? I would think on older devices that don't support it we should be skipping this loop. The loop could delay the Time-Based delay without any CCR. -- james