From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E78A1C3F1C for ; Thu, 17 Oct 2024 08:21:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729153295; cv=none; b=c/bSw9np/8jNG4xMsLxV6rDa/ZsU+tzxVhevStVkZy+6iTOvMBUTg0OblFtGZgafmtleJ6/ZLUX/DSoUE7CiIYlVltTBT0taO87oEdeJ4cE10vT3u1QeAp/Qmy5vott+OYO7dWVVZGve1aue8cqEslPr25UgNqjeKJtoqNguEnQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729153295; c=relaxed/simple; bh=mJdwseK+Ihydb0yrZWZ2xx7GAV8K0alZlK6rApkXMP4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QNdPxgyRbC49REC0o9GFkyVl88mQLIUthO8qAQuoa389gTUtpmGlY0PBYhdlMAWg9O3LOt3YYs3U6sbrshFZdxvX4z74NZziLX1Ab6GdTAwZRmPPe1vwygjVRC+6BGHzZ13VlnjU53Ws4qVc+hebe1RvIUzlf7E2fJBD2N1F2cY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=f6IL5xBw; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="f6IL5xBw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729153292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sv2elTq+1u5WAiRQ57i5MykcY8IctnIMTtGLiuNcRr8=; b=f6IL5xBwGinTQAvqEBLDPlrzBQBvQEAu65AWUnsLBxYjDu+VHb50angknKa7kgNc5k1L3d lPfnI2FzNTYvA6xZTNzuiQSG1bmqYNINGkakyhCEnKwzQTt/K+KbXvpsL53xD9muIMpZ7T 53h9cZQX+sHv2DHFLu4C33cBdW8H9UM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-404-3nKM2DMkPuOga3-_-YvHmQ-1; Thu, 17 Oct 2024 04:21:31 -0400 X-MC-Unique: 3nKM2DMkPuOga3-_-YvHmQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-37d4a211177so354768f8f.0 for ; Thu, 17 Oct 2024 01:21:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729153290; x=1729758090; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Sv2elTq+1u5WAiRQ57i5MykcY8IctnIMTtGLiuNcRr8=; b=fDHDyodPalyev8NgAGeITxnwkJ/g/Wobc21gKLEPBZWSEssLd3rZcFRoEgecER/4s5 4YImu4f7ehwsEZ+tT9Zop887ROvqsrpbmYsBUq1OiACluoZ0T//7cNzVPTBoDDDCRlNt LtcsGJoCxCUotzMZmFZrUHNYfIhIOqS52cLrXPvs/XX+pDJVaoQkPR/VYwtqSFmILJhc f3IwqBG69kaayFEKqJNEia4AE2aJ0QqZ1JMsz/djO0QfAy1k7VT6wgJoCw7VcAPDDfnZ yp3gHKS+k2M7ZJwaR4ymAXE1jWCYVwzwhU7S50EvOInlTJ0pror39u/VQ4Ie+2G/u9uN Tu3g== X-Forwarded-Encrypted: i=1; AJvYcCXKxl45wNcWUv8Vi1tS6Wuo+u/d5GwaV/1VEOWl6nm+rxqxgmuPsdJnnMZLyrxpu3o6/Y9P6Ak67Y7Zt1c=@vger.kernel.org X-Gm-Message-State: AOJu0YyYGBwhRJqCRyO1cc9z51eY8584BAlHQbczxmSEJHhgAASHs4ln XqpOQmfgKDRxysmLy/oQ1qqfg3pAKjaQZ/DekQLkBnHP74dCMQ34471u1Qj/BJ4FNoSwvwKIGhU R1CBSX635bnmLdKBhUCIiJ83XKeSJL0QW61RBtv5f6O8NvmHRjBhNe+P1p9rGXQ== X-Received: by 2002:a5d:6182:0:b0:37d:4b07:606b with SMTP id ffacd0b85a97d-37d86d554fbmr4668949f8f.36.1729153289913; Thu, 17 Oct 2024 01:21:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHWbT67cXRNKHvT8bjUpe/1XYziYnHsjZYBLmjChrKd2b7so3VlC4Le6iaP/zZPAGC4Jfvqng== X-Received: by 2002:a5d:6182:0:b0:37d:4b07:606b with SMTP id ffacd0b85a97d-37d86d554fbmr4668926f8f.36.1729153289439; Thu, 17 Oct 2024 01:21:29 -0700 (PDT) Received: from [192.168.88.248] (146-241-22-245.dyn.eolo.it. [146.241.22.245]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d7fbf8313sm6450750f8f.66.2024.10.17.01.21.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Oct 2024 01:21:28 -0700 (PDT) Message-ID: <058bb30d-7d7c-4e4f-8b88-32e3ca99e548@redhat.com> Date: Thu, 17 Oct 2024 10:21:27 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 1/2] ethtool: rss: prevent rss ctx deletion when in use To: Daniel Zahka , Edward Cree , "David S. Miller" , Eric Dumazet , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241011183549.1581021-1-daniel.zahka@gmail.com> <20241011183549.1581021-2-daniel.zahka@gmail.com> <966a82d9-c835-e87e-2c54-90a9a2552a21@gmail.com> <43a98a99-4c79-4954-82f1-b634e4d1be82@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/16/24 18:50, Daniel Zahka wrote: > > On 10/16/24 12:23 PM, Edward Cree wrote: >> On 15/10/2024 17:31, Daniel Zahka wrote: >>> On 10/14/24 6:10 AM, Edward Cree wrote: >>>> Imho it would make more sense to add core tracking of ntuple >>>>   filters, along with a refcount on the rss context.  That way >>>>   context deletion just has to check the count is zero. >>>> >>>> -ed >>> That sounds good to me. Is that something you are planning on sending patches for? >> I'm afraid I don't have the bandwidth to do it any time soon. >> If you aren't able to take this on, I'm okay with your original >> approach to get the issue fixed; I just wanted to ensure the >> 'better' solution was considered if you do have the time for it. > Understood. I don't have enough bandwidth to commit to implementing it > soon either. I understand the chances to have a refcount based implementation soon are zero, and I could not find any obvious problem with the proposed solution, I'm going to apply this series as-is. Cheers, Paolo