From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Wei Yongjun <weiyongjun1@huawei.com>,
Benson Leung <bleung@chromium.org>,
Duncan Laurie <dlaurie@google.com>,
Nick Crews <ncrews@chromium.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] platform/chrome: Make function wilco_ec_transfer() static
Date: Mon, 18 Feb 2019 11:14:07 +0100 [thread overview]
Message-ID: <05971cf1-433a-3edf-7dc2-8561c41e539a@collabora.com> (raw)
In-Reply-To: <20190216060910.139768-1-weiyongjun1@huawei.com>
On 16/2/19 7:09, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/platform/chrome/wilco_ec/mailbox.c:126:5: warning:
> symbol 'wilco_ec_transfer' was not declared. Should it be static?
>
> Fixes: 436dad4fda10 ("platform/chrome: Add new driver for Wilco EC")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/platform/chrome/wilco_ec/mailbox.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
Applied for 5.1
Thanks
> diff --git a/drivers/platform/chrome/wilco_ec/mailbox.c b/drivers/platform/chrome/wilco_ec/mailbox.c
> index c7028488e575..f6ff29a11f1a 100644
> --- a/drivers/platform/chrome/wilco_ec/mailbox.c
> +++ b/drivers/platform/chrome/wilco_ec/mailbox.c
> @@ -123,8 +123,9 @@ static void wilco_ec_prepare(struct wilco_ec_message *msg,
> * Context: ec->mailbox_lock should be held while using this function.
> * Return: number of bytes received or negative error code on failure.
> */
> -int wilco_ec_transfer(struct wilco_ec_device *ec, struct wilco_ec_message *msg,
> - struct wilco_ec_request *rq)
> +static int wilco_ec_transfer(struct wilco_ec_device *ec,
> + struct wilco_ec_message *msg,
> + struct wilco_ec_request *rq)
> {
> struct wilco_ec_response *rs;
> u8 checksum;
>
>
>
prev parent reply other threads:[~2019-02-18 10:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 6:09 Wei Yongjun
2019-02-18 10:14 ` Enric Balletbo i Serra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05971cf1-433a-3edf-7dc2-8561c41e539a@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=bleung@chromium.org \
--cc=dlaurie@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ncrews@chromium.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®