From: Lars-Peter Clausen <lars@metafoo.de>
To: Peter Rosin <peda@axentia.se>,
Mircea Caprioru <mircea.caprioru@analog.com>
Cc: davem@davemloft.net, mchehab+samsung@kernel.org,
akpm@linux-foundation.org, rdunlap@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mux:adgs1408/1409: New driver for Analog Devices ADGS1408/1409 mux …
Date: Sat, 14 Jul 2018 16:02:51 +0200 [thread overview]
Message-ID: <059d9750-8715-bc4e-185f-d52b48ad9b59@metafoo.de> (raw)
In-Reply-To: <b3540119-73e1-38d5-1dc9-ce9f8bdad9e8@axentia.se>
On 07/14/2018 02:04 PM, Peter Rosin wrote:
[...]
>> +static int adgs140x_spi_reg_write(struct spi_device *spi,
>> + u8 reg_addr, u8 reg_data)
>> +{
>> + u8 tx_buf[2];
>> +
>> + tx_buf[0] = reg_addr;
>> + tx_buf[1] = reg_data;
>> +
>> + return spi_write_then_read(spi, tx_buf, sizeof(tx_buf), NULL, 0);
>
> return spi_write(spi, tx_buf, sizeof(tx_buf));
Be aware spi_write_then_read() can handle on stack buffers, spi_write() can't.
next prev parent reply other threads:[~2018-07-14 14:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 12:27 Mircea Caprioru
2018-07-13 16:27 ` Randy Dunlap
2018-07-14 12:04 ` Peter Rosin
2018-07-14 14:02 ` Lars-Peter Clausen [this message]
2018-07-14 19:51 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=059d9750-8715-bc4e-185f-d52b48ad9b59@metafoo.de \
--to=lars@metafoo.de \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mircea.caprioru@analog.com \
--cc=peda@axentia.se \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®