From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m49242.qiye.163.com (mail-m49242.qiye.163.com [45.254.49.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57F2215C158; Tue, 17 Mar 2026 01:37:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.254.49.242 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773711444; cv=none; b=HHM9azAVolRFMVaPbFp6EcknACu4h9razktyPhPxFZMWbpGyhJCHhJYP1XReWr38xijnP5MCgeClN/7fKVBOl3X+99cTi01hGc93v9JCg/S8XWZOXKI63WuOJcXN9YvNgP8C3D++HRy7rooaRq1Ii4sIk2OMBdi1YjdHcxKT5/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773711444; c=relaxed/simple; bh=Yj/IL/AN4ZOti1DnHpYxFCvLegKnfxksNderjPk9Pg4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z8gUESjMgOf7+KPsQohdtulg45yPCEhdH9lKTBhXoiGenIHtiECUIKfPuccaPLw4YpWL12bRKxY2sfWwOgunC2xJMwpNiRA+5IL532ixWyJgYn4d0Durz/gkVTKLG6IZVRYpCNW17qx1V9r3NIXD0gf4COUI5oVS7pP7SgG0cHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=MQeOlmq0; arc=none smtp.client-ip=45.254.49.242 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="MQeOlmq0" Received: from [172.16.12.43] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 372f3216c; Tue, 17 Mar 2026 09:37:10 +0800 (GMT+08:00) Message-ID: <05a8012d-c1f7-417b-96f8-ec1a41993b26@rock-chips.com> Date: Tue, 17 Mar 2026 09:37:10 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/4] arm64: dts: rockchip: Add eDP node for RK3576 To: Nicolas Frattaroli , hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, alchark@gmail.com, cristian.ciocaltea@collabora.com, sebastian.reichel@collabora.com, kever.yang@rock-chips.com, dmitry.baryshkov@oss.qualcomm.com, luca.ceresoli@bootlin.com, dianders@chromium.org, m.szyprowski@samsung.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260310105307.309765-1-damon.ding@rock-chips.com> <20260310105307.309765-3-damon.ding@rock-chips.com> <9590182.CDJkKcVGEf@workhorse> Content-Language: en-US From: Damon Ding In-Reply-To: <9590182.CDJkKcVGEf@workhorse> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Tid: 0a9cf970940603a3kunm76417074222a43 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGh4YSVZOGUpITUwaShhPQxpWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpKQk 1VSktLVUpCWQY+ DKIM-Signature: a=rsa-sha256; b=MQeOlmq07ycIc1QL4tGgjDuL85uSHPI3xkw6nYsJa7yU+1prZ8PKktKJMqK5SwPdJufqOaA4RldAN9jPxB19GDSRAGpXfK0/ea/DXI3LlkAZIgPQorilo6arCjAGHm5nL0FwSnygNzNpV9fBwJmiWVLAnNUnmmEJVMailCWpYOU=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=3Q89cxIkHSk/a2RjqYAjgiexXPdpx/jNB/mz4sMPZKU=; h=date:mime-version:subject:message-id:from; Hi Nicolas, On 3/16/2026 7:31 PM, Nicolas Frattaroli wrote: > On Tuesday, 10 March 2026 11:53:05 Central European Standard Time Damon Ding wrote: >> Add support for the eDP output on RK3576 SoC. >> >> Signed-off-by: Damon Ding >> --- >> arch/arm64/boot/dts/rockchip/rk3576.dtsi | 28 ++++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi >> index a86fc6b4e8c4..14900a66d3e1 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi >> @@ -1446,6 +1446,34 @@ hdmi_out: port@1 { >> }; >> }; >> >> + edp: edp@27dc0000 { >> + compatible = "rockchip,rk3576-edp"; >> + reg = <0x0 0x27dc0000 0x0 0x1000>; >> + clocks = <&cru CLK_EDP0_24M>, <&cru PCLK_EDP0>, <&cru HCLK_VO0_ROOT>; >> + clock-names = "dp", "pclk", "hclk"; >> + interrupts = ; >> + phys = <&hdptxphy>; >> + phy-names = "dp"; >> + power-domains = <&power RK3576_PD_VO0>; >> + resets = <&cru SRST_EDP0_24M>, <&cru SRST_P_EDP0>; >> + reset-names = "dp", "apb"; >> + rockchip,grf = <&vo0_grf>; >> + status = "disabled"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + edp_in: port@0 { >> + reg = <0>; >> + }; >> + >> + edp_out: port@1 { >> + reg = <1>; >> + }; >> + }; >> + }; >> + >> sai7: sai@27ed0000 { >> compatible = "rockchip,rk3576-sai"; >> reg = <0x0 0x27ed0000 0x0 0x1000>; >> > > Reviewed-by: Nicolas Frattaroli > > By cross-referencing the TRM, I checked the address, the IRQ number, > and the power domain, and verified that there are no new check_dtbs > warnings introduced. > > Thanks for the review. Best regards, Damon