From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29BF7202981 for ; Fri, 30 May 2025 11:53:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748606018; cv=none; b=mJPuSxU+dHVBAPt8AVbtLIo4qK25NpwbASHgfp7tx0mHn06//ppMZC/g4yT1yWpIsLoC0fZIZxMYhDsKKu+0Np0F+H92H3OlECtUOy3piw3kSZd83XT7nDWeyt8e2V7bAcc/tzgVpAkFnJgSe3dZx7+F56j5WodBQGn0p7xX7q8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748606018; c=relaxed/simple; bh=S3VeWtxKlJvzTgUsBlJdwT0AenvLuNtDX75s3YzO5DM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NUyXF8d3b5x10bAM8vM6dAJ3figMBV2U+8cu2poKxPvVMfPL+47drU0Q5YrNa5oZcDJIlm1C6gPgqGU37zvz1B9NlXSFegY++isuWPOTQgsxpxs+6EJbTZVLdzDOXXpBLJRyWhBzbWcLkbMmNUnKb5AJngPSXxS7swNTBFbArRo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kuJgAGYB; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kuJgAGYB" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-442ea341570so13385465e9.1 for ; Fri, 30 May 2025 04:53:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748606013; x=1749210813; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4UPJVljTY3N7PN9rlPr1KNAMnaMWaV65uercPLaJI+o=; b=kuJgAGYBzJCf6Ip7t/utX+OMl1melh/8OtH6rBCZ8QfFzYHE5lbO+ozlZFdYfxqPON 4VVf8TjtC90VND4TUeJORRMOWTRJf5bbtecJO7/ov+ahPz0RPwLRYPqBDmFHAd2f227k 33J5AC2X6UdxnmHqyN7u/D+xvwgKIAd4ARHwjQu5pOMdPX3nGIIVA7f+IL2dyzcuSnWZ AjPHEn5RCVB3uAz1WUuRx7Jc1zO/ZAENf9PIi8jLL+KlyN28g6Rm1yznEC4DyrZpYaPV qKNrLaGMkDLhVFKe0w5xs2DGvxc/Ud3ez4L0yifW+29KEuWhk9UotL7u+UWBWohbg07I 8hhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748606013; x=1749210813; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4UPJVljTY3N7PN9rlPr1KNAMnaMWaV65uercPLaJI+o=; b=hR8HR7B4zVifWjxjwGT4skg+ZH2oQ7MsQJhUlzCtH1iS2gCu8gX9s2uKP2IiKzD9nl gXP3sqCJvhNA3sJOHUzSjuBIWOOkIewasxHni56Wah5uOfTh1oot3vI4ILntNq2vJX3H olOeGN9qDEr1jMYyIC+qVrsgIEc4I4prZCKJ8V9x4KRkixSi7YZ1kwy0jfdxYVxUjKIZ 0kiTOht2wz06x6zL/ZVr5Ojh2xMfBokFY5PKoWdOzXb2J6EBU2/RN0t4GvER7ZM5TCpf RWdaxA2Zx7gIUrk2AcHAk6MCE9sgcGtv1aNXz0uvqriQXB4saiE2Zj2L5WxXaUc9G534 IEVQ== X-Gm-Message-State: AOJu0YwjTgjm8/GLN2HtslbI85v789kVVvKwibyY1aZEXWlN4J8wpH1b 2ofo4vIPb/K/bxI3d8gSFVPGNcalx4Nk7EjDKd88CfzRAasnagog5aiwWJhQysQ/DOo= X-Gm-Gg: ASbGncup1SE51SJy7g2rjAtWir3Wz2dfymeEJJ/7HU1702+9EwZkxwAsigTsyoJsf3u GZNIc7IE9KFpThaIK2hDx9kPv8o4J+TAmyT34Fu4TZje/Ybmwm8FzWj9aqeeAhVSCcEUZ4z3RXP Tdff8w5npVJWFaASpardj6btdaAipSMd/PHl6Napg5M2INHREPkqY+e2GZV2paTEBRRnC+Wq1sh HIGcbhL/iODC+/qMFX9Y/8weymsOdpNpTfyu7C74+k1KW6lExQNq3Be4pqkUn+qd0FJRMkGXZjK X3mYSA/9PFVbCQ+s/fiVwfrV5F2cpynrMBn7t72GkfVscMIC1XF+AYr/8mGPNuQ4KX6pO+0e+TT b/4s8Ig7tqtQ8+SZjtT9LIJNKw84= X-Google-Smtp-Source: AGHT+IEf5MxDQRZ1AOD7sTcnaYqSwj8ugFOpC72ckU4hsD9LywwTEslaQnTKyHBKOB6AHALVuW7X/A== X-Received: by 2002:a05:600c:348c:b0:450:d07e:ee14 with SMTP id 5b1f17b1804b1-450d8874cecmr19582285e9.17.1748606013438; Fri, 30 May 2025 04:53:33 -0700 (PDT) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d8000d8csm16096695e9.24.2025.05.30.04.53.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 May 2025 04:53:32 -0700 (PDT) Message-ID: <05ac9918-cc95-4288-a185-48bd4b31b77c@linaro.org> Date: Fri, 30 May 2025 12:53:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] media: qcom: camss: Add support for MSM8939 To: Bryan O'Donoghue , vincent.knecht@mailoo.org, Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, =?UTF-8?Q?Andr=C3=A9_Apitzsch?= , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht References: <20250530-camss-8x39-vbif-v3-0-fc91d15bb5d6@mailoo.org> <20250530-camss-8x39-vbif-v3-2-fc91d15bb5d6@mailoo.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30/05/2025 12:49, Bryan O'Donoghue wrote: > On 30/05/2025 10:00, Vincent Knecht via B4 Relay wrote: >> + camss->res->version == CAMSS_8x39 || > This is not correct - it should be 893x since 8939 and 8936 are ~ the > same SoC - probably 36 is just a binned version of 39. > > Anyway the x is the least significant digit. > > Please fix > --- > bod > No wait I'm wrong 8939 or 8039 - when adding 36 we will probably just use the compat string to differentiate. This is fine. Reviewed-by: Bryan O'Donoghue