From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1624FC433F5 for ; Wed, 25 May 2022 03:28:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242993AbiEYD2D (ORCPT ); Tue, 24 May 2022 23:28:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242176AbiEYD16 (ORCPT ); Tue, 24 May 2022 23:27:58 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B58F7A441; Tue, 24 May 2022 20:27:48 -0700 (PDT) X-UUID: c0ab4f24f121447d8a43857fd0b98e23-20220525 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5,REQID:67276e0d-1da5-416b-b95d-d929251d65a6,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACT ION:release,TS:45 X-CID-INFO: VERSION:1.1.5,REQID:67276e0d-1da5-416b-b95d-d929251d65a6,OB:0,LOB: 0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACTIO N:release,TS:45 X-CID-META: VersionHash:2a19b09,CLOUDID:551c5c47-4fb1-496b-8f1d-39e733fed1ea,C OID:710e40bb5222,Recheck:0,SF:28|17|19|48,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,QS:0,BEC:nil X-UUID: c0ab4f24f121447d8a43857fd0b98e23-20220525 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 762245409; Wed, 25 May 2022 11:27:43 +0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Wed, 25 May 2022 11:27:42 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 25 May 2022 11:27:41 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 25 May 2022 11:27:41 +0800 Message-ID: <05ad616704053c3f9b3275cd557b99bd56b3f40f.camel@mediatek.com> Subject: Re: [PATCH v18 1/6] soc: mediatek: mutex: add common interface for modules setting From: CK Hu To: Moudy Ho , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Krzysztof Kozlowski , Hans Verkuil CC: Chun-Kuang Hu , Rob Landley , Laurent Pinchart , , , , , , Alexandre Courbot , , , , , Benjamin Gaignard , AngeloGioacchino Del Regno , daoyuan huang , Ping-Hsun Wu , , , , , , , , Date: Wed, 25 May 2022 11:27:41 +0800 In-Reply-To: <20220512084139.15086-2-moudy.ho@mediatek.com> References: <20220512084139.15086-1-moudy.ho@mediatek.com> <20220512084139.15086-2-moudy.ho@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Moudy: On Thu, 2022-05-12 at 16:41 +0800, Moudy Ho wrote: > In order to allow multiple modules to operate MUTEX hardware through > a common interfrace, a flexible index "mtk_mutex_table_index" needs > to > be added to replace original component ID so that like DDP and MDP > can add their own MUTEX table settings independently. > > In addition, 4 generic interface "mtk_mutex_set_mod", > "mtk_mutex_set_sof", > "mtk_mutex_clear_mod" and "mtk_mutex_clear_sof" have been added, > which is > expected to replace the "mtk_mutex_add_comp" and > "mtk_mutex_remove_comp" > pair originally dedicated to DDP in the future. > > Signed-off-by: Moudy Ho > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > --- > drivers/soc/mediatek/mtk-mutex.c | 88 > ++++++++++++++++++++++++++ > include/linux/soc/mediatek/mtk-mutex.h | 22 +++++++ > 2 files changed, 110 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-mutex.c > b/drivers/soc/mediatek/mtk-mutex.c > index aaf8fc1abb43..a62ac1811419 100644 > --- a/drivers/soc/mediatek/mtk-mutex.c > +++ b/drivers/soc/mediatek/mtk-mutex.c > @@ -156,6 +156,8 @@ struct mtk_mutex_data { > const unsigned int *mutex_sof; > const unsigned int mutex_mod_reg; > const unsigned int mutex_sof_reg; > + const unsigned int *mutex_table_mod; > + const unsigned int *mutex_table_sof; > const bool no_clk; > }; > > @@ -530,6 +532,92 @@ void mtk_mutex_release(struct mtk_mutex *mutex) > } > EXPORT_SYMBOL_GPL(mtk_mutex_release); > > +static int mtk_mutex_write_mod(struct mtk_mutex *mutex, > + enum mtk_mutex_table_index idx, bool > clear) > +{ > + struct mtk_mutex_ctx *mtx = container_of(mutex, struct > mtk_mutex_ctx, > + mutex[mutex->id]); > + unsigned int reg; > + unsigned int offset; > + > + WARN_ON(&mtx->mutex[mutex->id] != mutex); > + > + if (idx < MUTEX_TABLE_IDX_MDP_RDMA0 || > + idx >= MUTEX_TABLE_IDX_MAX) { > + dev_err(mtx->dev, "Not supported MOD table index : %d", > idx); > + return -EINVAL; > + } > + > + offset = DISP_REG_MUTEX_MOD(mtx->data->mutex_mod_reg, > + mutex->id); > + reg = readl_relaxed(mtx->regs + offset); > + > + if (clear) > + reg &= ~BIT(mtx->data->mutex_table_mod[idx]); > + else > + reg |= BIT(mtx->data->mutex_table_mod[idx]); > + > + writel_relaxed(reg, mtx->regs + offset); > + > + return 0; > +} > + > +int mtk_mutex_set_mod(struct mtk_mutex *mutex, > + enum mtk_mutex_table_index idx) > +{ > + return mtk_mutex_write_mod(mutex, idx, false); > +} > +EXPORT_SYMBOL_GPL(mtk_mutex_set_mod); Why not just export symbol of mtk_mutex_write_mod() and drop mtk_mutex_set_mod()/mtk_mutex_clear_mod()? > + > +int mtk_mutex_clear_mod(struct mtk_mutex *mutex, > + enum mtk_mutex_table_index idx) > +{ > + return mtk_mutex_write_mod(mutex, idx, true); > +} > +EXPORT_SYMBOL_GPL(mtk_mutex_clear_mod); > + > +int mtk_mutex_write_sof(struct mtk_mutex *mutex, > + enum mtk_mutex_table_index idx, bool clear) > +{ > + struct mtk_mutex_ctx *mtx = container_of(mutex, struct > mtk_mutex_ctx, > + mutex[mutex->id]); > + unsigned int sof_id, val; > + > + WARN_ON(&mtx->mutex[mutex->id] != mutex); > + > + if (idx < MUTEX_TABLE_IDX_MDP_RDMA0 || > + idx >= MUTEX_TABLE_IDX_MAX) { > + dev_err(mtx->dev, "Not supported SOF table index : %d", > idx); > + return -EINVAL; > + } > + > + sof_id = mtx->data->mutex_table_sof[idx]; Why do you map each idx to a sof? For each idx, we could choose sof by different application. I would like to change parameter mtk_mutex_table_index to mtk_mutex_sof_index. Regards, CK > + > + if (clear) > + val = MUTEX_SOF_SINGLE_MODE; > + else > + val = mtx->data->mutex_sof[sof_id]; > + > + writel_relaxed(val, mtx->regs + > + DISP_REG_MUTEX_SOF(mtx->data->mutex_sof_reg, > mutex->id)); > + > + return 0; > +} > + > +int mtk_mutex_set_sof(struct mtk_mutex *mutex, > + enum mtk_mutex_table_index idx) > +{ > + return mtk_mutex_write_sof(mutex, idx, false); > +} > +EXPORT_SYMBOL_GPL(mtk_mutex_set_sof); > + > +int mtk_mutex_clear_sof(struct mtk_mutex *mutex, > + enum mtk_mutex_table_index idx) > +{ > + return mtk_mutex_write_sof(mutex, idx, true); > +} > +EXPORT_SYMBOL_GPL(mtk_mutex_clear_sof); > + > static int mtk_mutex_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > diff --git a/include/linux/soc/mediatek/mtk-mutex.h > b/include/linux/soc/mediatek/mtk-mutex.h > index 6fe4ffbde290..f174452212d6 100644 > --- a/include/linux/soc/mediatek/mtk-mutex.h > +++ b/include/linux/soc/mediatek/mtk-mutex.h > @@ -10,6 +10,20 @@ struct regmap; > struct device; > struct mtk_mutex; > > +enum mtk_mutex_table_index { > + /* MDP table index */ > + MUTEX_TABLE_IDX_MDP_RDMA0, > + MUTEX_TABLE_IDX_MDP_RSZ0, > + MUTEX_TABLE_IDX_MDP_RSZ1, > + MUTEX_TABLE_IDX_MDP_TDSHP0, > + MUTEX_TABLE_IDX_MDP_WROT0, > + MUTEX_TABLE_IDX_MDP_WDMA, > + MUTEX_TABLE_IDX_MDP_AAL0, > + MUTEX_TABLE_IDX_MDP_CCORR0, > + > + MUTEX_TABLE_IDX_MAX /* ALWAYS keep at the end */ > +}; > + > struct mtk_mutex *mtk_mutex_get(struct device *dev); > int mtk_mutex_prepare(struct mtk_mutex *mutex); > void mtk_mutex_add_comp(struct mtk_mutex *mutex, > @@ -22,5 +36,13 @@ void mtk_mutex_unprepare(struct mtk_mutex *mutex); > void mtk_mutex_put(struct mtk_mutex *mutex); > void mtk_mutex_acquire(struct mtk_mutex *mutex); > void mtk_mutex_release(struct mtk_mutex *mutex); > +int mtk_mutex_set_mod(struct mtk_mutex *mutex, > + enum mtk_mutex_table_index idx); > +int mtk_mutex_clear_mod(struct mtk_mutex *mutex, > + enum mtk_mutex_table_index idx); > +int mtk_mutex_set_sof(struct mtk_mutex *mutex, > + enum mtk_mutex_table_index idx); > +int mtk_mutex_clear_sof(struct mtk_mutex *mutex, > + enum mtk_mutex_table_index idx); > > #endif /* MTK_MUTEX_H */