From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0BF5156FD for ; Thu, 11 Jan 2024 12:35:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bn+zCbWs" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-336c8ab0b20so4618674f8f.1 for ; Thu, 11 Jan 2024 04:35:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704976500; x=1705581300; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=8xmwvOs8ItsKkGVZWvFz4GNk7Se6b6TGVQHJO+AsqTk=; b=bn+zCbWsgf23yMWfXyTEXRL3AAidoTZ1aRgpRbwAvAoz++3JV9fFGdUByL5T+BqF6E Gmg/XdmmL1ZxWQVcCYKP4zfZJ0R2QH+DIdXkqyCOVOTNsOj2ia8HJYr93UQkGtWE98Wq emie7s/djz6JK99UdpwYgmo229pPL1uYyh19C31ADhG/XwGiNURHkJzprCTtzGZfvVZB /2UOZblyH3STmpEjU7IyoPoSkH5xX/AREtPKSZ6OVq5Ltysjs6d5tQxN8DWysFfdh58r 7k9eTkTrhs7EC2jk6gAz9gCNOHwMhVjsuuDenk8H6J85Jty5y8Xy7oA956oGinSD8gT1 QgkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704976500; x=1705581300; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8xmwvOs8ItsKkGVZWvFz4GNk7Se6b6TGVQHJO+AsqTk=; b=ZKZhDq3oyoPvB7xyd3JcERDNj9VkA/RsIzM1VI7SVJWSxBN+BiflepmCvjUgnz5OIz gTaQeZsYkYNjqwt0N2wbmmYJwmc5uOekQ6XWaSaGthdGZlHtm9AdPL0uSiI+Avfq0PGz 2SkO0zwrr6xgglhBgWZd97jdmt5Zu6LqwaB8RhpZ51yiJFngPBry2RBn/adZ2eV3y27G HkQqfGejImNXYsQVV4YEvtHs1IoYKk73RkBjZwiFuWHSvQ7ojrN5A3+maJasL3dIf1cc CGi0A2lP2OBTjxEv/Fd8ViCjFP4v3wIbbjakf0fRgBF9iEe+K/e6QPL2IdPSinKqiAO9 gnBA== X-Gm-Message-State: AOJu0YxGtksCmEd7R2pCa0fgfRSWLlYy5/Fu5amo8sO4b/cZP5n/1WrV BK8yPXk15qTEzc+V4Llz71Ua0xTHXjQCZg== X-Google-Smtp-Source: AGHT+IHBfzDEkfBMWZKwVkSyy1K+59QjsL8NoZd3Eum5W0WTjIvdXTK+Np/6VDlhb30pz9hl6XK7Dg== X-Received: by 2002:a5d:4211:0:b0:337:8eb4:8ebc with SMTP id n17-20020a5d4211000000b003378eb48ebcmr136839wrq.64.1704976499879; Thu, 11 Jan 2024 04:34:59 -0800 (PST) Received: from localhost ([102.140.209.237]) by smtp.gmail.com with ESMTPSA id o14-20020adfe80e000000b0033674734a58sm1136322wrm.79.2024.01.11.04.34.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 04:34:59 -0800 (PST) Date: Thu, 11 Jan 2024 15:34:56 +0300 From: Dan Carpenter To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= Cc: Hans de Goede , Henry Shi , platform-driver-x86@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] platform/x86: silicom-platform: clean up a check Message-ID: <05ae147d-fcd4-4f14-b2a7-8dfc651cce82@moroto.mountain> References: <0402e613-446a-40d1-b676-0422f6223aa8@moroto.mountain> <90c2576b-006d-36eb-1fac-c4c4a6eccb4a@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <90c2576b-006d-36eb-1fac-c4c4a6eccb4a@linux.intel.com> On Thu, Jan 11, 2024 at 01:56:28PM +0200, Ilpo Järvinen wrote: > On Wed, 10 Jan 2024, Dan Carpenter wrote: > > > "value" is either non-zero, or zero. There isn't a third option. > > Delete the unnecessary code. > > > > Signed-off-by: Dan Carpenter > > --- > > drivers/platform/x86/silicom-platform.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/platform/x86/silicom-platform.c b/drivers/platform/x86/silicom-platform.c > > index 6ce43ccb3112..5cac698bf98d 100644 > > --- a/drivers/platform/x86/silicom-platform.c > > +++ b/drivers/platform/x86/silicom-platform.c > > @@ -258,10 +258,8 @@ static void silicom_gpio_set(struct gpio_chip *gc, > > > > if (value) > > silicom_mec_port_set(channel, 0); > > - else if (value == 0) > > - silicom_mec_port_set(channel, 1); > > else > > - pr_err("Wrong argument value: %d\n", value); > > + silicom_mec_port_set(channel, 1); > > This covers both cases without if: > > silicom_mec_port_set(channel, !value); > True. Let me resend it that way. regards, dan carpenter