From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752064AbdB1Dik (ORCPT ); Mon, 27 Feb 2017 22:38:40 -0500 Received: from szxga03-in.huawei.com ([45.249.212.189]:3420 "EHLO dggrg03-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751561AbdB1Dif (ORCPT ); Mon, 27 Feb 2017 22:38:35 -0500 Subject: Re: [f2fs-dev] [PATCH 2/3 v2] f2fs: add bitmaps for empty or full NAT blocks To: Jaegeuk Kim , , , References: <20170214020644.18189-1-jaegeuk@kernel.org> <20170214020644.18189-2-jaegeuk@kernel.org> <20170223225813.GH2026@jaegeuk.local> From: Chao Yu Message-ID: <05bf84ed-1e63-3dd0-9c9d-a7b483a8a602@huawei.com> Date: Tue, 28 Feb 2017 11:34:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20170223225813.GH2026@jaegeuk.local> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.58B4EFB9.005E,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: ff0ec765a569d01541e6ea7a10259895 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/2/24 6:58, Jaegeuk Kim wrote: > @@ -2326,7 +2431,8 @@ void flush_nat_entries(struct f2fs_sb_info *sbi) > * entries, remove all entries from journal and merge them > * into nat entry set. > */ > - if (!__has_cursum_space(journal, nm_i->dirty_nat_cnt, NAT_JOURNAL)) > + if (cpc->reason == CP_UMOUNT || enabled_nat_bits(sbi, cpc) Thanks, > + !__has_cursum_space(journal, nm_i->dirty_nat_cnt, NAT_JOURNAL)) > remove_nats_in_journal(sbi);