mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javierm@redhat.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Lennart Poettering <lennart@poettering.net>,
	linux-kernel@vger.kernel.org, Colin Walters <walters@verbum.org>,
	Peter Jones <pjones@redhat.com>, Alberto Ruiz <aruiz@redhat.com>,
	Christian Kellner <ckellner@redhat.com>,
	Chung-Chiang Cheng <cccheng@synology.com>,
	Muhammad Usama Anjum <usama.anjum@collabora.com>,
	Alexander Larsson <alexl@redhat.com>,
	Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v4 0/4] fat: add support for the renameat2 RENAME_EXCHANGE flag
Date: Wed, 8 Jun 2022 09:56:46 +0200	[thread overview]
Message-ID: <05bfb010-6b00-edb1-0e28-889a2ff71503@redhat.com> (raw)
In-Reply-To: <20220601173204.1372569-1-javierm@redhat.com>

Hello OGAWA,

On 6/1/22 19:32, Javier Martinez Canillas wrote:
> Hello,
> 
> The series adds support for the renameat2 system call RENAME_EXCHANGE flag
> (which allows to atomically replace two paths) to the vfat filesystem code.
> 
> There are many use cases for this, but we are particularly interested in
> making possible for vfat filesystems to be part of OSTree [0] deployments.
> 
> Currently OSTree relies on symbolic links to make the deployment updates
> an atomic transactional operation. But RENAME_EXCHANGE could be used [1]
> to achieve a similar level of robustness when using a vfat filesystem.
> 
> Patch #1 is just a preparatory patch to introduce the RENAME_EXCHANGE
> support, patch #2 moves some code blocks in vfat_rename() to a set of
> helper functions, that can be reused by tvfat_rename_exchange() that's
> added by patch #3 and finally patch #4 adds some kselftests to test it.
> 

I think that addressed all the issues you pointed out in v3, please let me
know if there's anything else that is needed for this patch series.

Would these be merged by you or should I ping someone else? I'm not
that familiar with how filesystem patches make into the mainline tree.

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat


  parent reply	other threads:[~2022-06-08  8:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-01 17:32 Javier Martinez Canillas
2022-06-01 17:32 ` [PATCH v4 1/4] fat: add a vfat_rename2() and make existing .rename callback a helper Javier Martinez Canillas
2022-06-01 17:32 ` [PATCH v4 2/4] fat: factor out reusable code in vfat_rename() as helper functions Javier Martinez Canillas
2022-06-01 17:32 ` [PATCH v4 3/4] fat: add renameat2 RENAME_EXCHANGE flag support Javier Martinez Canillas
2022-06-08 14:33   ` OGAWA Hirofumi
2022-06-08 16:55     ` Javier Martinez Canillas
2022-06-08 17:10       ` OGAWA Hirofumi
2022-06-08 18:21         ` Javier Martinez Canillas
2022-06-01 17:32 ` [PATCH v4 4/4] selftests/filesystems: add a vfat RENAME_EXCHANGE test Javier Martinez Canillas
2022-06-08  7:56 ` Javier Martinez Canillas [this message]
2022-06-08  9:42   ` [PATCH v4 0/4] fat: add support for the renameat2 RENAME_EXCHANGE flag OGAWA Hirofumi
2022-06-08 12:18     ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05bfb010-6b00-edb1-0e28-889a2ff71503@redhat.com \
    --to=javierm@redhat.com \
    --cc=alexl@redhat.com \
    --cc=aruiz@redhat.com \
    --cc=cccheng@synology.com \
    --cc=ckellner@redhat.com \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=lennart@poettering.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=pjones@redhat.com \
    --cc=shuah@kernel.org \
    --cc=usama.anjum@collabora.com \
    --cc=walters@verbum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®