From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: zgpeng <zgpeng.linux@gmail.com>,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/fair: Fix decision matrix of type misfit_task
Date: Mon, 25 Apr 2022 11:01:14 +0200 [thread overview]
Message-ID: <05c87803-59d3-2b3f-80ab-47b418c3f10f@arm.com> (raw)
In-Reply-To: <1650787010-8701-1-git-send-email-zgpeng@tencent.com>
On 24/04/2022 09:56, zgpeng wrote:
> When the group type of the busiest is misfit_task, as
> long as the type of the local group is not equal to
> has_spare, those situation already filtered while
> updating statistics.
>
> Signed-off-by: zgpeng <zgpeng@tencent.com>
> Reviewed-by: Samuel Liao <samuelliao@tencent.com>
> ---
> kernel/sched/fair.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index d4bd299..b8c67e7 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -9495,7 +9495,7 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s
> * busiest \ local has_spare fully_busy misfit asym imbalanced overloaded
> * has_spare nr_idle balanced N/A N/A balanced balanced
> * fully_busy nr_idle nr_idle N/A N/A balanced balanced
> - * misfit_task force N/A N/A N/A force force
> + * misfit_task force N/A N/A N/A N/A N/A
> * asym_packing force force N/A N/A force force
> * imbalanced force force N/A N/A force force
> * overloaded force force N/A N/A force avg_load
This issue has been sorted. Patch from Tao Zhou <tao.zhou@linux.dev> is
already on tip sched/core.
https://lkml.kernel.org/r/165062326028.4207.17060214721845047142.tip-bot2@tip-bot2
prev parent reply other threads:[~2022-04-25 9:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-24 7:56 zgpeng
2022-04-25 9:01 ` Dietmar Eggemann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05c87803-59d3-2b3f-80ab-47b418c3f10f@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=zgpeng.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®