From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28698C433E0 for ; Fri, 26 Mar 2021 06:08:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECDF361A4A for ; Fri, 26 Mar 2021 06:08:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229758AbhCZGHv (ORCPT ); Fri, 26 Mar 2021 02:07:51 -0400 Received: from smtp2.axis.com ([195.60.68.18]:34164 "EHLO smtp2.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbhCZGH1 (ORCPT ); Fri, 26 Mar 2021 02:07:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1616738848; x=1648274848; h=from:to:subject:date:message-id:references: content-transfer-encoding:mime-version; bh=E6eNUZQ3KpEv15NAH6e1EpXfcFRADmQJHhYR5BoWcx8=; b=G2cNr1+W0QcdHrfbMXYd5SkVZJMSs7b1+dC9vN14e+jMJKUY0ifRu90W 5IxHV+xLwMBe/RnPIjqtOSZ8Kx0/6oxRv04FtfGPms80U088FJdxeZvaq xP7iLA0GWcJqIbcHAoVGL1fuyD1TK/hT52OfZf7Av8mNdy06DS0o1XsQW KqP9Qva1Hzx0+0kHCy0cVLAe8JAuibDM5lVVkZBRoOtkW4QVmg0p+dM+B i2i+WAU0i5iKof/48SXVs++kBvjPDDR9WpjokiCMXLXabIVR3PDPU7yLJ lIu9zljLZWgE5qcUtxlxdZ01HJJrpyaxmDuSPIefDaNCm9wom2oP2VlQo Q==; From: Hermes Zhang To: "pavel@ucw.cz" , "dmurphy@ti.com" , "robh+dt@kernel.org" , "linux-leds@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Hermes Zhang , "lkml@axis.com" , kernel Subject: Re: [PATCH v2 2/2] leds: leds-multi-gpio: Add multiple GPIOs LED driver Thread-Topic: [PATCH v2 2/2] leds: leds-multi-gpio: Add multiple GPIOs LED driver Thread-Index: AQHXIgDn9WkVNzIcREGb9FBG0Jikcw== Date: Fri, 26 Mar 2021 06:07:26 +0000 Message-ID: <05c93a739a404e3cb181802619258674@XBOX01.axis.com> References: <20210326052801.17666-1-chenhui.zhang@axis.com> <20210326052801.17666-3-chenhui.zhang@axis.com> <20210326055559.izdyzb5gwgwthv4i@falbala.internal.home.lespocky.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.0.5.60] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/26/21 1:56 PM, Alexander Dahl wrote:=0A= >> +=0A= >> +module_platform_driver(multi_gpio_led_driver);=0A= >> +=0A= >> +MODULE_AUTHOR("Hermes Zhang ");=0A= >> +MODULE_DESCRIPTION("Multiple GPIOs LED driver");=0A= >> +MODULE_LICENSE("GPL v2");=0A= >> +MODULE_ALIAS("platform:leds-multi-gpio");=0A= > I did not review thouroughly, but in my mail the indentation looks=0A= > wrong. Did checkpatch complain?=0A= =0A= Sorry, I forgot to check the style before commit, but seems one problem=0A= about extra space:=0A= =0A= $ chkernel=0A= ERROR: space prohibited before that ',' (ctx:WxW)=0A= #164: FILE: drivers/leds/simple/leds-multi-gpio.c:76:=0A= + + sizeof(u8) * nr_states , GFP_KERNEL);=0A= ^=0A= =0A= I will fix it in next commit.=0A= =0A= =0A= Best Regards,=0A= =0A= Hermes=0A= =0A= =0A=