From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEEC5C38A2A for ; Fri, 8 May 2020 05:55:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6F46208D6 for ; Fri, 8 May 2020 05:55:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726974AbgEHFzM (ORCPT ); Fri, 8 May 2020 01:55:12 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:14212 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725865AbgEHFzM (ORCPT ); Fri, 8 May 2020 01:55:12 -0400 X-IronPort-AV: E=Sophos;i="5.73,366,1583164800"; d="scan'208";a="91677474" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 08 May 2020 13:55:08 +0800 Received: from G08CNEXMBPEKD06.g08.fujitsu.local (unknown [10.167.33.206]) by cn.fujitsu.com (Postfix) with ESMTP id E2FC24BCC89E; Fri, 8 May 2020 13:55:04 +0800 (CST) Received: from [10.167.226.60] (10.167.226.60) by G08CNEXMBPEKD06.g08.fujitsu.local (10.167.33.206) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 8 May 2020 13:55:04 +0800 Subject: Re: [PATCH v2] perf: fix compilation failure on i386 From: Cao jin To: CC: , , , , , , References: <20200501082537.4740-1-caoj.fnst@cn.fujitsu.com> Message-ID: <05c93fb7-d385-e7de-a98a-fce6c2b8e508@cn.fujitsu.com> Date: Fri, 8 May 2020 13:55:06 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20200501082537.4740-1-caoj.fnst@cn.fujitsu.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.226.60] X-ClientProxiedBy: G08CNEXCHPEKD04.g08.fujitsu.local (10.167.33.200) To G08CNEXMBPEKD06.g08.fujitsu.local (10.167.33.206) X-yoursite-MailScanner-ID: E2FC24BCC89E.AC1B6 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: caoj.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org BTW, this is reported by kernel test robot , so please help to add: Reported-by: kernel test robot when it got merged. -- Sincerely, Cao jin On 5/1/20 4:25 PM, Cao jin wrote: > Compilation on i386 complains as following: > > util/session.c: In function 'perf_session__process_compressed_event': > util/session.c:91:11: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'size_t {aka unsigned int}' [-Werror=format=] > pr_debug("decomp (B): %ld to %ld\n", src_size, decomp_size); > ^ > > util/zstd.c: In function 'zstd_decompress_stream': > util/zstd.c:102:11: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'size_t {aka unsigned int}' [-Werror=format=] > pr_err("failed to decompress (B): %ld -> %ld, dst_size %ld : %s\n", > ^ > > Fix them by pairing "%zd" to size_t. > > Also revert an unnecessary conversion: "(long)src_size" to plain "src_size" > with conversion specifier "%zd". > > Signed-off-by: Cao jin > --- > tools/perf/util/session.c | 2 +- > tools/perf/util/zstd.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c > index 0b0bfe5bef17..50c2ffa388ad 100644 > --- a/tools/perf/util/session.c > +++ b/tools/perf/util/session.c > @@ -88,7 +88,7 @@ static int perf_session__process_compressed_event(struct perf_session *session, > session->decomp_last = decomp; > } > > - pr_debug("decomp (B): %ld to %ld\n", src_size, decomp_size); > + pr_debug("decomp (B): %zd to %zd\n", src_size, decomp_size); > > return 0; > } > diff --git a/tools/perf/util/zstd.c b/tools/perf/util/zstd.c > index d2202392ffdb..877bfb79e4af 100644 > --- a/tools/perf/util/zstd.c > +++ b/tools/perf/util/zstd.c > @@ -74,8 +74,8 @@ size_t zstd_compress_stream_to_records(struct zstd_data *data, void *dst, size_t > ret = ZSTD_compressStream(data->cstream, &output, &input); > ZSTD_flushStream(data->cstream, &output); > if (ZSTD_isError(ret)) { > - pr_err("failed to compress %ld bytes: %s\n", > - (long)src_size, ZSTD_getErrorName(ret)); > + pr_err("failed to compress %zd bytes: %s\n", > + src_size, ZSTD_getErrorName(ret)); > memcpy(dst, src, src_size); > return src_size; > } > @@ -99,7 +99,7 @@ size_t zstd_decompress_stream(struct zstd_data *data, void *src, size_t src_size > while (input.pos < input.size) { > ret = ZSTD_decompressStream(data->dstream, &output, &input); > if (ZSTD_isError(ret)) { > - pr_err("failed to decompress (B): %ld -> %ld, dst_size %ld : %s\n", > + pr_err("failed to decompress (B): %zd -> %zd, dst_size %zd : %s\n", > src_size, output.size, dst_size, ZSTD_getErrorName(ret)); > break; > } >