Re: [PATCH] watchdog: dw_wdt: Fix default timeout

[Guenter Roeck <linux@roeck-us.net>]

On 7/17/25 09:55, Sebastian Reichel wrote:
> The Synopsys Watchdog driver sets the default timeout to 30 seconds,
> but on some devices this is not a valid timeout. E.g. on RK3588 the
> actual timeout being used is 44 seconds instead.
> 
> Once the watchdog is started the value is updated accordingly, but
> it would be better to expose a sensible timeout to userspace without
> the need to first start the watchdog.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> This has been found when setting up a CI pipeline, that
> intentionally runs into the watchdog timeout.
> ---
>   drivers/watchdog/dw_wdt.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
> index 26efca9ae0e7d2fea1b2eaf68085a70829b62b3a..c3fbb6068c520133c8a4ca97313706e877857a7f 100644
> --- a/drivers/watchdog/dw_wdt.c
> +++ b/drivers/watchdog/dw_wdt.c
> @@ -644,6 +644,8 @@ static int dw_wdt_drv_probe(struct platform_device *pdev)
>   	} else {
>   		wdd->timeout = DW_WDT_DEFAULT_SECONDS;
>   		watchdog_init_timeout(wdd, 0, dev);
> +		/* Limit timeout value to hardware constraints. */
> +		dw_wdt_set_timeout(wdd, wdd->timeout);
>   	}
>   
>   	platform_set_drvdata(pdev, dw_wdt);
> 
> ---
> base-commit: e2291551827fe5d2d3758c435c191d32b6d1350e
> change-id: 20250717-dw-wdt-fix-initial-timeout-d4b3a2ada6ed
> 
> Best regards,