From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44FD9261B70 for ; Thu, 6 Aug 2026 07:23:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.122 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786001029; cv=none; b=mPeMko+J1ulVlwy2tPRTyHWXZ+00GkbiTaa93K57ALIa2+3e9Gcn7+fWOkIRcjAiS4gIbizzSTrC3sL4Q5rv6ynNc0V+6ke1HE1hl7lA//+BdtoMGw9I9e+df/k645D0V5IE2A50uRlCkCOMNdeZfuyxMhAE3zdyH51ricihNw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786001029; c=relaxed/simple; bh=LMPevxV0A29CNc6t5eDdpwL12MZURWCVnZ+BsKxDGe8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YaWJI3xP2OgM16N690HyCva0N/Cpn1i7uy0pR9+ayuNAwmr5VcjkEcwF+i3IxvMBcYteRLDKSMAgBXXo6WsNN+PJRhOCO6a236Kmci0EPPHZdf1HZ8fgGkHB15tXJMPPHGJ5tw9pUg43Zwpg1PvzHLIoLrpR/lkznw50Z3LdwTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b=k15zigeh; arc=none smtp.client-ip=185.125.188.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b="k15zigeh" Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id BDDA53FBF4 for ; Thu, 6 Aug 2026 07:23:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20251003; t=1786001017; bh=OM4Tu6JrAh8ypGHbwhBaJ0oztpR0yZxjdLdssuH7zA0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k15zigehwXsqWOY5pYe33O5c0Nm1XYlJfUOO33YGrG7MpNpeJh/jiAiJlB4y8nkOu eJrOhA6XZWALEud++PaTe04l8unBEI0+99MaGII89gjVlxQKHToRekGa6sYNyLCWQe GIRd6Y+iPsaxf77cvqsFh4ffu162YH8kDQIEaGFHMC0EN2QQdWJyqq+7Xmsru1IQ68 nj6skX5RzA7nvJVrAfqRmE6jT0eIQ+6/adeVpz/pK0e3NNx8IFpljefev0ehgFA2AY YZeiadllx59DdAAq08t+TkA74tkTrLCRroGFwPQPZULHjAOGynjaLjcZOW8727FE17 NL+JgZosysTGtxdwpBlm3XOGOevuzdcbBdmSxGKOGbjLTfi0yVrYXQu0xk43f/kxRy DP8sTevi54JO+9ICM893gIc/b4DSRB6+gUur7fCiwM+MrLmZESXRFO6L5ZkvR2S1hh ZRXxGki/Dm2F3o2OP9rxcegTXPESGLdFqyZ8ErBmR2ZfYqmIFBhwICGrq2U8AQtboK 0d9tSiizO/ufGilKCSJ5l3xueHqhkQakj7fh5QFsETzUsNcaYobfzyq+kBotHRJpxI Ssl7+p/Er4W6VmrK8sr9gR8jfw2qFgb5qmK1kQ8DdhYRimd0rYRspY+huDmVJDDjnj yHzkGGubZJp64yXua3x8cOas= Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cca5e0a0c9so34165565ad.1 for ; Thu, 06 Aug 2026 00:23:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786001016; x=1786605816; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:from:content-language:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=OM4Tu6JrAh8ypGHbwhBaJ0oztpR0yZxjdLdssuH7zA0=; b=kL97idpylIqoDFz1w81q7fAUGnWPqjc+gi8Kt67wH+a+vkoQBdQLhC8kmlz44t6W/1 yoSl+289ChXo61DBXXLuFsDD3aOq1Awj/e2ScksYiPbiXAl7u9YKUG2KRh5oDVN2YcBv R/YvMW5+vqsAZIcQut80bZptH56vNj+S/Y0tSO6yTc5DndOQy1oI0JR4Av4avcwC9DUo HsoAxL9FX0Q1PGJcyeT8Wgg3np2v1lIMpBzCSomEI/psgAofIh280gdg4LVUKDiQiEZR Q/kPhoSsZWPh9gpjaMNVC0EPyvCuuQlRiDdhiKbmcjEOLVpra+E7rpcQWeAQfp1sQW5W w0RQ== X-Forwarded-Encrypted: i=1; AHgh+Rpm0r3uyoy+C3df9nYRD5ikTA8t9KGOXd3Gm4imAAPahYbdRyrUVrL/1WrQ5wmNmREDuHw7oKFE4Hj/bXE=@vger.kernel.org X-Gm-Message-State: AOJu0YzN2AD6kU5OYx5QjVGNN6zoDdcth58f4iy/pJY+UH01IDhDFdpK CqKqkbhRqvZuIFA7SHYiLsZVnteNn2ROwfb11mXE+7vm26LwWrrOeGWJwANoP2Tc0+ZvE3b+Tjl Xu7O82R4pFxOhehtycIoa53fwZ5ZnQ+8Xb9aYMN4Wi205bpNTOwN5Eva+3MwUVEPokjTPIlglC8 3+JVw1fg== X-Gm-Gg: AR+sD12rSTaW/S9JLvquz/PDdDEvpHgP4/59f8dCIET7DpaORFoS1hMMmrzXMS0q/Gq bbKrBxzMr+MeSyKtk3hVrrJJhXIl5nE6piUNf+8caPYr/4OfPrSsqfK+m/AMV57hdo0KnsPhxdE 6Hckf+rUWk2ZEUXfxry/Z1rF/t+8XjnjLlz52MeguNQmPcKKEbInrvW804GwZ9ykjm18JAVQnLZ grCAXwBh7A2BVTZ/Ekep/ZXnUvKkGtZK/Lj4FDvGWlho9dmsgmWLWyt6f48DeZuFe6gn3pSBYQf 69TqP1O+khYLpKf3koaBrW+UYKStN0ytdI+Ex8C3qm8rI9u7Ww9pP3czLYJ0FW/BK56P59yG3e9 uYut+PO/5ovPAP88= X-Received: by 2002:a17:902:cec3:b0:2d0:4021:bb62 with SMTP id d9443c01a7336-2d0ca82aae9mr138201735ad.16.1786001016085; Thu, 06 Aug 2026 00:23:36 -0700 (PDT) X-Received: by 2002:a17:902:cec3:b0:2d0:4021:bb62 with SMTP id d9443c01a7336-2d0ca82aae9mr138201385ad.16.1786001015725; Thu, 06 Aug 2026 00:23:35 -0700 (PDT) Received: from [192.168.192.71] ([50.47.147.90]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2d0aa4f35d5sm26425315ad.82.2026.08.06.00.23.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 00:23:35 -0700 (PDT) Message-ID: <05de6ad2-6b0a-4795-be4f-c30c4d4c6341@canonical.com> Date: Thu, 6 Aug 2026 00:23:34 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] apparmor: use SEND_SIG_NOINFO instead of NULL in aa_audit() To: Oleg Nesterov , Georgia Garcia , Paul Moore , James Morris , "Serge E. Hallyn" Cc: apparmor@lists.ubuntu.com, linux-kernel@vger.kernel.org References: Content-Language: en-US From: John Johansen Autocrypt: addr=john.johansen@canonical.com; keydata= xsFNBE5mrPoBEADAk19PsgVgBKkImmR2isPQ6o7KJhTTKjJdwVbkWSnNn+o6Up5knKP1f49E BQlceWg1yp/NwbR8ad+eSEO/uma/K+PqWvBptKC9SWD97FG4uB4/caomLEU97sLQMtnvGWdx rxVRGM4anzWYMgzz5TZmIiVTZ43Ou5VpaS1Vz1ZSxP3h/xKNZr/TcW5WQai8u3PWVnbkjhSZ PHv1BghN69qxEPomrJBm1gmtx3ZiVmFXluwTmTgJOkpFol7nbJ0ilnYHrA7SX3CtR1upeUpM a/WIanVO96WdTjHHIa43fbhmQube4txS3FcQLOJVqQsx6lE9B7qAppm9hQ10qPWwdfPy/+0W 6AWtNu5ASiGVCInWzl2HBqYd/Zll93zUq+NIoCn8sDAM9iH+wtaGDcJywIGIn+edKNtK72AM gChTg/j1ZoWH6ZeWPjuUfubVzZto1FMoGJ/SF4MmdQG1iQNtf4sFZbEgXuy9cGi2bomF0zvy BJSANpxlKNBDYKzN6Kz09HUAkjlFMNgomL/cjqgABtAx59L+dVIZfaF281pIcUZzwvh5+JoG eOW5uBSMbE7L38nszooykIJ5XrAchkJxNfz7k+FnQeKEkNzEd2LWc3QF4BQZYRT6PHHga3Rg ykW5+1wTMqJILdmtaPbXrF3FvnV0LRPcv4xKx7B3fGm7ygdoowARAQABzStKb2huIEpvaGFu c2VuIDxqb2huLmpvaGFuc2VuQGNhbm9uaWNhbC5jb20+wsF3BBMBCgAhBQJOjRdaAhsDBQsJ CAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJEAUvNnAY1cPYi0wP/2PJtzzt0zi4AeTrI0w3Rj8E Waa1NZWw4GGo6ehviLfwGsM7YLWFAI8JB7gsuzX/im16i9C3wHYXKs9WPCDuNlMc0rvivqUI JXHHfK7UHtT0+jhVORyyVVvX+qZa7HxdZw3jK+ROqUv4bGnImf31ll99clzo6HpOY59soa8y 66/lqtIgDckcUt/1ou9m0DWKwlSvulL1qmD25NQZSnvB9XRZPpPd4bea1RTa6nklXjznQvTm MdLq5aJ79j7J8k5uLKvE3/pmpbkaieEsGr+azNxXm8FPcENV7dG8Xpd0z06E+fX5jzXHnj69 DXXc3yIvAXsYZrXhnIhUA1kPQjQeNG9raT9GohFPMrK48fmmSVwodU8QUyY7MxP4U6jE2O9L 7v7AbYowNgSYc+vU8kFlJl4fMrX219qU8ymkXGL6zJgtqA3SYHskdDBjtytS44OHJyrrRhXP W1oTKC7di/bb8jUQIYe8ocbrBz3SjjcL96UcQJecSHu0qmUNykgL44KYzEoeFHjr5dxm+DDg OBvtxrzd5BHcIbz0u9ClbYssoQQEOPuFmGQtuSQ9FmbfDwljjhrDxW2DFZ2dIQwIvEsg42Hq 5nv/8NhW1whowliR5tpm0Z0KnQiBRlvbj9V29kJhs7rYeT/dWjWdfAdQSzfoP+/VtPRFkWLr 0uCwJw5zHiBgzsFNBE5mrPoBEACirDqSQGFbIzV++BqYBWN5nqcoR+dFZuQL3gvUSwku6ndZ vZfQAE04dKRtIPikC4La0oX8QYG3kI/tB1UpEZxDMB3pvZzUh3L1EvDrDiCL6ef93U+bWSRi GRKLnNZoiDSblFBST4SXzOR/m1wT/U3Rnk4rYmGPAW7ltfRrSXhwUZZVARyJUwMpG3EyMS2T dLEVqWbpl1DamnbzbZyWerjNn2Za7V3bBrGLP5vkhrjB4NhrufjVRFwERRskCCeJwmQm0JPD IjEhbYqdXI6uO+RDMgG9o/QV0/a+9mg8x2UIjM6UiQ8uDETQha55Nd4EmE2zTWlvxsuqZMgy W7gu8EQsD+96JqOPmzzLnjYf9oex8F/gxBSEfE78FlXuHTopJR8hpjs6ACAq4Y0HdSJohRLn 5r2CcQ5AsPEpHL9rtDW/1L42/H7uPyIfeORAmHFPpkGFkZHHSCQfdP4XSc0Obk1olSxqzCAm uoVmRQZ3YyubWqcrBeIC3xIhwQ12rfdHQoopELzReDCPwmffS9ctIb407UYfRQxwDEzDL+m+ TotTkkaNlHvcnlQtWEfgwtsOCAPeY9qIbz5+i1OslQ+qqGD2HJQQ+lgbuyq3vhefv34IRlyM sfPKXq8AUTZbSTGUu1C1RlQc7fpp8W/yoak7dmo++MFS5q1cXq29RALB/cfpcwARAQABwsFf BBgBCgAJBQJOZqz6AhsMAAoJEAUvNnAY1cPYP9cP/R10z/hqLVv5OXWPOcpqNfeQb4x4Rh4j h/jS9yjes4uudEYU5xvLJ9UXr0wp6mJ7g7CgjWNxNTQAN5ydtacM0emvRJzPEEyujduesuGy a+O6dNgi+ywFm0HhpUmO4sgs9SWeEWprt9tWrRlCNuJX+u3aMEQ12b2lslnoaOelghwBs8IJ r998vj9JBFJgdeiEaKJLjLmMFOYrmW197As7DTZ+R7Ef4gkWusYFcNKDqfZKDGef740Xfh9d yb2mJrDeYqwgKb7SF02Hhp8ZnohZXw8ba16ihUOnh1iKH77Ff9dLzMEJzU73DifOU/aArOWp JZuGJamJ9EkEVrha0B4lN1dh3fuP8EjhFZaGfLDtoA80aPffK0Yc1R/pGjb+O2Pi0XXL9AVe qMkb/AaOl21F9u1SOosciy98800mr/3nynvid0AKJ2VZIfOP46nboqlsWebA07SmyJSyeG8c XA87+8BuXdGxHn7RGj6G+zZwSZC6/2v9sOUJ+nOna3dwr6uHFSqKw7HwNl/PUGeRqgJEVu++ +T7sv9+iY+e0Y+SolyJgTxMYeRnDWE6S77g6gzYYHmcQOWP7ZMX+MtD4SKlf0+Q8li/F9GUL p0rw8op9f0p1+YAhyAd+dXWNKf7zIfZ2ME+0qKpbQnr1oizLHuJX/Telo8KMmHter28DPJ03 lT9Q Organization: Canonical In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/5/26 09:52, Oleg Nesterov wrote: > SEND_SIG_NOINFO is defined as ((struct kernel_siginfo *) 0), so passing > NULL works, but: > > - this works "by accident" and looks as if the caller doesn't understand > the signal sending API. > > - more importantly, this hides the usage of SEND_SIG_NOINFO from grep, > and this is really bad. > > Signed-off-by: Oleg Nesterov this is now in apparmor-next > --- > security/apparmor/audit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/apparmor/audit.c b/security/apparmor/audit.c > index 4a60b6fda75f..15e42e96b163 100644 > --- a/security/apparmor/audit.c > +++ b/security/apparmor/audit.c > @@ -192,7 +192,7 @@ int aa_audit(int type, struct aa_profile *profile, > aa_audit_msg(type, ad, cb); > > if (ad->type == AUDIT_APPARMOR_KILL) > - (void)send_sig_info(profile->signal, NULL, > + send_sig_info(profile->signal, SEND_SIG_NOINFO, > ad->common.type == LSM_AUDIT_DATA_TASK && > ad->common.u.tsk ? ad->common.u.tsk : current); >