mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jie Luo <quic_luoj@quicinc.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Lei Wei <quic_leiwei@quicinc.com>,
	Suruchi Agarwal <quic_suruchia@quicinc.com>,
	Pavithra R <quic_pavir@quicinc.com>,
	Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	Kees Cook <kees@kernel.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>
Cc: <linux-arm-msm@vger.kernel.org>, <netdev@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-doc@vger.kernel.org>, <linux-hardening@vger.kernel.org>,
	<quic_kkumarcs@quicinc.com>, <quic_linchen@quicinc.com>,
	<srinivas.kandagatla@linaro.org>,
	<bartosz.golaszewski@linaro.org>, <john@phrozen.org>
Subject: Re: [PATCH net-next v2 07/14] net: ethernet: qualcomm: Initialize PPE queue settings
Date: Thu, 9 Jan 2025 22:20:22 +0800	[thread overview]
Message-ID: <05e04632-5d79-4f07-bf29-a49c86910d6e@quicinc.com> (raw)
In-Reply-To: <4916d329-4513-46e1-ac1c-34628f335dde@wanadoo.fr>



On 1/9/2025 3:29 AM, Christophe JAILLET wrote:
> Le 08/01/2025 à 14:47, Luo Jie a écrit :
>> Configure unicast and multicast hardware queues for the PPE
>> ports to enable packet forwarding between the ports.
>>
>> Each PPE port is assigned with a range of queues. The queue ID
>> selection for a packet is decided by the queue base and queue
>> offset that is configured based on the internal priority and
>> the RSS hash value of the packet.
>>
>> Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
> 
> ...
> 
>> +        /* Initialize the queue offset of RSS hash as 0 to avoid the
>> +         * random hardware value that will lead to the unexpected
>> +         * destination queue generated.
>> +         */
>> +        index = 0;
> 
> Useless.

Will remove it.

> 
>> +        for (index = 0; index < PPE_QUEUE_HASH_NUM; index++) {
>> +            ret = ppe_queue_ucast_offset_hash_set(ppe_dev, port_id,
>> +                                  index, 0);
>> +            if (ret)
>> +                return ret;
>> +        }
>> +    }
>> +
>> +    return 0;
>> +}
> 
> ...
> 
> CJ
> 


  reply	other threads:[~2025-01-09 14:20 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-08 13:47 [PATCH net-next v2 00/14] Add PPE driver for Qualcomm IPQ9574 SoC Luo Jie
2025-01-08 13:47 ` [PATCH net-next v2 01/14] dt-bindings: net: Add PPE " Luo Jie
2025-01-09  9:15   ` Krzysztof Kozlowski
2025-01-10 15:47     ` Jie Luo
2025-01-08 13:47 ` [PATCH net-next v2 02/14] docs: networking: Add PPE driver documentation " Luo Jie
2025-01-08 13:47 ` [PATCH net-next v2 03/14] net: ethernet: qualcomm: Add PPE driver for " Luo Jie
2025-01-08 19:19   ` Christophe JAILLET
2025-01-09 14:18     ` Jie Luo
2025-01-08 13:47 ` [PATCH net-next v2 04/14] net: ethernet: qualcomm: Initialize PPE buffer management for IPQ9574 Luo Jie
2025-01-09 17:27   ` Simon Horman
2025-01-09 20:11     ` Simon Horman
2025-01-10 15:42       ` Jie Luo
2025-01-08 13:47 ` [PATCH net-next v2 05/14] net: ethernet: qualcomm: Initialize PPE queue " Luo Jie
2025-01-08 13:47 ` [PATCH net-next v2 06/14] net: ethernet: qualcomm: Initialize the PPE scheduler settings Luo Jie
2025-01-08 19:27   ` Christophe JAILLET
2025-01-09 14:19     ` Jie Luo
2025-01-09 17:42   ` Simon Horman
2025-01-10 15:40     ` Jie Luo
2025-01-08 13:47 ` [PATCH net-next v2 07/14] net: ethernet: qualcomm: Initialize PPE queue settings Luo Jie
2025-01-08 19:29   ` Christophe JAILLET
2025-01-09 14:20     ` Jie Luo [this message]
2025-01-09 17:52   ` Simon Horman
2025-01-10 15:38     ` Jie Luo
2025-01-08 13:47 ` [PATCH net-next v2 08/14] net: ethernet: qualcomm: Initialize PPE service code settings Luo Jie
2025-01-09 17:58   ` Simon Horman
2025-01-10 15:36     ` Jie Luo
2025-01-08 13:47 ` [PATCH net-next v2 09/14] net: ethernet: qualcomm: Initialize PPE port control settings Luo Jie
2025-01-08 13:47 ` [PATCH net-next v2 10/14] net: ethernet: qualcomm: Initialize PPE RSS hash settings Luo Jie
2025-01-08 13:47 ` [PATCH net-next v2 11/14] net: ethernet: qualcomm: Initialize PPE queue to Ethernet DMA ring mapping Luo Jie
2025-01-08 13:47 ` [PATCH net-next v2 12/14] net: ethernet: qualcomm: Initialize PPE L2 bridge settings Luo Jie
2025-01-08 16:59   ` Andrew Lunn
2025-01-13  3:39     ` Lei Wei
2025-01-13 13:37       ` Andrew Lunn
2025-01-14 11:29         ` Lei Wei
2025-01-14 13:02           ` Andrew Lunn
2025-01-15  6:57             ` Lei Wei
2025-01-08 13:47 ` [PATCH net-next v2 13/14] net: ethernet: qualcomm: Add PPE debugfs support for PPE counters Luo Jie
2025-01-08 16:43   ` Andrew Lunn
2025-01-09 14:24     ` Jie Luo
2025-01-08 13:47 ` [PATCH net-next v2 14/14] MAINTAINERS: Add maintainer for Qualcomm PPE driver Luo Jie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05e04632-5d79-4f07-bf29-a49c86910d6e@quicinc.com \
    --to=quic_luoj@quicinc.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=gustavoars@kernel.org \
    --cc=horms@kernel.org \
    --cc=john@phrozen.org \
    --cc=kees@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=quic_kkumarcs@quicinc.com \
    --cc=quic_leiwei@quicinc.com \
    --cc=quic_linchen@quicinc.com \
    --cc=quic_pavir@quicinc.com \
    --cc=quic_suruchia@quicinc.com \
    --cc=robh@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®