From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1434653AbdDZClO (ORCPT ); Tue, 25 Apr 2017 22:41:14 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:36841 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1432142AbdDZClF (ORCPT ); Tue, 25 Apr 2017 22:41:05 -0400 Subject: Re: [PATCH] scsi: stex: make S6flag static To: Colin King , Charles , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Promise_Linux@promise.com References: <20170425173619.11955-1-colin.king@canonical.com> From: Charles Chiou Message-ID: <05e23578-0bc9-ebcc-28cd-22b8e6a06f00@gmail.com> Date: Wed, 26 Apr 2017 10:40:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <20170425173619.11955-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good to me. Thanks for the improvement. On 4/26/2017 1:36 AM, Colin King wrote: > From: Colin Ian King > > This module specific flag can be made static as it does > not need to be in global scope. > > Reviewed-by: Charles Chiou > Signed-off-by: Colin Ian King > --- > drivers/scsi/stex.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c > index 0751561b59da..9b20643ab49d 100644 > --- a/drivers/scsi/stex.c > +++ b/drivers/scsi/stex.c > @@ -363,7 +363,7 @@ struct st_card_info { > u16 sts_count; > }; > > -int S6flag; > +static int S6flag; > static int stex_halt(struct notifier_block *nb, ulong event, void *buf); > static struct notifier_block stex_notifier = { > stex_halt, NULL, 0 >