From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB9A419D891 for ; Wed, 18 Dec 2024 00:03:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734480196; cv=none; b=XVsISstPu8wNtJkaX75eReaHEX8me46/GFwhNibot5IqHVbd5udBcuo9CWO8XoX+nySLtTYnyNxRy1YztlbDs30DLC44gDstkYxtXNtPNyJuO0g0lf1mGopvxnd4/hjZMgHPKEm62CO1XUehfAW3E+RCx3HHTTDwLz7kVIsDTyg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734480196; c=relaxed/simple; bh=dCJ50PBrPKca+uCIfbJcxjFM+AfbluTjYGrl7FsqjyY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=iAsg3HLo7ErrlEkYYYsDWGQ9LXWUU6NEowHz4JCKbacjKKyFp1DXz3hht9eMQ9BH7N4fGXmud0Fd44Iq99bhaGBZ//wTUlYghXrqJ03f9P3oKGekvS7CJY50ERZC/uitAkE//u1lON9v3Xtnu6O2JDVQy1BF0hm+Lx5gAmfchRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SNKJBj5a; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SNKJBj5a" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734480193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=euCr6wi/cnWh3ZO95NgGNByJiDPswzoDdf0BlpgWP40=; b=SNKJBj5aS+Q7HBsJp55MhpmaoKBnY4wKVbEHOicDXxKqpRBDc2F+DUrfc2L4RxRGQKp/qw Leb0g90A6OcF4E5kZT3ITZLfY0YVKCv/p5ycSc8vuK+uApvjzm2qeh15UFBkGwjohY6n+G P8ScU8YuizdNGUdAHy789VEkpjAKtvE= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-224-M3GRISjPPx2H5_xTxqn8Og-1; Tue, 17 Dec 2024 19:03:12 -0500 X-MC-Unique: M3GRISjPPx2H5_xTxqn8Og-1 X-Mimecast-MFC-AGG-ID: M3GRISjPPx2H5_xTxqn8Og Received: by mail-il1-f199.google.com with SMTP id e9e14a558f8ab-3a81357cdc7so2598305ab.1 for ; Tue, 17 Dec 2024 16:03:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734480192; x=1735084992; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=euCr6wi/cnWh3ZO95NgGNByJiDPswzoDdf0BlpgWP40=; b=pBoV1E8kB01ERzkDdjAiyxxUgFodSfsN6jhAymB1faOCO+GTAIehwVbBUcMzaxfhIc v66LQ8RIeDhPvthvfJNN7fFJfi0YkUZZ7FTlRd5i4uLVUrAyEJLWxJCP1TRVWtqclc4V zAsAMLMUq7w8rJR2zmx+tOoG0nD05D/p4lAiRyn0r98TttH6+1IkV+PcjsLM8MuzlJ1R 3SUiS4kg7ObUWADoLe8S+U1pGEs0Rfbr4hhnsiX+ZxHLhD8r7KjZChfDMeGrLUHY37/9 vC3lgzgMKJ5ZD6V+LoPKeKrp3I8jJ89ViesK79PBvP32qWCL+fIDtT64C1/QVwDptokf FQtg== X-Forwarded-Encrypted: i=1; AJvYcCUnMxlfeG9uDa1No8Ny+duOH3qew93HwItJkdv99R2wJ5BPfoQFPN9jK2ldJFqLbOj7b+LYyOL4i6qNc7E=@vger.kernel.org X-Gm-Message-State: AOJu0YzxEh84/naOWJUg/o8sV7AzV1Q2PXFOkEogy36lfWRrr9aUXKGt w1KOwmVakfws8KViPnKVaInLqYD43ppXGFAPjQni2ViA4/iOPN9R0tsg2RQc0SZblAIaiGSDkQq HaM9Py6tlJH/ISAfdIkGmGG+viv4J9Ho/auoj8gAuXfff+97V9fXD4PHYEkIWig== X-Gm-Gg: ASbGncsmmFVb2T0AFfmfg4xFRiKs0WnJ08ja5bWaoFlZZcLKVW7u6nGge7r2/+bU4vx tNs9KvvCvtTI1EJ9yppckhl/xghBln+j2SJqiDvETRPlf5WUndDkk6UlAFoOJIffFo4osq6mGEz goPhA6FjdsQFJQwsdOefD36+2+VG8uz613e4pD8jGjnIZHeUFzG44C3HIRDnZFtSfyPfOJqYeu1 YGtvu6VbVnRfgOxkQpgTybXWXmsOqhOw6jbgoLD3m5lOAUuUo3DHLeg X-Received: by 2002:a05:6e02:18ca:b0:3a9:d0e6:abf2 with SMTP id e9e14a558f8ab-3bb0ac12780mr63506175ab.10.1734480191908; Tue, 17 Dec 2024 16:03:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IF4yEcgdLBxwvTkvC/JJF6nW5pNHSx4+QXywD30kBwjYVYvsLZoVt5oDQEP/sYzY5g89o04Rg== X-Received: by 2002:a05:6e02:18ca:b0:3a9:d0e6:abf2 with SMTP id e9e14a558f8ab-3bb0ac12780mr63505975ab.10.1734480191622; Tue, 17 Dec 2024 16:03:11 -0800 (PST) Received: from starship ([2607:fea8:fc01:8d8d:6adb:55ff:feaa:b156]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3b24cf3add9sm23650165ab.62.2024.12.17.16.03.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2024 16:03:11 -0800 (PST) Message-ID: <05e4e80281850efea857982f39f6848ff5e4594b.camel@redhat.com> Subject: Re: [PATCH 19/20] KVM: selftests: Fix an off-by-one in the number of dirty_log_test iterations From: Maxim Levitsky To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Xu Date: Tue, 17 Dec 2024 19:03:10 -0500 In-Reply-To: <20241214010721.2356923-20-seanjc@google.com> References: <20241214010721.2356923-1-seanjc@google.com> <20241214010721.2356923-20-seanjc@google.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit On Fri, 2024-12-13 at 17:07 -0800, Sean Christopherson wrote: > Actually run all requested iterations, instead of iterations-1 (the count > starts at '1' due to the need to avoid '0' as an in-memory value for a > dirty page). > > Signed-off-by: Sean Christopherson > --- > tools/testing/selftests/kvm/dirty_log_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/kvm/dirty_log_test.c b/tools/testing/selftests/kvm/dirty_log_test.c > index f156459bf1ae..ccc5d9800bbf 100644 > --- a/tools/testing/selftests/kvm/dirty_log_test.c > +++ b/tools/testing/selftests/kvm/dirty_log_test.c > @@ -695,7 +695,7 @@ static void run_test(enum vm_guest_mode mode, void *arg) > > pthread_create(&vcpu_thread, NULL, vcpu_worker, vcpu); > > - for (iteration = 1; iteration < p->iterations; iteration++) { > + for (iteration = 1; iteration <= p->iterations; iteration++) { > unsigned long i; > > sync_global_to_guest(vm, iteration); Reviewed-by: Maxim Levitsky