From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from meesny.iki.fi (meesny.iki.fi [195.140.195.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEC8E51E43B; Tue, 29 Sep 2026 17:17:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=195.140.195.201 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790702249; cv=pass; b=T1VqnkQDTSUaM3QEoAdv99bcRqaeUZp0fvH2p0yI4WnmpVfpZlGrS4+7zZHdsjA2WS/XGtYrBFcS9oD1E/hh2WbgYsQwqWoJ7ldtWgNN6ijYXh+4wwCZCrwoHVNGYnDUkz4vFHg1jC8q1esaszRM1eBOa2eFtQmltWkdMFqknnk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790702249; c=relaxed/simple; bh=g/mX2HQtfr8KSlsHnS+2JZG6F4wFlWRzGJ4LmZSxx44=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=V3PNpVTkZg5kcovPy04hbORWEaoZWXm4Kwcqh3Cte/oGm6ysvsuG08N0uefl7ac+yIw9sNIB0kEK7lGtUmOMC9Fbiu7pvgUXTbsO6U8KH8QRmzv086v0uGYlzxqVfPbzNvA6zo9JMgOv1VCkdHZF1PLd3ic8FNpdISrwZJuduPU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iki.fi; spf=pass smtp.mailfrom=iki.fi; dkim=pass (1024-bit key) header.d=iki.fi header.i=@iki.fi header.b=r+df/YRs; arc=pass smtp.client-ip=195.140.195.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iki.fi Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iki.fi Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=iki.fi header.i=@iki.fi header.b="r+df/YRs" Received: from fauth-c2-smtp.messagingengine.com (fauth-c2-smtp.messagingengine.com [204.75.18.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: jmtilli) by meesny.iki.fi (Postfix) with ESMTPSA id 4hvPxQ0wJQzyS4; Tue, 29 Sep 2026 20:17:14 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1790702235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g/mX2HQtfr8KSlsHnS+2JZG6F4wFlWRzGJ4LmZSxx44=; b=r+df/YRsA7pVI3+Rdon+8jZlNIOUPnA/+7+6H8x3pa9NuTbDiK9x4JyepKgtxm4/lKe+Ws ZaJrlOo8fmWAVxucG3TByPXtYvuTueZ/YNqp4MJJpql/82AoHuydaaxVhEDLZPoffTF3J8 krXaXn7L2yN3v/PmYhZ3JmEU2qE/gIE= ARC-Seal: i=1; a=rsa-sha256; d=iki.fi; s=meesny; cv=none; t=1790702235; b=Mu1VL5vrj3uMcbw3PzdQ+pUZolf+0qqENVH8VUnhDPz/PKKL8mPvY1mVZiENVT5Rg5eayS 8SIfgom+iy5irhSD7c8SoBOYwipeT5sUj4FleYnDMxhVMV5SqbPT+zYcUJmmXrF8XEe93w sxokxTGt0ClPrJTfpXG6/OMve31ZSD4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1790702235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g/mX2HQtfr8KSlsHnS+2JZG6F4wFlWRzGJ4LmZSxx44=; b=AGbyfN7EgifukN1roQx5Cu+fSVzhxpLt2K93NBQRruNhAzEbJPhCu2LChhNwCtCUXpLgYd oy5t4j9sL6KIF+I/WLOOCGZYNaCpiPZlsqmWplJKhn814nQaQ+tJDT9L2ZToGExW1sOw/W OY8+Dh5eLC5hQ7ZFSZ2XEzzIfkD81Ro= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=jmtilli smtp.mailfrom=juha-matti.tilli@iki.fi Received: from ams-compute-02.internal (ams-compute-02.internal [10.64.2.62]) by mailfauth.ams.internal (Postfix) with ESMTP id 34A3F198003A; Tue, 29 Sep 2026 13:17:13 -0400 (EDT) Received: from ams-imap-13 ([10.64.2.33]) by ams-compute-02.internal (MEProxy); Tue, 29 Sep 2026 13:17:13 -0400 X-ME-Sender: X-ME-Proxy-Cause: dmFkZTF7vlONJhVBF2Qik9ZfiMF1TReLucmRClIJecd9pJHDGdECRkjwvH6pGdM/Z08zDE qSMwvbZPDUL5f2TaN1o6wknWrotb3N3xofMCP1XLI86bX43TDsklb0P/zrgXJxsfQ59fwV YUV6JSjK1BIobOPIG8IyqDs9k3SrGc4YQRslX/L7Z60t+T+NvUUxMynaUnfo3bIvG+ABOS q8hbcj2y6NAqdGUqUX+c3p9Y7TJtWubXM0c9JD6zI5AO6FjWe+dSSTO0zvw7T2P91mpItY RDbiN08Dod24hMoz55EhDxAv8YpfcE6oSn+3I9nYr0FdRwz5OYwEXqWDK32fZI3a0jXtAK wbJ1xfx8vaRH5PPFFpXlOy1calKFjzmf1WP8z2G5RPOv1pTDQg2SAxTlmIQJPrKtwJozLB SXYfS6kXNezJrkFjDDmg49oyLy2DIplox9Q5zJAHlC+EatceucXAQ1+VCxtkl2IK7kHske 9fKjj6Zgz4fHKS4O3Eg5jHocGxgBnIq8Hi6x0Ic1aNUCxr8NFz398zTeIMF36LYBtgMBjd GTTTggHgjw/mWaBNrhaSOUp5+GD8NqDm5/WRFt6p+hbSTe/ymVEjB90cFxllMSKZkRUl2W aC51Y+bR7E5cEAlIufpwiFtVDJNGzXUdcmPYO/EHHmTm1s0NgWfQXxB3jw3w X-ME-Proxy: Feedback-ID: i02414972:Fastmail Received: by mailuser.ams.internal (Postfix, from userid 501) id 34538F8008B; Tue, 29 Sep 2026 13:17:10 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: A0G5p0OZ_htJ Date: Tue, 29 Sep 2026 20:16:50 +0300 From: "Juha-Matti Tilli" To: "Marcel Holtmann" , "Deepak Kumar Singh" Cc: "Manivannan Sadhasivam" , "Manivannan Sadhasivam" , "David S . Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Simon Horman" , "Jeff Johnson" , linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, "Bjorn Andersson" , "Chris Lew" , "Raj Kumar Bhagat" , "Jeff Hugo" Message-Id: <05e539f8-bb7c-4038-8a83-8ab0d1a5b917@app.fastmail.com> In-Reply-To: <13BFC5B0-77E6-48F2-B857-37686EA1DB2C@holtmann.org> References: <20260922-qrtr-multi-ep-v3-0-c00831e88957@oss.qualcomm.com> <20260922-qrtr-multi-ep-v3-2-c00831e88957@oss.qualcomm.com> <7aed969d-0868-4c9c-967e-7766dbba427e@oss.qualcomm.com> <13BFC5B0-77E6-48F2-B857-37686EA1DB2C@holtmann.org> Subject: Re: [PATCH v3 2/4] net: qrtr: Assign unique node id for MHI endpoints Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Sep 29, 2026, at 20:05, Marcel Holtmann wrote: > >> +#define QRTR_NODE_HOST_BASE 0x10000u > >=20 > > Can it be exposed with include/uapi/linux/qrtr.h also. There are use= r space clients like modem manager > > which need to calculate modified node id to distinguish same service= from multi modem over mhi. > > This is same as wlan use case. >=20 > did anybody actually looked at the proposal that Denis and I came up w= ith. It was exactly addressing this properly. >=20 > It seems you guys came up with some hot fix and want to run with it. A= fter month and month of silence and not bothering to review the proposal= , you are trying to push your thing? >=20 > If you don=E2=80=99t support userspace, your proposal is broken. Plain= and simple. I'm still willing to submit a new version of that patchset originally by Denis, if the kernel devs so decide that it's the way. For example, the "radix tree of radix trees" approach could be replaced with a hash table. There was also some criticism about a layering violation in storing the endpoint id to mhi controller. However, maybe that could be reduced by providing a correct abstraction around it, so that other code doesn't touch the mhi controller structure directly. Other criticism for that patchset by Denis was its overt complexity. Yes, it has more lines of code changed. This dual-card setup needs to be handled somehow, either by Denis's patchset or by Manivannan's patchset. BR, Juha-Matti