From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99389C4167B for ; Fri, 25 Nov 2022 11:30:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229783AbiKYLah (ORCPT ); Fri, 25 Nov 2022 06:30:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbiKYLaf (ORCPT ); Fri, 25 Nov 2022 06:30:35 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DCBB175AC for ; Fri, 25 Nov 2022 03:29:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669375776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s7B+glXPiHunh65c3ikcxd5Un328udBU6gxH6BbvNec=; b=Jm6VZNRUHvH1Hj/BvNFJCUh780V+BESN1f52M2RDzOeYvy5pMMKsIIvdIHMy8uvAWDsUtv w4vba3f+GvFSI4LFk0ZywW3GkssRHbAHCsOvp1fEfsuKc/uScdxQXjG+D07ibmnE+HH2uD 0Vh0GXsBzOODWn1aNAiCZ9q0p2wiLBY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-482-v6BxeaeXO2-mtveGq_Daug-1; Fri, 25 Nov 2022 06:29:33 -0500 X-MC-Unique: v6BxeaeXO2-mtveGq_Daug-1 Received: by mail-wm1-f70.google.com with SMTP id m17-20020a05600c3b1100b003cf9cc47da5so2296106wms.9 for ; Fri, 25 Nov 2022 03:29:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s7B+glXPiHunh65c3ikcxd5Un328udBU6gxH6BbvNec=; b=3Snb+lFthG4KZp5BDNjj5Z5vlr0TCQvzZTf6gg46X9gqgAFyH4m02+uH8JFkwnrs6v mMCBqHXfwqctheSemfoZ+llWIUy/nWRI6nlN+elqX/4akzhJfUS7Q6oUrRpjzBBJuedt GZknkNQ89TJZjoVo1KLqSTDbg5Tyrc65yPRBIE9gh3R3m0WAG7JLysyU4W2hAeoWUTre jt5twSSbqzy9DA8wO3G1Gsai246sfmyhyH1GbY2J+KJe4K3o4X95r5XBeZXV/+PLiO0g nAZexeMz78lA9Md6cW3e9mWiK0yeah5MTvUIjXR0RRjwNBBSnM+Xagu9VVw9VIvl5I3d +5aQ== X-Gm-Message-State: ANoB5pmwjtxv5OIQ+oyomTbAUS/n686BxIoAWwVE9zwMvgF0s5ZTWsIB g0IKO46ByX2LrQy60tfftMtJ/dbOFL7F1+4Y8xChrwypQAb02WgOeXzNNfLmdelU+XKHpKjtMR9 HGdqVCyTPmXZE1rURmbAc0Lkg X-Received: by 2002:a1c:4c0c:0:b0:3cf:9881:e9d9 with SMTP id z12-20020a1c4c0c000000b003cf9881e9d9mr27524185wmf.6.1669375772042; Fri, 25 Nov 2022 03:29:32 -0800 (PST) X-Google-Smtp-Source: AA0mqf4tA122+galS8pDRgP2Y6iWuz67WbLgxFBL4oNYp0k+u30rTmKQtH54GX28s3piYeICYXfz4g== X-Received: by 2002:a1c:4c0c:0:b0:3cf:9881:e9d9 with SMTP id z12-20020a1c4c0c000000b003cf9881e9d9mr27524167wmf.6.1669375771857; Fri, 25 Nov 2022 03:29:31 -0800 (PST) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id r14-20020a5d4e4e000000b002366ded5864sm3471722wrt.116.2022.11.25.03.29.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 03:29:30 -0800 (PST) Message-ID: <05e6a16f-ee7f-1b9a-0ab8-5b042d60c86d@redhat.com> Date: Fri, 25 Nov 2022 12:29:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 18/24] drm/vc4: crtc: Introduce a lower-level crtc init helper Content-Language: en-US To: Maxime Ripard , Maxime Ripard , Maarten Lankhorst , Daniel Vetter , David Airlie , Thomas Zimmermann Cc: David Gow , linaro-mm-sig@lists.linaro.org, Greg Kroah-Hartman , linux-kselftest@vger.kernel.org, =?UTF-8?Q?Ma=c3=adra_Canal?= , linux-media@vger.kernel.org, kunit-dev@googlegroups.com, dri-devel@lists.freedesktop.org, Brendan Higgins , linux-kernel@vger.kernel.org, Dave Stevenson References: <20221123-rpi-kunit-tests-v1-0-051a0bb60a16@cerno.tech> <20221123-rpi-kunit-tests-v1-18-051a0bb60a16@cerno.tech> From: Javier Martinez Canillas In-Reply-To: <20221123-rpi-kunit-tests-v1-18-051a0bb60a16@cerno.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/23/22 16:26, Maxime Ripard wrote: > The current vc4_crtc_init() helper assumes that we will be using > hardware planes and calls vc4_plane_init(). > > While it's a reasonable assumption, we'll want to mock the plane and > thus provide our own. Let's create a helper that will take the plane as > an argument. > > Signed-off-by: Maxime Ripard > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat