mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Divya.Koppera@microchip.com
Cc: Arun.Ramadoss@microchip.com, UNGLinuxDriver@microchip.com,
	hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	richardcochran@gmail.com, vadim.fedorenko@linux.dev
Subject: Re: [PATCH net-next v5 3/5] net: phy: Kconfig: Add ptp library support and 1588 optional flag in Microchip phys
Date: Thu, 5 Dec 2024 15:35:40 +0100	[thread overview]
Message-ID: <05eecef6-f6be-4fcd-9896-df4e04bbde19@lunn.ch> (raw)
In-Reply-To: <CO1PR11MB4771EDCFF242B8D8E5A0A1E0E2302@CO1PR11MB4771.namprd11.prod.outlook.com>

> > And has Microchip finial decided not to keep reinventing the wheel, and there
> > will never be a new PHY implementation? I ask, because what would its
> > KCONFIG symbol be?
> > 
> 

> For all future Microchip PHYs PTP IP will be same, hence the
> implementation and kconfig symbol is under MICROCHIP_PHYPTP to keep
> it more generic.

So you would be happy for me to NACK all new PHY PTP implementations?

Are you management happy with this statement?

Even if they are, i still think you need a less generic KCONFIG
symbol, i doubt somebody somewhere in Microchip can resist making yet
another PTP implementation.

	Andrew

  reply	other threads:[~2024-12-05 14:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-03  8:52 [PATCH net-next v5 0/5] Add ptp library for " Divya Koppera
2024-12-03  8:52 ` [PATCH net-next v5 1/5] net: phy: microchip_ptp : Add header file for Microchip ptp library Divya Koppera
2024-12-03  8:52 ` [PATCH net-next v5 2/5] net: phy: microchip_ptp : Add ptp library for Microchip phys Divya Koppera
2024-12-05  9:47   ` Paolo Abeni
2024-12-05 11:00     ` Divya.Koppera
2024-12-05 11:07       ` Paolo Abeni
2024-12-05 11:26         ` Divya.Koppera
2024-12-03  8:52 ` [PATCH net-next v5 3/5] net: phy: Kconfig: Add ptp library support and 1588 optional flag in " Divya Koppera
2024-12-04  1:39   ` Andrew Lunn
2024-12-04 15:47     ` Divya.Koppera
2024-12-04 16:02       ` Andrew Lunn
2024-12-04 16:09         ` Russell King (Oracle)
2024-12-05  6:04         ` Divya.Koppera
2024-12-05 14:35           ` Andrew Lunn [this message]
2024-12-06 11:30             ` Divya.Koppera
2024-12-03  8:52 ` [PATCH net-next v5 4/5] net: phy: Makefile: Add makefile support for ptp " Divya Koppera
2024-12-03  8:52 ` [PATCH net-next v5 5/5] net: phy: microchip_t1 : Add initialization of ptp for lan887x Divya Koppera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05eecef6-f6be-4fcd-9896-df4e04bbde19@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Arun.Ramadoss@microchip.com \
    --cc=Divya.Koppera@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®