From: James Bottomley <jejb@linux.ibm.com>
To: Deepak R Varma <drv@mailo.com>
Cc: Khalid Aziz <khalid@gonehiking.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Saurabh Singh Sengar <ssengar@microsoft.com>,
Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH] scsi: FlashPoint: Replace arithmetic addition by bitwise OR
Date: Tue, 07 Feb 2023 22:25:09 +0300 [thread overview]
Message-ID: <05eed3d8321d0f355bf3dc59ffea3d6ab08135fa.camel@linux.ibm.com> (raw)
In-Reply-To: <Y+KOeP0OOiem3lR5@ubun2204.myguest.virtualbox.org>
On Tue, 2023-02-07 at 23:16 +0530, Deepak R Varma wrote:
[...]
> James, there are a few other patch submissions for the scsi subsystem
> that I submitted in last few weeks. I sent couple of reminder request
> for comments on those submission, but still waiting. Could you please
> also review those and share your feedback?
The problem is basically that they don't fix a bug or introduce an
enhancement. Review bandwidth in SCSI is the main limiting factor for
any new patch, so we tend to concentrate on these two types. The main
problem with code replacement patches is that they do tend to introduce
inadvertent bugs in old drivers, which is why people are afraid to
review them. You can reduce the overhead of review by demonstrating
that the binary produced is unchanged (obviously this works for some
but not all of your patches), so a maintainer need only decide if they
like the change rather than worrying about it introducing a regression.
Regards,
James
next prev parent reply other threads:[~2023-02-07 19:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 11:21 Deepak R Varma
2023-02-07 12:26 ` James Bottomley
2023-02-07 15:28 ` Khalid Aziz
2023-02-07 17:48 ` Deepak R Varma
2023-02-07 17:46 ` Deepak R Varma
2023-02-07 19:25 ` James Bottomley [this message]
2023-02-07 20:19 ` Martin K. Petersen
2023-02-09 7:32 ` Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05eed3d8321d0f355bf3dc59ffea3d6ab08135fa.camel@linux.ibm.com \
--to=jejb@linux.ibm.com \
--cc=drv@mailo.com \
--cc=khalid@gonehiking.org \
--cc=kumarpraveen@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ssengar@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®