From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756918AbbJID6c (ORCPT ); Thu, 8 Oct 2015 23:58:32 -0400 Received: from out4133-98.mail.aliyun.com ([42.120.133.98]:42186 "EHLO out4133-98.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751094AbbJID6b (ORCPT ); Thu, 8 Oct 2015 23:58:31 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R741e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e02c03283;MF=hillf.zj@alibaba-inc.com;NM=1;PH=DS;RN=6;SR=0; Reply-To: "Hillf Danton" From: "Hillf Danton" To: "Sergei Zviagintsev" Cc: "'Greg Kroah-Hartman'" , "'Daniel Mack'" , "'David Herrmann'" , "'Djalal Harouni'" , "'linux-kernel'" References: <05f401d10246$1a881ff0$4f985fd0$@alibaba-inc.com> In-Reply-To: <05f401d10246$1a881ff0$4f985fd0$@alibaba-inc.com> Subject: Re: [PATCH 10/44] kdbus: Use conditional operator Date: Fri, 09 Oct 2015 11:58:08 +0800 Message-ID: <05f501d10246$b5cd9350$2168b9f0$@alibaba-inc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQIhnj3+WSxR82sHj4CtScxpVzclz53BT8SQ Content-Language: zh-cn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Signed-off-by: Sergei Zviagintsev > --- > ipc/kdbus/names.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/ipc/kdbus/names.c b/ipc/kdbus/names.c > index bf44ca3f12b6..6b31b38ac2ad 100644 > --- a/ipc/kdbus/names.c > +++ b/ipc/kdbus/names.c > @@ -438,10 +438,7 @@ static void kdbus_name_release_unlocked(struct kdbus_name_owner *owner) > name->activator = NULL; > > if (!primary || owner == primary) { > - next = kdbus_name_entry_first(name); > - if (!next) > - next = name->activator; > - > + next = kdbus_name_entry_first(name) ?: name->activator; Fix? Cleanup? What we gain, given no log message? > if (next) { > /* hand to next in queue */ > next->flags &= ~KDBUS_NAME_IN_QUEUE; > -- > 1.8.3.1 > >