From: Marek Vasut <marex@denx.de>
To: Christoph Niedermaier <cniedermaier@dh-electronics.com>,
linux-arm-kernel@lists.infradead.org
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawnguo@kernel.org>, Li Yang <leoyang.li@nxp.com>,
Fabio Estevam <festevam@denx.de>,
NXP Linux Team <linux-imx@nxp.com>,
kernel@dh-electronics.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: imx6ull-dhcor: Add Marantec maveo box
Date: Wed, 5 Apr 2023 18:25:21 +0200 [thread overview]
Message-ID: <05fa147c-116b-59b4-d14b-760bbefd7602@denx.de> (raw)
In-Reply-To: <20230405160258.46998-2-cniedermaier@dh-electronics.com>
On 4/5/23 18:02, Christoph Niedermaier wrote:
[...]
> +/ {
> + model = "DH electronics i.MX6ULL DHCOR on maveo box";
> + compatible = "dh,imx6ull-dhcor-maveo-box", "dh,imx6ull-dhcor-som",
> + "fsl,imx6ull";
> +
> + aliases {
> + /delete-property/ mmc0; /* Avoid double definitions */
> + /delete-property/ mmc1;
> + mmc2 = &usdhc2; /* eMMC should be mmc2 */
Why not mmc0 ?
Use root=PARTUUID= when booting to avoid any dependency on
root=/dev/mmcblk2pN enumeration.
> + spi0 = &ecspi4;
> + spi3 = &ecspi1;
> + };
[...]
> +&iomuxc {
> + pinctrl-0 = <&pinctrl_hog_maveo_box>;
> + pinctrl-names = "default";
> +
> + pinctrl_hog_maveo_box: hog-maveo-box-grp {
> + fsl,pins = <
> + MX6UL_PAD_GPIO1_IO05__GPIO1_IO05 0x400120b0 /* BUTTON_USER */
> + MX6UL_PAD_GPIO1_IO08__GPIO1_IO08 0x400120b0 /* BUTTON_RESET */
> + MX6UL_PAD_CSI_PIXCLK__GPIO4_IO18 0x400120b0 /* LED_G */
> + MX6UL_PAD_CSI_DATA02__GPIO4_IO23 0x400120b0 /* LED_B */
Should the "SION(1 << 30): Software Input On Field." bit really be set
on GPIOs which are OUTPUT (like LEDs) ?
[...]
next prev parent reply other threads:[~2023-04-05 16:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 16:02 [PATCH 1/2] dt-bindings: arm: fsl: Add Marantec maveo box as a DHCOR i.MX6ULL SoM based board Christoph Niedermaier
2023-04-05 16:02 ` [PATCH 2/2] ARM: dts: imx6ull-dhcor: Add Marantec maveo box Christoph Niedermaier
2023-04-05 16:25 ` Marek Vasut [this message]
2023-04-05 18:24 ` Christoph Niedermaier
2023-04-05 18:46 ` Marek Vasut
2023-04-06 8:37 ` Christoph Niedermaier
2023-04-06 14:10 ` Marek Vasut
2023-04-06 15:44 ` Christoph Niedermaier
2023-04-06 16:04 ` Marek Vasut
2023-04-06 16:36 ` Krzysztof Kozlowski
2023-04-06 17:32 ` Marek Vasut
2023-04-06 18:03 ` Krzysztof Kozlowski
2023-04-05 16:26 ` [PATCH 1/2] dt-bindings: arm: fsl: Add Marantec maveo box as a DHCOR i.MX6ULL SoM based board Marek Vasut
2023-04-05 18:13 ` Christoph Niedermaier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05fa147c-116b-59b4-d14b-760bbefd7602@denx.de \
--to=marex@denx.de \
--cc=cniedermaier@dh-electronics.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=kernel@dh-electronics.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®