From: Guenter Roeck <linux@roeck-us.net>
To: Ivy Lopez <skunkolee@gmail.com>, marius.cristea@microchip.com
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: emc1812: reject channel index 0 in device tree config
Date: Wed, 15 Jul 2026 17:34:36 -0700 [thread overview]
Message-ID: <05fd58a3-ba71-49e9-afd8-c31a17c9e3bb@roeck-us.net> (raw)
In-Reply-To: <20260716002543.26711-1-skunkolee@gmail.com>
On 7/15/26 17:25, Ivy Lopez wrote:
> Channel index 0 is reserved for the internal diode and is set
> unconditionally before parsing child nodes. If a child node specifies
> reg = 0, it silently overwrites the internal diode label
>
The label string "internal_diode" is completely meaningless.
If anything, it should be dropped. I see it as a good thing,
not as a bug, that it can be overwritten.
NACK.
Guenter
prev parent reply other threads:[~2026-07-16 0:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 0:25 Ivy Lopez
2026-07-16 0:34 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05fd58a3-ba71-49e9-afd8-c31a17c9e3bb@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marius.cristea@microchip.com \
--cc=skunkolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®