From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751423AbdJ2MEH (ORCPT <rfc822;w@1wt.eu>);
        Sun, 29 Oct 2017 08:04:07 -0400
Received: from mout.web.de ([212.227.15.4]:53430 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750928AbdJ2MEE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 29 Oct 2017 08:04:04 -0400
Subject: Re: [PATCH] sr9800: Use common error handling code in
 sr9800_phy_powerup()
To: Geert Uytterhoeven <geert@linux-m68k.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        linux-usb@vger.kernel.org
Cc: =?UTF-8?Q?Bj=c3=b8rn_Mork?= <bjorn@mork.no>,
        "David S. Miller" <davem@davemloft.net>,
        Greg Ungerer <gerg@linux-m68k.org>,
        Liu Junliang <liujunliang_ljl@163.com>,
        Philippe Reynes <tremyfr@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <10f2b5a4-1dbd-2c4f-caaa-4225dff35296@users.sourceforge.net>
 <CAMuHMdU6K+KPZvsStfwPev9Z5v1RRYAwLr04FHjmeC=VUEMC+Q@mail.gmail.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <0600e4f9-dd53-158c-556b-8a87dfc928e6@users.sourceforge.net>
Date: Sun, 29 Oct 2017 13:03:41 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAMuHMdU6K+KPZvsStfwPev9Z5v1RRYAwLr04FHjmeC=VUEMC+Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:0gA5Tl0v7ILdGopKzvombeOV3jzBS96027gNmHKvNdOn+RhOxUB
 NOzLFpU+eznCDqs+BDUAi+qreo9j83O4R4kwwoL4903kd3jORnLLYko/WS7XA6V57YfH1cg
 MYZKwzByODxK+DpKrbMypxL4BEw0LyZMzHxhQtzUGtUA1IOeDGV09oiyNxiQDXvLqXwa5bm
 dCEkXrQ9s0oYbLLwxTMug==
X-UI-Out-Filterresults: notjunk:1;V01:K0:pK3a4gLhAMs=:l8IkjFh2my23s190OnjSum
 mTY9G99L9RA6DpqCYQW5+r/wa6FFLMEBoUnIPsmMvOy77jSV5DbtUOtIlr/JDb5kJenrTcJ96
 unJ+Oo5+MTEM2zq9XsZnifTsCXPLBVn+oY/F+6viVRG0UPhPQBSzo1QJPJ9UR4i8ZU1atB20M
 +ap2k2AuiQwd4qv/GwmK3tQ/8JZA0FCbLFrRMQ8Ai9QkwpDG3yuOm71ebB8Va3wv6thvt0u3J
 zUSk2TLPgN7n0WjEC8Mq4dvtiBuZGlo0q06/SAbSEz2fjLA3DzlQIfHSfG/eTeI+0T20ZqOWz
 r/2Rs0q+on42+rOtT2x30KV7t7YcRm1viysibzOlwO+opmH6waf4mtskvmkbmFreeg/dFE8Tm
 k0L3+f4CeaEvTothgg2VVJSygduwDRGzxLt67xKGHxuGkTrXb28PfWtwvLE0RZFjK96YUUXIS
 IdbMbwjVK4QhxUK+Ek6IDQrR2WXeT6kZcDp6TtAcow51gxl7UmEz3xnutpgmdqZ8hmSsIaE2Y
 mPzqMsXjilac3ehmNKp0R9zFR+FWHBOBj1x3UJ/i/qVUmnQFpydMtO33bgAmwaJUMWMzimbgH
 JEK4jlo1vWiDLwWAVLFI8WdymcQdV/bHj6CVPZKBf042uUNyFX5iHtYnMVb8XFjlTtRPOxfbz
 pfBk3KWDYbImhZfOwuCDjxK2x7JP4xFAtO+oTVSflbK1+lWN5ALZjt0nV0jWPzFB6D13WM4lU
 IbGBtoDWabhNMCCM4hFAKDBe4JGDIdxHuxhpGsYc8X0HhVubUA0skvPATTSFGeexkbVsGAe7W
 E8MR00iUlRzvGJMCTDYOTQJP8GqjqBXpXPbVEJ+XFJOFrPxEjw=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -700,10 +700,9 @@ static int sr9800_phy_powerup(struct usbnet *dev)
>>
>>         /* set the embedded Ethernet PHY in power-up state */
>>         ret = sr_sw_reset(dev, SR_SWRESET_IPRL);
>> -       if (ret < 0) {
>> -               netdev_err(dev->net, "Failed to reset PHY: %d\n", ret);
>> -               return ret;
>> -       }
>> +       if (ret < 0)
>> +               goto report_reset_failure;
> 
> So now I have to look below to see what error handling it does...

Yes. - Can this be an usual consequence if you apply information from
the section “7) Centralized exiting of functions” in the document
“coding-style.rst” a bit more?



> Hence I prefer the original version, which had _less_ lines of code...

My update suggestion is only one line “bigger” in this case, isn't it?

I propose an other source code layout so that a bit smaller executable
object code could be achieved.
Do find such a software design direction feasible?

Regards,
Markus