From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: masonccyang@mxic.com.tw
Cc: bbrezillon@kernel.org, broonie@kernel.org,
devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms@verge.net.au>,
juliensu@mxic.com.tw, lee.jones@linaro.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-spi@vger.kernel.org, marek.vasut@gmail.com,
mark.rutland@arm.com, robh+dt@kernel.org, zhengxunli@mxic.com.tw
Subject: Re: [PATCH v11 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver
Date: Tue, 23 Apr 2019 19:09:22 +0300 [thread overview]
Message-ID: <060316c8-7675-cfaf-bfef-c3e6458bfa82@cogentembedded.com> (raw)
In-Reply-To: <OFF96C004A.0EFDDD69-ON482583E5.0032EE18-482583E5.00337F42@mxic.com.tw>
On 04/23/2019 12:22 PM, masonccyang@mxic.com.tw wrote:
>> > Add a driver for Renesas R-Car Gen3 RPC-IF SPI controller.
>> >
>> > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
>> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> [...]
>>
>> Do dote that I'm opposed to the driver separation as it's presented in
>> this patches, and I have a large patch reworking both MFD and SPI drivers
>> in the works.
>>
>
> Do you mean add your name in both MFD & dt-binding ?
Of course not!
> i.e.,
> [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings
>
> Document the bindings used by the Renesas R-Car Gen3 RPC-IF MFD.
>
> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
>
>
> [PATCH v12 1/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD driver
>
> Add a driver for Renesas R-Car Gen3 RPC-IF MFD.
>
> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
>
> Is it ok ?
I'm not OK with the most of the driver code ending up in the SPI driver,
I think most of the code should be kept in the MFD driver and just be called
by SPI/HF drivers.
> best regards,
> Mason
MBR, Sergei
next prev parent reply other threads:[~2019-04-23 16:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 3:32 [PATCH v11 0/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD & SPI driver Mason Yang
2019-04-22 3:32 ` [PATCH v11 1/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD driver Mason Yang
2019-04-22 3:32 ` [PATCH v11 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver Mason Yang
2019-04-22 18:32 ` Sergei Shtylyov
2019-04-22 19:00 ` Sergei Shtylyov
[not found] ` <OFF96C004A.0EFDDD69-ON482583E5.0032EE18-482583E5.00337F42@mxic.com.tw>
2019-04-23 16:09 ` Sergei Shtylyov [this message]
2019-04-22 3:32 ` [PATCH v11 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings Mason Yang
2019-04-22 11:45 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=060316c8-7675-cfaf-bfef-c3e6458bfa82@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=juliensu@mxic.com.tw \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=masonccyang@mxic.com.tw \
--cc=robh+dt@kernel.org \
--cc=zhengxunli@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®