From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F39B42D9485 for ; Wed, 15 Oct 2025 08:24:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760516666; cv=none; b=OtTSGEDVDWfen0bI6YwL35UDIGciB7yQp/SlLvsp4cdcZi//35vN+2ms2od23I4nKLoCyn283AgiNkzYFdzpXljm4q10NCHyLZd8WrXx9b8bCI701PI3kVU83gTzCDg2T/C7gbAOL4OFTYFjxSESzGVCOfmz8vH2voiXziK1o/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760516666; c=relaxed/simple; bh=KxWKmiu9Rjq1K6P3jRxYwsFZIUByeyZ59tHsbEg2yjE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kf/NUAta9A+7GKYEIV9qZ5BHPbBbi9MS29eyNyPMz8LtyyLaTyo0eUzI54n4NRQD0NwJ29TRfkeLQzXLsvaMjBK7EHXolYqJjPqLwEnHwqZG5KjIbZvK3VAIDDmkOGJ5V8KllRKlxF0j9aIloh3m6kZaMaX13sMaldqqmpTnwHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UWrYX04b; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UWrYX04b" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-b3f5e0e2bf7so1167642066b.3 for ; Wed, 15 Oct 2025 01:24:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760516663; x=1761121463; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TtE/vZEnFRO/O0aDzTmOM5exa4aoLNDYIYIf8N0xWSo=; b=UWrYX04bzyITFxVRkRV21xGHmLGQ9ozgyijXXGsaZ6q9eOYagkQovXkZTCq+qrlyI1 DAD2pPpF7WHyPX/GVm4q4QBf0MR9/P0zu574oi+fzy5mUHsCVpahBeOYfalCftNgoS5S 7NvUxDi3jJcRQTOlLizX/1W+oQZn9G+qVLztGr6JN4CtpZrqQVsG7gEi67C6m5cw2f4X Hp/CgEV8kYdOpFrx2ppjhh718rFr3x4F4J4cNBq+WEGYQ7WCF3Q0lRahC/QvnpD95NEn 0DJlPXYNUAiUpv/+hVN2zyurfYqaC0FwuKZAJdpKqKSARiFSk4r3ooV0UejoN//fIwSo QqAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760516663; x=1761121463; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TtE/vZEnFRO/O0aDzTmOM5exa4aoLNDYIYIf8N0xWSo=; b=OOOLdlFzhgd11mTAoDlbuZ0F2GoOYzmdQEXSo74xITC1EtsDgCIcZmMGPSEfP7dZYJ pLB6heUoXJyifc+g7EK/sZVIlUHc5GjoN1DIvnB4Krw8VxMzf6wtWPrSjf+bTssHL0xN 7mKCOG5O2dCpJaEVRPhfb3/K1PciMBzm/v4Xi/CDDbdrNFHPToSAJ8swN0K7VXJxq73S ZWcp9bF+czNKNCSAkNUjHnHqZ9Y6+nnB+IJmQ6W91N+HNO217/efRagR6k21K+rdOyE/ j6++Myw5txXvnsEdfBjkg6PlGSpkGH13ATG1uqqaNtgeVycQxtlEv2yI2pX3UB+UVLgJ lsqQ== X-Forwarded-Encrypted: i=1; AJvYcCUIx7pRuNbvBMbVAuFkYh2797rQQ89OSDAaHdiOpsXr3di8EbrYtM9a1CsuC6tXxnRV4fYKQt6Jn80F0vk=@vger.kernel.org X-Gm-Message-State: AOJu0YwMI7Nppnp9l58EYcYGIJp+Ov3xkRh33HHuFLrCCpZ/tkiw6Hvt 8YJzVViSc0rIY4Lq1iyhlhlvvpYvoXkJOM2gGM2klFbWNklDx8HHdtH7ZfXUTkN3brE= X-Gm-Gg: ASbGncs8aYAXdBdq+ii8anW/xEjIsKAowDCh1+GhWJk9sv+5PQ1JYIZ64emD088a3Ja Rwnm29nJbp/B9BbsVLdkrPK2HdE3h8bEaOCP/AmTCovWb4mPpwevvYFDQ5P/Vu7RnMmkZGG9dRz /3Up6FThPxpJ6KT5MYmewKuYBx/E9lO+e0xaRS7IzDstv/NmTHcF2tngi/lzbc5W+oVnkzMA71m cFN9VBwURWTW1YiESkziiRMEQSjE7WnYheanVceGSMiCpXsqNyec38JFq/FzpKTMJ/xAzr90XoM 0Q36st6XflqUcWl8SmKSRh7oPoW825XCtUgT3+JZ7ATd61ErVhOAhtarP4lWqchIPhxymij49FZ iF1N/U+2rtUFxjjDIjW/aAg47mqCtgfDy7iPXhzXv66nHvtRy+rei/FiyRA9wWvhHZMjHHDCATk zaTEYCUYfeLclFnC237sDgZQ== X-Google-Smtp-Source: AGHT+IGevrv/qqYOxvgpm3B6QvO6hWcybEKVbjZIiQDfLWE4gSlzL7mBitr4uu2g2PmlFXgFdhalWg== X-Received: by 2002:a17:907:934d:b0:b32:8943:7884 with SMTP id a640c23a62f3a-b50abfd6a1fmr2836258966b.45.1760516663245; Wed, 15 Oct 2025 01:24:23 -0700 (PDT) Received: from [192.168.0.19] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b5cb9e813acsm169952566b.27.2025.10.15.01.24.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Oct 2025 01:24:22 -0700 (PDT) Message-ID: <06043c1b-b261-4469-b897-66e8173588ab@linaro.org> Date: Wed, 15 Oct 2025 09:24:21 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: qcom: camss: Use a macro to specify the initial buffer count To: Hangxiang Ma , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <20251014-use-marco-to-denote-image-buffer-number-v1-1-f782e4cc622d@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20251014-use-marco-to-denote-image-buffer-number-v1-1-f782e4cc622d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/10/2025 03:42, Hangxiang Ma wrote: > Replace the hardcoded buffer count value with a macro to enable > operating on these buffers elsewhere in the CAMSS driver based on this > count. Some of the hardware architectures require deferring the AUP and > REG update until after the CSID configuration and this macro is expected > to be useful in such scenarios. > > Signed-off-by: Hangxiang Ma > --- > This change use a global macro to specify the initial buffer count. It > meets the requirement that some hardware architectures need to defer the > AUP and REG update to CSID configuration stage. > --- > drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- > drivers/media/platform/qcom/camss/camss.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c > index 09b29ba383f1..2753c2bb6c04 100644 > --- a/drivers/media/platform/qcom/camss/camss-vfe.c > +++ b/drivers/media/platform/qcom/camss/camss-vfe.c > @@ -541,7 +541,7 @@ int vfe_enable_output_v2(struct vfe_line *line) > > ops->vfe_wm_start(vfe, output->wm_idx[0], line); > > - for (i = 0; i < 2; i++) { > + for (i = 0; i < CAMSS_INIT_BUF_COUNT; i++) { > output->buf[i] = vfe_buf_get_pending(output); > if (!output->buf[i]) > break; > diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h > index a70fbc78ccc3..901f84efaf7d 100644 > --- a/drivers/media/platform/qcom/camss/camss.h > +++ b/drivers/media/platform/qcom/camss/camss.h > @@ -41,6 +41,7 @@ > (to_camss_index(ptr_module, index)->dev) > > #define CAMSS_RES_MAX 17 > +#define CAMSS_INIT_BUF_COUNT 2 > > struct camss_subdev_resources { > char *regulators[CAMSS_RES_MAX]; > > --- > base-commit: 59a69ef338920ca6a5bca3ec0e13ce32809cea23 > change-id: 20251012-use-marco-to-denote-image-buffer-number-cbec071b8436 > > Best regards, Reviewed-by: Bryan O'Donoghue