mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Russell King" <linux@arm.linux.org.uk>,
	"Russell King" <linux@armlinux.org.uk>
Cc: <devicetree@vger.kernel.org>, <letux-kernel@openphoenux.org>,
	<linux-kernel@vger.kernel.org>, <ldewangan@nvidia.com>,
	<kernel@pyra-handheld.com>, <marek@goldelico.com>,
	<linux-omap@vger.kernel.org>
Subject: Re: [PATCH resent v3 2/3] dts: omap5: board-common: enable twl6040 headset jack detection
Date: Wed, 26 Oct 2016 11:02:14 +0300	[thread overview]
Message-ID: <06084abe-015a-ed84-2ce3-779be5744773@ti.com> (raw)
In-Reply-To: <b918b86fd1d1f7e6fb2c15bb507b84d5cf1f0d3e.1477417090.git.hns@goldelico.com>

On 10/25/16 20:38, H. Nikolaus Schaller wrote:
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>

I'm not sure if this is valid for igep0500 as I have not seen the schematics.
It might be safer to enable the jack detection only for omap5-uevm?

In any case:
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> ---
>  arch/arm/boot/dts/omap5-board-common.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi
> index b04adee..ab60a8e 100644
> --- a/arch/arm/boot/dts/omap5-board-common.dtsi
> +++ b/arch/arm/boot/dts/omap5-board-common.dtsi
> @@ -124,6 +124,7 @@
>  		compatible = "ti,abe-twl6040";
>  		ti,model = "omap5-uevm";
>  
> +		ti,jack-detection;
>  		ti,mclk-freq = <19200000>;
>  
>  		ti,mcpdm = <&mcpdm>;
> 


-- 
Péter

  reply	other threads:[~2016-10-26  8:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25 17:38 [PATCH resent v3 0/3] DT Fixes for OMAP5 boards H. Nikolaus Schaller
2016-10-25 17:38 ` [PATCH resent v3 1/3] dts: omap5: board-common: add phandle to reference Palmas gpadc H. Nikolaus Schaller
2016-10-25 17:38 ` [PATCH resent v3 2/3] dts: omap5: board-common: enable twl6040 headset jack detection H. Nikolaus Schaller
2016-10-26  8:02   ` Peter Ujfalusi [this message]
2016-10-28 13:11     ` Tony Lindgren
2016-10-25 17:38 ` [PATCH resent v3 3/3] ASoC: omap-abe-twl6040: fix typo in bindings documentation H. Nikolaus Schaller
2016-10-26  7:59   ` Peter Ujfalusi
2016-10-31  3:07   ` Rob Herring
2016-11-07 23:29     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06084abe-015a-ed84-2ce3-779be5744773@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=hns@goldelico.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kernel@pyra-handheld.com \
    --cc=ldewangan@nvidia.com \
    --cc=letux-kernel@openphoenux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=linux@armlinux.org.uk \
    --cc=marek@goldelico.com \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®