From: Jesper Dangaard Brouer <hawk@kernel.org>
To: Meghana Malladi <m-malladi@ti.com>,
dan.carpenter@linaro.org, john.fastabend@gmail.com,
daniel@iogearbox.net, ast@kernel.org, pabeni@redhat.com,
kuba@kernel.org, edumazet@google.com, davem@davemloft.net,
andrew+netdev@lunn.ch
Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
srk@ti.com, Vignesh Raghavendra <vigneshr@ti.com>,
Roger Quadros <rogerq@kernel.org>,
danishanwar@ti.com
Subject: Re: [PATCH net 0/4] Bug fixes from XDP patch series
Date: Fri, 2 May 2025 09:16:08 +0200 [thread overview]
Message-ID: <0608a65d-f657-4ef3-aeea-7b2664aa7625@kernel.org> (raw)
In-Reply-To: <20250428120459.244525-1-m-malladi@ti.com>
On 28/04/2025 14.04, Meghana Malladi wrote:
> This patch series fixes the bugs introduced while adding
> xdp support in the icssg driver, and were reproduced while
> running xdp-trafficgen to generate xdp traffic on icssg interfaces.
>
This patchset clearly hurts performance by introducing a lot of locking.
Can you please report what the performance regressions this is introducing?
> Meghana Malladi (4):
> net: ti: icssg-prueth: Set XDP feature flags for ndev
> net: ti: icssg-prueth: Report BQL before sending XDP packets
> net: ti: icssg-prueth: Fix race condition for traffic from different
> network sockets
> net: ti: icssg-prueth: Fix kernel panic during concurrent Tx queue
> access
>
> drivers/net/ethernet/ti/icssg/icssg_common.c | 22 ++++++++++++++++++--
> drivers/net/ethernet/ti/icssg/icssg_prueth.c | 16 ++++++++------
> drivers/net/ethernet/ti/icssg/icssg_prueth.h | 1 +
> 3 files changed, 31 insertions(+), 8 deletions(-)
>
>
> base-commit: cc17b4b9c332cc654b248619c1d8ca40d80d1155
prev parent reply other threads:[~2025-05-02 7:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 12:04 Meghana Malladi
2025-04-28 12:04 ` [PATCH net 1/4] net: ti: icssg-prueth: Set XDP feature flags for ndev Meghana Malladi
2025-04-28 12:04 ` [PATCH net 2/4] net: ti: icssg-prueth: Report BQL before sending XDP packets Meghana Malladi
2025-05-01 14:53 ` Jakub Kicinski
2025-05-02 6:18 ` Malladi, Meghana
2025-04-28 12:04 ` [PATCH net 3/4] net: ti: icssg-prueth: Fix race condition for traffic from different network sockets Meghana Malladi
2025-05-01 14:56 ` Jakub Kicinski
2025-05-02 9:31 ` Malladi, Meghana
2025-04-28 12:04 ` [PATCH net 4/4] net: ti: icssg-prueth: Fix kernel panic during concurrent Tx queue access Meghana Malladi
2025-05-02 7:14 ` Jesper Dangaard Brouer
2025-05-02 9:07 ` Malladi, Meghana
2025-05-02 7:16 ` Jesper Dangaard Brouer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0608a65d-f657-4ef3-aeea-7b2664aa7625@kernel.org \
--to=hawk@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=daniel@iogearbox.net \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-malladi@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®