From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB2D1C54EED for ; Mon, 23 Jan 2023 16:43:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233232AbjAWQnE (ORCPT ); Mon, 23 Jan 2023 11:43:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233127AbjAWQnC (ORCPT ); Mon, 23 Jan 2023 11:43:02 -0500 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D00C32C65F for ; Mon, 23 Jan 2023 08:42:39 -0800 (PST) Received: by mail-ej1-x62d.google.com with SMTP id vw16so32050926ejc.12 for ; Mon, 23 Jan 2023 08:42:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Oz9O2z+IVBfv4cXE56ajIYgEI1z8EWwSY7ATfOxkyzU=; b=Bds3sKSZkbeHd5MeunsYtYMDA8f0/EGEhw+m+7gHUvDn+6T5/uo2CxmkDRsQdS9x8t XtwVxIIN2Lh92yaNDu+BJRISwJ/kBwnzvTICSNrjJh2saZT/JY0aM0aflobTzsujcyA5 y9BsH8gRGAxZDagq5BtOdGVlBYvL/+mg9K94MAZlUeIQhtNhtNMuAcxjiOLEMpHQ6JC6 EYlBCdCSR1hoBDW6dWT/Y3Xkss9GUr9oZGqgauTg0S9S40X9wvtO2U2FWCl16laJzwaw wkJHkXpC71wTE2MNKW5Kv9mlZbP78enjNb5Vy2h8gl4p8XUid+yQ4amFXg6j06ibiJy7 lOiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Oz9O2z+IVBfv4cXE56ajIYgEI1z8EWwSY7ATfOxkyzU=; b=szVOPaZxJwIpCdnHC7YzN9iM5P9caUYdhS3XAGrPWFLUvyG3C1OLHKEz4HJCVo2QGs azQ1WqoCTC6IwalKcwcEuoCRuyd3GCY3QfiTU7holjRkJGk2RRng/0BdelV+bTfvGfHU FTaYMvKWFbCM7OkAM3D0LGj8wAWsDJTVvD5jTZrL2K8agfhPyVL77q6KSgBJ5rf4xLVT bi0ik7RMfS0J5Bzy9ZITcesgs0knKmNZveVR5YPySfHjj/bQvnzp2uZLsL+C2lPSaKkC zkz5ui6w1YTlJL3Osdo+OR75jr5m1hV7SavDcvCaabVFAoL/kY16TvfLYpqk4jYO5mi7 rrsw== X-Gm-Message-State: AFqh2kqpb3KaCzW0sv5vQyF7I51CfsJvjMzjN3v3Vs9e/Uq/uIcmXfe8 fYeNaeB4k3P+OEaOGTSNQEXp/g== X-Google-Smtp-Source: AMrXdXvM0dKByeQ25Ewp07t/3M7rn4P3UM12DzVRodzO8ctPfozxh43mopdgduBZasU6idAkhDM7Dw== X-Received: by 2002:a17:907:29c4:b0:86e:a761:c5bd with SMTP id ev4-20020a17090729c400b0086ea761c5bdmr21734761ejc.34.1674492157401; Mon, 23 Jan 2023 08:42:37 -0800 (PST) Received: from [192.168.1.101] (abxi24.neoplus.adsl.tpnet.pl. [83.9.2.24]) by smtp.gmail.com with ESMTPSA id u9-20020a1709061da900b00877a351cedcsm5167351ejh.110.2023.01.23.08.42.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 08:42:36 -0800 (PST) Message-ID: <060f2917-da5a-22c8-33e9-c7350078ed4c@linaro.org> Date: Mon, 23 Jan 2023 17:42:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 3/5] ARM: dts: qcom: msm8974-oneplus-bacon: Add volume keys and hall sensor Content-Language: en-US To: Luca Weiss , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230122-msm8974-bacon-features-v1-0-4049f565c24c@z3ntu.xyz> <20230122-msm8974-bacon-features-v1-3-4049f565c24c@z3ntu.xyz> From: Konrad Dybcio In-Reply-To: <20230122-msm8974-bacon-features-v1-3-4049f565c24c@z3ntu.xyz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22.01.2023 17:48, Luca Weiss wrote: > Add nodes for the volume buttons and the hall sensor that are found on > the device. > > Signed-off-by: Luca Weiss > --- > .../arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts | 50 ++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts b/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts > index 63180fe1d292..10ba3c94e26d 100644 > --- a/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts > +++ b/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts > @@ -19,6 +19,38 @@ aliases { > chosen { > stdout-path = "serial0:115200n8"; > }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio_keys_default>, <&gpio_hall_sensor_default>; pinctrl-N pinctrl-names please > + > + key-volume-down { > + label = "Volume Down"; > + gpios = <&pm8941_gpios 2 GPIO_ACTIVE_LOW>; > + linux,code = ; > + wakeup-source; > + debounce-interval = <15>; > + }; > + > + key-volume-up { > + label = "Volume Up"; > + gpios = <&pm8941_gpios 5 GPIO_ACTIVE_LOW>; > + linux,code = ; > + wakeup-source; > + debounce-interval = <15>; > + }; > + > + event-hall-sensor { > + label = "Hall Effect Sensor"; > + gpios = <&tlmm 68 GPIO_ACTIVE_LOW>; > + linux,input-type = ; > + linux,code = ; > + linux,can-disable; > + debounce-interval = <150>; > + }; > + }; > }; > > &blsp1_i2c1 { > @@ -95,6 +127,17 @@ &pm8941_coincell { > status = "okay"; > }; > > +&pm8941_gpios { > + gpio_keys_default: gpio-keys-active-state { > + pins = "gpio2", "gpio5"; > + function = "normal"; > + Unnecessary newline Konrad > + input-enable; > + bias-disable; > + power-source = ; > + }; > +}; > + > &pm8941_vib { > status = "okay"; > }; > @@ -349,6 +392,13 @@ &sdhc_1 { > }; > > &tlmm { > + gpio_hall_sensor_default: gpio-hall-sensor-default-state { > + pins = "gpio68"; > + function = "gpio"; > + drive-strength = <8>; > + bias-pull-up; > + }; > + > sdc1_on: sdc1-on-state { > clk-pins { > pins = "sdc1_clk"; >