From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 632C3231829 for ; Fri, 23 Jan 2026 11:04:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769166263; cv=none; b=CwH0jWIZGB4VAjtj0STS9EDUbBVylVs0JwMiPWytIHaLvkNb+ezrKYDWrNh6oUUFUbjpParH5xsbelzf84zzYih1rdAjDMrxehSWAfJcdoR09BtXfBuYNWRhpubftD5s3OzVM6Zwq0srukSIaLRLJUMqqT03Ib1TtnqnFUm6WVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769166263; c=relaxed/simple; bh=V9JffqzBSVLCxeiE4aSeC95rFTCcg2DPDgn0D8LIo78=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qPvKIkQN4b94Pk8KgwpoSG4UMwltMZh1mDvq6wsbWZU2CMFstmtpi0pnaAFSpr+f1BnNORDBir4+cTNn2JCfQouh1GboVHyPfdgHTC/Gl9Kk2FpCJAHBYcjrj9PmxcmpS2vKQHUlucspSAcdCMislOQDUtE9f+SCLI6WhxItmE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aWd1f5xz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XCLkmT6J; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aWd1f5xz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XCLkmT6J" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60N55CGa1117096 for ; Fri, 23 Jan 2026 11:04:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nlLa28ZTX8VgKWsybVROjahqDOm/zN8s2Uxi6lUBMRY=; b=aWd1f5xz60va4y2+ o0PdM4K5eDDxp2PUwkkjPydMwhlhd41s/Zus9In0aWbBHSeQIaSm+lZM0MfReKiv ZNxPrd5BMYiNlSkJP28H0TGm+fEnzDeD5PJNa5XiPMlMdvglApKhGTIPm2E4sngO hcGZQ5m/FpqIVSf7fZ0T+gffKrSfDBL/LcE+Ug0z5deh3vFqSMR/TiljmyVkxqcc GWH8THhQzQCLm/uQkmXl8c17FSLv1gnTa9eG8ji7p4jU3CFuZRjmWPi0HUOo0ikV Beb/ikf+nAxK5U0eOIL7KCTc4FLBwzkKrHqh97j0Nv/GHGfDZkLKE2/tbmg4msV3 ODwckQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bur1cbgj9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 23 Jan 2026 11:04:21 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-29f2b45ecffso30512465ad.2 for ; Fri, 23 Jan 2026 03:04:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769166261; x=1769771061; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nlLa28ZTX8VgKWsybVROjahqDOm/zN8s2Uxi6lUBMRY=; b=XCLkmT6J7RVJVmP6NVXiOc/U6z46rQ/p8pKmgI+Q/QXNuT67Z4cePp5Cm8vSaqh/X8 YbXxcwApd381sTqV+r+FsPNEDD891uTMBimgKpUbLH33ntui1z4ZVgp6eTRF1HXnxJ/D zHwUVOu5GJUVjXoo4yzq43HM96/KS9VTH+6x9SvISFKY2LIYMEA8eh1jUEkKvkSSJwxq Ibl1i8cDmr1rhCmBvID99rzXKumrAT1yoOdF1XgmnwowbyF0qVTfhTmQnszGrfec10ja eDFzosCd8/5C2cldzPlHXU3PyXOW+tOMvLDEWPnT9uxSGxvbsdHUSgNmo8cKViwVfUAi Kr2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769166261; x=1769771061; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nlLa28ZTX8VgKWsybVROjahqDOm/zN8s2Uxi6lUBMRY=; b=dc0u+PxifoLTpLYQMCSY4Jkh7LQWUICXSy2ZvquO562Nc35/RaT15WYtS0bRJVhd92 rErgzxjGwU/QX+8j9hkEOsBKT7iHuTrBBsKMs/wd9THz83Wi9a59VTJTQR3Jfh7FNVVg oJ4Pwgp84zt9yOaiJQr+PZHhwW+aFRwPmP/CTBLdVmsYiu8laaM28M52TKY2HqckgFF3 Ai6ZsFFiGZPOHjjRAm1isLqP6pF9RAV8vG1nNqPctPJM8JAKQ9lukyta1wyuJ80YxCO+ fztsy/G54xEAiTAvKTLS0ZLFclj+tvrWaZJzRoSSwX01V1fCanjx435EY5KGbOHgnGoU jalw== X-Forwarded-Encrypted: i=1; AJvYcCWA3YhsfYiYHFL/ZYaSCnYsrhS7GxIBfaCpRYWqkM4BDcrYfAaFMaKOuwk63WxKXI//8K7gXdiyPxmTyrQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyQWk+3TK8jViwqs0vwKSk+FkOpG88ZWy7MtLc4IpyLqF+VeLy5 GlRnYcwPWHwuBIbBfWKI6ADkn9gchrTsZAFbhtHDx5V3Ij8ij9XnCoL+/cU6260I6VNSpRREvd5 K4B+ZcVGFMFYHGYEg+qlp3QLKFE+JTzZE1mx3MTikTuFZmkpD/RZAwKYuBmkXPL617oU= X-Gm-Gg: AZuq6aLcHBOkThHkcKYQWsR2Jsqj38kt2SLg3FBcNH17AVs/qnCeU+aXQUJhqRgUNsN 3B3E3ouphridRIYthdnxSWocEX/npxUHx2gSisqXIZfCB+7l+SLewrBNkP1x7gWC6EmC3Q5vaNP l9WbFbkM0pWuPs9i2CpxlEeWw8TbgBWA4fwBmcAaHgT9GD6wASO25XHFhHAsiczjW/mem8WcGWN p7U23UBi+t4+gEzQ417XXtFdvGSeW1RGmtPsQGtKzSC2hdEAceR6vlSXVb9jbRYtfm3FbBUZw0/ HcUWLPngMCo8lRjEcjuFEn9ARie6eurnD6wjrtiS29Qir+aF51ShIzCJUQzMrR9yElmyOHQQUjc SAnjZOr/82UHDVMQUCLWk48MQ9zcclPgneoNjZYQ= X-Received: by 2002:a17:903:3c50:b0:2a7:c6c8:2cf with SMTP id d9443c01a7336-2a7fe56cadbmr22449715ad.22.1769166260951; Fri, 23 Jan 2026 03:04:20 -0800 (PST) X-Received: by 2002:a17:903:3c50:b0:2a7:c6c8:2cf with SMTP id d9443c01a7336-2a7fe56cadbmr22449325ad.22.1769166260221; Fri, 23 Jan 2026 03:04:20 -0800 (PST) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a802dcd776sm17259215ad.26.2026.01.23.03.04.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jan 2026 03:04:19 -0800 (PST) Message-ID: <06160c6c-a945-467a-be82-7b33c5285d0f@oss.qualcomm.com> Date: Fri, 23 Jan 2026 16:34:13 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/11] dt-bindings: crypto: qcom,ice: Require power-domain and iface clk To: Krzysztof Kozlowski , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , cros-qcom-dts-watchers@chromium.org Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260123-qcom_ice_power_and_clk_vote-v1-0-e9059776f85c@qti.qualcomm.com> <20260123-qcom_ice_power_and_clk_vote-v1-1-e9059776f85c@qti.qualcomm.com> <14a71b33-4c10-41b0-a6cb-585a38e05f56@kernel.org> Content-Language: en-US From: Harshal Dev In-Reply-To: <14a71b33-4c10-41b0-a6cb-585a38e05f56@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=FswIPmrq c=1 sm=1 tr=0 ts=697355b5 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=MVwZJz_WKtXOECYJnuwA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: 6KIgiiHII_AuJw4I171WDAL2r-CDXczD X-Proofpoint-GUID: 6KIgiiHII_AuJw4I171WDAL2r-CDXczD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIzMDA4OCBTYWx0ZWRfX6xavYKVaBcdw zB2qFmUsc/xDxXSFehG6Mac+VyemspeOkBnDjaMH/VifKeul+OF9w2u9hSEjSItczNd/oCSGPcH 8QTEH8Wd7tv0/BwzifewwwAhXZbaSjgnJ9ogHG+yVPqP1qDVciQ8IvMdKjUXHgpMd4UV97g/h8z zkDV97YyjpWJUJWy08kDUYNlLNOFo4QzFn+Sxm2x7PTV+yWUxMid1NNzDpt3RGy6NMvQiQdpvYg 87A42I8yAnmHwyzYDRX9ZtGc+lp6qBqOBdaqkb2ocOlZljPxsxZyCSjkpcQmU+vT8wnG0ZOEYM1 xCS+0NDdcUXgMuSGst7PfcgfRCrNcyl37A0op7YCrnmTkCV7v+7QpDVHNUKniPjUJVkzvQP5P8c AwuJS9SdGKad3zN7wvtWQQ3Ol5A+OKkDbyn8Oc7AHaUohBMx9scihbMKYS/OYD7QNRHlH9trC7K N7Z3RKokRiKnmx1PnGw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-23_02,2026-01-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 spamscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601230088 Hi Krzysztof, On 1/23/2026 2:27 PM, Krzysztof Kozlowski wrote: > On 23/01/2026 08:11, Harshal Dev wrote: >> Update the inline-crypto engine DT binding to reflect that power-domain and >> clock-names are now mandatory. Also update the maximum number of clocks >> that can be specified to two. These new fields are mandatory because ICE >> needs to vote on the power domain before it attempts to vote on the core >> and iface clocks to avoid clock 'stuck' issues. >> >> Signed-off-by: Harshal Dev >> --- >> .../bindings/crypto/qcom,inline-crypto-engine.yaml | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >> index c3408dcf5d20..1c2416117d4c 100644 >> --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >> +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >> @@ -28,12 +28,20 @@ properties: >> maxItems: 1 >> >> clocks: >> + maxItems: 2 > > This is ABI break and your commit msg suggests things were not perfect, > but it is not explicit - was this working or not? How is it that ICE was > never tested? > I took some time to educate myself on the point of DT bindings stability being a strict requirement now, so I understand how these changes are breaking ABI, I'll send a better version of this again. As for your question of how it was working till now, it seems that things were tested with the 'clk_ignore_unused' flag, or with CONFIG_SCSI_UFS_QCOM flag being override set to 'y'. When this is done, QCOM-ICE (on which QCOM-UFS depends) initiates probe _before_ the unused clocks and power-domains are disabled by the kernel. And so, the un-clocked register access or clock 'stuck' isn't observed (since the clocks and power domains are already enabled). Perhaps I should write this scenario explicitly in the commit message? To maintain backward compatibility, let me introduce minItems and maxItems for clocks. When the Linux distro uses CONFIG_SCSI_UFS_QCOM=y, we can do with just 1 clock as before. >> + >> + clock-names: >> + maxItems: 2 > > Why "yellowpony" is a correct name? Please look at existing code to see > how this is done. > Ack, I will try to list down the acceptable clock names here. > >> + >> + power-domains: >> maxItems: 1 >> >> required: >> - compatible >> - reg >> - clocks >> + - clock-names >> + - power-domains > > Another ABI break... Let me avoid adding clock-names and power-domains as required. Since for scenarios where a Linux distro uses CONFIG_SCSI_UFS_QCOM=y, this isn't mandatory as I explained above. > > Best regards, > Krzysztof Regards, Harshal