From: Joe Perches <joe@perches.com>
To: Sohaib Mohamed <sohaib.amhmd@gmail.com>
Cc: Eric Van Hensbergen <ericvh@gmail.com>,
Latchesar Ionkov <lucho@ionkov.net>,
Dominique Martinet <asmadeus@codewreck.org>,
v9fs-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/9p: fix warnings found by checkpatch.pl
Date: Fri, 01 Oct 2021 05:59:50 -0700 [thread overview]
Message-ID: <061762c85ea54ff7ebaaa1b2468f1c8c5cc84eb9.camel@perches.com> (raw)
In-Reply-To: <20211001063444.102330-1-sohaib.amhmd@gmail.com>
On Fri, 2021-10-01 at 08:34 +0200, Sohaib Mohamed wrote:
> Signed-off-by: Sohaib Mohamed <sohaib.amhmd@gmail.com>
try using checkpatch on your proposed patch.
> diff --git a/fs/9p/v9fs.h b/fs/9p/v9fs.h
[]
> @@ -135,8 +135,8 @@ static inline struct fscache_cookie *v9fs_inode_cookie(struct v9fs_inode *v9inod
>
>
> extern int v9fs_show_options(struct seq_file *m, struct dentry *root);
>
>
> -struct p9_fid *v9fs_session_init(struct v9fs_session_info *, const char *,
> - char *);
> +struct p9_fid *v9fs_session_init(struct v9fs_session_info *v9ses, const char
> + *dev_name, char *data);
That's really not pretty as it separates the type of the 2nd argument.
Perhaps:
struct p9_fid *v9fs_session_init(struct v9fs_session_info *v9ses,
const char *dev_name, char *data);
prev parent reply other threads:[~2021-10-01 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 6:34 Sohaib Mohamed
2021-10-01 12:59 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=061762c85ea54ff7ebaaa1b2468f1c8c5cc84eb9.camel@perches.com \
--to=joe@perches.com \
--cc=asmadeus@codewreck.org \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=sohaib.amhmd@gmail.com \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®