From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a4-smtp.messagingengine.com (fhigh-a4-smtp.messagingengine.com [103.168.172.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 518582C181 for ; Sat, 25 Jan 2025 14:28:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.155 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737815334; cv=none; b=OCOej9T21OyB5wCx3m8y7RbB9X1kWSHoauiPInYHDxQFj33aEQayGvSuOuWvJxgwD8MzdlyKizG2eguVhGBJyWMsHqqWkHq5NiqjDiBXTw9T/xXYu8La7izSCuFRi3WU8nNzRuya1o7KSCwBd6CJfeTURc1odJjHG8iSFWRBaGM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737815334; c=relaxed/simple; bh=21zQY3QrUS3GxlIs9tTYcy7Pg2MhIBluoG7bxCEMyNo=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=etrdzbYOJQSlGD0DxVi9YLV03PU2QoqAxASvlfHMH+DWnuQStYoMjLGTxurhUG3D1PvH+P2vFbK1qPU126PPkxcWGf5UvRG+GcJgGVNd7Qb4KGgx/q8opNBOAPXteZz+ESUxCALB9UTI5dXrT/zn1BJz+iIhAlcjwhfbqh+qGwk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=pOH28VpK; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=gS5sYZDb; arc=none smtp.client-ip=103.168.172.155 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="pOH28VpK"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="gS5sYZDb" Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id EDA331140158; Sat, 25 Jan 2025 09:28:49 -0500 (EST) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Sat, 25 Jan 2025 09:28:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1737815329; x=1737901729; bh=J93DOO3qfky48RVPPV/ZS5WxX305lSy7wjSmpLNDePk=; b= pOH28VpKooiDkeB1lmIP7TYSHJR9NBkrjxrdo+ncLAZKkMhn5zyzI4A/ZDdpiKXP VZJ8LXERRRHegBoIeKql/ot11iEV6MoYhEGTVC40dNA7v1now5ZO/x9ILCjofLbL nCWSFZgDWLRwNOK9vAw5x1v6inubTht0DYw3b70cHxkM+ejRNLbwqRMp9uQbRTBt weHZ4DGn1ESGkJoKhUBscUzJ7JRoPRPVXcki7Bwz9HUecpSlcogZjXdQCOHhZDel wWJyolWXM6BgEYHpz0AcxR8mq52rLKRikTvGhTnbunR6haZ7+1xVmvWbXIJNnQ0E dkaYEKG8j5CaPUGWe/uPzg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1737815329; x= 1737901729; bh=J93DOO3qfky48RVPPV/ZS5WxX305lSy7wjSmpLNDePk=; b=g S5sYZDb5fP7aPywcdXMz5zSNHK0hySPwKa49QZ2wRmHiVB/EBwzGw4y37lq5DbYX xG13UEy6EyZYU/Uxmdf085KRRF8sU2JTr1rHvbvPlBfy/W1zPuASj8wlXh5t4X84 OhcvpsSBnDR6SUweYaVdaZJB5TchK4z6xUWFD9n41J4GqGnk9qkTA2HZKkK+stG0 Fr0kr8dj0+gKo4t9LQHTlYx5E3pcW/ge4RoAo4Clrekp4NgI5cCLQKB8NYSGrs3d HJ9SgxV6Kgiwxa5S4YhafE+eW7HQp53pUyQnNHT1wBf8pzOE1kjX6G17orcV00cc WFUYb3VqviZdvbhiiwGoA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudejgedgjeeifecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthhqredtredt jeenucfhrhhomhepfdetrhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusg druggvqeenucggtffrrghtthgvrhhnpedvhfdvkeeuudevfffftefgvdevfedvleehvddv geejvdefhedtgeegveehfeeljeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggvpdhnsggprhgtphhtthhopeej pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehgohhrtghunhhovhesghhmrghilh drtghomhdprhgtphhtthhopehrihgthhgrrhgutghotghhrhgrnhesghhmrghilhdrtgho mhdprhgtphhtthhopehfrhgvuggvrhhitgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtoh eprghnnhgrqdhmrghrihgrsehlihhnuhhtrhhonhhigidruggvpdhrtghpthhtohepthhg lhigsehlihhnuhhtrhhonhhigidruggvpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvg hlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugiesfigvihhs shhstghhuhhhrdhnvght X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 7C9E02220072; Sat, 25 Jan 2025 09:28:49 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Sat, 25 Jan 2025 15:28:29 +0100 From: "Arnd Bergmann" To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , "Anna-Maria Gleixner" , "Frederic Weisbecker" , "Thomas Gleixner" Cc: linux-kernel@vger.kernel.org, "Richard Cochran" , "Cyrill Gorcunov" Message-Id: <06196213-3106-4b69-a15d-4b2e4ac6f187@app.fastmail.com> In-Reply-To: <20250125-posix-clock-compat-cleanup-v1-1-c8b0f377905b@weissschuh.net> References: <20250125-posix-clock-compat-cleanup-v1-1-c8b0f377905b@weissschuh.net> Subject: Re: [PATCH] posix-clock: Remove duplicate ioctl handler Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, Jan 25, 2025, at 11:20, Thomas Wei=C3=9Fschuh wrote: > static int posix_clock_open(struct inode *inode, struct file *fp) > { > int err; > @@ -174,7 +154,7 @@ static const struct file_operations=20 > posix_clock_file_operations =3D { > .open =3D posix_clock_open, > .release =3D posix_clock_release, > #ifdef CONFIG_COMPAT > - .compat_ioctl =3D posix_clock_compat_ioctl, > + .compat_ioctl =3D posix_clock_ioctl, > #endif I would remove the #ifdef/#endif as well here. I would also suggest using compat_ptr_ioctl(), so on s390 the pointers get converted correctly, even if it clears the upper bit on the integer arguments. Arnd