From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753357AbcL2QSe (ORCPT ); Thu, 29 Dec 2016 11:18:34 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:34523 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752789AbcL2QSb (ORCPT ); Thu, 29 Dec 2016 11:18:31 -0500 X-AuditID: b6c32a2d-f79a76d0000074b4-9a-58653753d3cf Subject: Re: [alsa-devel] [PATCH] Revert "ASoC: core: replace aux_comp_list to component_dev_list" To: Nikita Yushchenko Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, Kuninori Morimoto , Chris Healy , linux-kernel@vger.kernel.org From: Sylwester Nawrocki Message-id: <061fafe6-dc46-375d-9e57-cc59115a04aa@samsung.com> Date: Thu, 29 Dec 2016 17:18:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-version: 1.0 In-reply-to: <1483022987-28843-1-git-send-email-nikita.yoush@cogentembedded.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHec85O56NJsd5e1JUGJQpOTUUj1im5YcDlggSjL7oaAddXtm8 B2GW1/CGWfMYYZlWOnF4T0Js1tbNSLLAzKUlBgtL0bRQM9yZ4Lf/8z6/5/0//5eXwmVdIi9K k5XLabNUGXJSQgyOBwQGJUVwypCZ/gBmatKEMU3zCyTz9IkFY2zjI4hZn6rEmPcjt0lmried qRqpEzHGjW4UI2aNq6UkO9e0g7GP+VkntrezimRHlzpIdv1NA8H29H8g2NVe30TqvOS4msvQ 5HPa4OgUSdrQnXJRzrS4sPHtFbIE/XWqRmIK6DBoMD5EgvaAd9YeshpJKBndjmB2eBMTigoM fm/YiL2J+8t9DuoBgulZm4P6gmCnrASvRhTlSqthop7cHXCjI4CfL7fb4XQbBkOd4buapEOh 5nmt3VpKR8Nox3U7T9CHYKtl2W7mTivBZJ7BBcYF/jRa7ediOhEGv5tFwp0hoL8xjgnaD/oM S/juPkCbnWDkGY/t7gO0D/SO4UKAOHi0uuWI7wo2S79De8N2+yckzNYheGG46ij0CD5X1GMC FQXjlkmHszPUbC44DKRQWS4TJAtdkycEOha+llkd79OGwGYaQPXIj9+Xh9+Xgd+XoRXhnciD y9FlpnK68JxjCp0qU5eXlaq4kJ3Zi+xfKDBoGK21xpsQTSH5AenyabVSJlLl64oyTQgoXO4m nQjjlDKpWlVUzGmzk7V5GZzOhLwpQu4pbS2MUsroVFUul85xOZx2r4tRYq8S5F+kzY2UnDW3 vYo2DGlf6we2m4P52W7XGCb4KLVWV/xr7NvhZM9r0SmhLSGX9aW3quQf58TOBYo4ZKxNYCYX sSNVuQWb+Rcl3pUTLw+uWC3rGTcV//yl55pb4u+ejHU5c0ntUtBfMLGS8NPIB907ZQhfTPLx jfzhTizFaOoTNHJCl6YKDcS1OtV/Ng9WqD4DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNIsWRmVeSWpSXmKPExsVy+t9jAd0g89QIg6/XVSyuXDzEZDH14RM2 i4N7jjNZvDq8i9Hi25UOJovLu+awWTxYn23Ruauf1WLD97WMDpweGz43sXk8mPqfyWPnrLvs HptWdbJ57Hu7jM3j25mJLB7rt1xl8fi8SS6AI8rNJiM1MSW1SCE1Lzk/JTMv3VYpNMRN10JJ IS8xN9VWKULXNyRISaEsMacUyDMyQAMOzgHuwUr6dgluGdvntbEW3OSsmHyuka2B8Sd7FyMn h4SAicSSD5vZIGwxiQv31gPZXBxCAksZJZZcfQzlPGSU+LLxL0sXIweHsECKxNkJYA0iAuYS sx62scM1tC6fDuYwCyxmktizsYcVpIpNwFCi92gfI4jNK2AnsW9ZN1g3i4CqxJ/ZH8CGigpE SDQcTocoEZT4MfkeC4jNKRAgse35MVaQEmYBPYn7F7VAwswC8hKb17xlnsAoMAtJxyyEqllI qhYwMq9ilEgtSC4oTkrPNcpLLdcrTswtLs1L10vOz93ECI7IZ9I7GA/vcj/EKMDBqMTDe0Ih JUKINbGsuDL3EKMEB7OSCO9Zk9QIId6UxMqq1KL8+KLSnNTiQ4ymQF9MZJYSTc4HJou8knhD E3MTc2MDC3NLSxMjJXHextnPwoUE0hNLUrNTUwtSi2D6mDg4pRoYK99PTNluKytaEXUmcNpP njTTr4ZXZ5xkv6tVtrgrsCt++dOjpSszIxl67gu7r9QWX66s4Blz/fae/f+Kp2YyZ0QuUOe/ KaN0gYU9IDCmM9CStf3OmmLL8+4JzIf5Fi9fvmWJhKRB5Kv3aakcD+4/jd6/ivu980pRzUmv W3UXvXi8JjD82YTZSizFGYmGWsxFxYkAQmnBfd4CAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161229161826epcas5p24dc6f7664c4597c22b92de710d1c0e7b X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20161229152622epcas4p19054a78722d5eae88c983230f457e794 X-RootMTR: 20161229152622epcas4p19054a78722d5eae88c983230f457e794 References: <1483022987-28843-1-git-send-email-nikita.yoush@cogentembedded.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/29/2016 03:49 PM, Nikita Yushchenko wrote: > This reverts commit 1a653aa44725668590b36bbe2d7fe4736a69f055 ("ASoC: > core: replace aux_comp_list to component_dev_list"). > > That commit tries to remove card->aux_comp_list, using flagged entries > in card->component_dev_list instead. > > However, components are added to card->component_dev_list in > soc_probe_component(), which is called for aux devices by > soc_probe_aux_devices(). Before that commit, it traversed > card->aux_comp_list and found aux devices added by soc_bind_aux_dev(). > After that commit, it traverses card->component_dev_list and finds no > aux devices, because soc_probe_component() was not yet called for them. > > Thus all aux devices are lost and any setup that needs them no longer > works. I think we can't simply revert that commit now, after commit 9178feb ASoC: add Component level suspend/resume component_dev_list is also used for the component level suspend/resume, if auxiliary devices would have been on a separate list they would be missed in the suspend/resume sequences. I run into same issue and posted a patch: "ASoC: Fix binding and probing of auxiliary components". -- Thanks, Sylwester