From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FA493D093B for ; Wed, 20 May 2026 10:09:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779271757; cv=none; b=cEGEiTeQtMhqIPDDZfNcfG5D9sIrevQZp9F3I8UP/s01XhDmds3JQkPSXbdDZaqI6IsQDvVMJUqiX0mNJay82IhFyY8YcOF5zRgnhHJw9vfFrpmmgc3DAjI1EQu/mFujCoQJ46dROakYD0S/CLA6Kqp5bqwkMxuGknW3nTmsv8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779271757; c=relaxed/simple; bh=B9I2PYfFIw8vVvTlnWFte3i2pKBUtm1OmE0IIWmSrgs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kY5JnqCBVvLFrgO+Iqr/UiKUsfh19pOWEKoeuoNr4LlfcEDluZnU4UyUdqpOcS3ZScts5UbGUE147t7UaT1Gpf5vdQ8oUIMPCODNTegi8IItTxGS2naZq66VdnJ2Q9gK6t9VhUnB5MjGcEvQXh49Q94URTL4OpVAFiPJBirVa3g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NP9aFQw4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=F3v2GhNT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NP9aFQw4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="F3v2GhNT" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64K9oTlj1178134 for ; Wed, 20 May 2026 10:09:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NHGk75E7eLjI45U2CcQdvR/hLoIhsg/8fuLIwG1HhaA=; b=NP9aFQw4fm7IcsSa 7k1Isziv6H8wTtRzJXcuXUraxzQO1VdOLxkI0UQ5TU/SfGRBiUPFtqFLJyWZXRYZ CJc2BlyunsZIRto49X/TBtv+rpgpdy7EckCK7QXGWxuGEwlL+DW1l7QrsvB2lKUR ED2A7gWTr1bFSYTmxmRG+ijju0qhJc6MS6IAnQhAY/E7mwwj6G7yjrOF6cFRaqv/ GwKGrSc3wnkB0AckkKZ66KpTx1OdiCivqDWZ+0toBNuYjf9+J+fWuyoX8TJZhb43 7JeW/fgg1u56BsZfc5o6Ijko2HTlyMdhGt82ALB9Fc3IwAiJQrOfmaGmp/il91kd JYzsyA== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9ap6r2a1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 20 May 2026 10:09:15 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-83cecc22d5fso2425382b3a.2 for ; Wed, 20 May 2026 03:09:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779271755; x=1779876555; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NHGk75E7eLjI45U2CcQdvR/hLoIhsg/8fuLIwG1HhaA=; b=F3v2GhNT3Rh7Ji+kTKptM3FvnGKl/fMEdgukRjNRXGroWwnt9qZu+e6jPM00VG5ULu U2rnAVbYpq5oIvDDtO5WujIMKiYrKZbOUEIThn2hoUX8G8ygm1eIWDP0+iK71ttjW9y9 JmTuRYBH9p3AN+c9j2SuPFcs+bFQOKF4W6EqcaFlK1vesaPftWlTZ9+iFLptIKng3fkH 4KEszd5M2rtBxtBUrT0OSaPqZMFJF5ipTMoPOqH6EhzjDyvPYLFRiPT0rWN8RXaO1ptX rXOezt0BRmuOwDMUElEM0UioQzrvybkHscia65wxOiU8naxh1gqx5YdmpRD/BKbb6l0M IIGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779271755; x=1779876555; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NHGk75E7eLjI45U2CcQdvR/hLoIhsg/8fuLIwG1HhaA=; b=T/8pBWWSWZb/LYcdlx+XgsJuhLXcs90a4wA9aWhcagr4vRbeY64w5A3UPysbp3D8T2 fv6sYmZUA+vgnR+a0rJG1DxzdiCCGakwtsM0WFG89vFC/xsYM7kM/LS47Wopq0PX6j4I Wfrk9V4WhZ6fSsNEAwL4+99zuxK6UwOATFxovWgcMLwRUj8y13vT8EGUJBWOChnAOTfn Wsd+IfZedFDH9rOQBdHP+uFHRyYC3Amw00+mbQsXZkDaqe/3aaFII4LQuxcfLdg5Ikjj TzZ6FbHHAiCrsHTcjeI/3WdC35uU8BcaYXu3tOFutGYQdc0bVMRz0eszK81CBGNZQlR9 Fdpg== X-Forwarded-Encrypted: i=1; AFNElJ+c9ta6RnXaIyXwYBq7YXDL50Y/wF0+8jFV1opL6NjG7NPIJLqoS16iF1dQXF2MxwPVnOJsxTuAoRsbKtk=@vger.kernel.org X-Gm-Message-State: AOJu0YyxhLFFdRfyGJoqGQSYLDOZJDPkeZeEveI5U1I2WGq51JXZMKd4 uptSz14DSCPV+gmofn6G8GVBTrCKWWr0p+NqNGNPDm1jVFPmcYNXFtmcDN2Z5oZNP+78PJWFwRr RKPv4unWAh8gJaCu2c9HymEDg08aPGTNT2ZragasIwxhMBj+QXRDu1TY74WUNSv/QX2U= X-Gm-Gg: Acq92OEivyWvccKhgwps+7NH9uB9eEna+BwYg//QgbTzE/ZjDCIm34EESCvpUunRrOY 4MsQ8Q5Cntl23Ek9T9A4+5pTHqPVpLs4VhlL3OeiWX3x9Ad+y/Yy8950IzlKuvdvXR4UgY6hYK4 zcJUZhIpbuAosp2dBdY4AVm3xpTum2SxxzGQ/gcLNh738OIsnSMwAaYI1e4X0hURfXgwGhf0RDz fc5YTYRVCvgdzfPv+4gbZZO9ac1qscSZ7XckSwmYA9H22scdPBbRzJgQwNx/guVOEgr52KG4r2/ yfA/SHviuLhbnK3iddg/TBSAE7o7c5DrPUlchVSDws0j7BMrz/Ceeu2ptoiypBa5gky0kdrfGfu 5703HMCg8sT+OvdJLZlXzgzEC4r+fzrubLGpV45nIcOUFP69S2aNM89MOCsH03YUiBBw61HftVs r+EzhAaWEtaoEdVzaCnQ== X-Received: by 2002:a05:6a00:12cf:b0:82a:1529:2b4f with SMTP id d2e1a72fcca58-83f33d20555mr24402844b3a.44.1779271754709; Wed, 20 May 2026 03:09:14 -0700 (PDT) X-Received: by 2002:a05:6a00:12cf:b0:82a:1529:2b4f with SMTP id d2e1a72fcca58-83f33d20555mr24402810b3a.44.1779271754119; Wed, 20 May 2026 03:09:14 -0700 (PDT) Received: from [10.133.33.114] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19c5b296sm19190671b3a.32.2026.05.20.03.09.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2026 03:09:13 -0700 (PDT) Message-ID: <06243b67-27a0-4ab0-ab31-8d4d6a555a57@oss.qualcomm.com> Date: Wed, 20 May 2026 18:09:08 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/39] drm/msm/dp: remove cached drm_edid from panel To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> <20260410-msm-dp-mst-v4-1-b20518dea8de@oss.qualcomm.com> <7cnjdge435t55s5vf66fkjfmkz7jvcbbax2uuismyc74mv4eia@toe2vu2folqa> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 6AuDJ8lkBITQv5O3MANbKHVwqNWUWEbp X-Proofpoint-ORIG-GUID: 6AuDJ8lkBITQv5O3MANbKHVwqNWUWEbp X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIwMDA5NyBTYWx0ZWRfXzuEdKZtttLSS fEa4BJpIxSWLuRmGwrHLyfHgKeBG13Ibyv/q+VrXk/iUE1unWiI4BEoVH3u5m3UA/Ix5o4H3ZuP cdllJthEg1eg07poogfJzNMAL2z3XU4JkFetl9YfFEK7avoGu5PGQLD962TlVTczi+3PM3a1Sq1 0SdzC0Ej0PonIhQwy/Pyi4yJod1vPUteHgx1qfT0latxdn2gD92DsbFGr53D881M6MB3tfLOVSk gxojd78ptTc9skvaLiOYMvE9KWY60yjdZRGF7eO5mev3dzFzOyuXWMwUQVg2rLrgTUfHp5ky2dB RVnZRW5ko+MMv2TVSFHupAWNDPEOah/H2fTlCERNuumklJk/ncudiNMKLypmkp/LHwP7nCGVLs8 jaxfG6LMz3E1Vk+tuRYw8OanDxuqZlYR+V27kRoYC71lcFC/vc+tAj6IjyRYKPtlqGqIERQ71n/ FihPHW6sgl35w/BVzvw== X-Authority-Analysis: v=2.4 cv=FesHAp+6 c=1 sm=1 tr=0 ts=6a0d884b cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=i31FdzyQ29aSgmU6y3EA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_02,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 clxscore=1015 priorityscore=1501 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605200097 On 5/20/2026 5:22 PM, Dmitry Baryshkov wrote: > On Tue, May 19, 2026 at 03:27:00PM +0800, Yongxing Mou wrote: >> >> >> On 4/10/2026 9:52 PM, Dmitry Baryshkov wrote: >>> On Fri, Apr 10, 2026 at 05:33:36PM +0800, Yongxing Mou wrote: >>>> The cached drm_edid seems unnecessary here. Use the drm_edid pointer >>>> directly in the plug stage instead of caching it. Remove the cached >>>> drm_edid and the corresponding oneliner to simplify the code. >>>> >>>> Signed-off-by: Yongxing Mou >>>> --- >>>> drivers/gpu/drm/msm/dp/dp_display.c | 27 +++++++++++------- >>>> drivers/gpu/drm/msm/dp/dp_panel.c | 57 ++++--------------------------------- >>>> drivers/gpu/drm/msm/dp/dp_panel.h | 13 +++------ >>>> 3 files changed, 26 insertions(+), 71 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c >>>> index 5c6a24ec140d..e28cc1bbb5b1 100644 >>>> --- a/drivers/gpu/drm/msm/dp/dp_display.c >>>> +++ b/drivers/gpu/drm/msm/dp/dp_display.c >>>> @@ -268,6 +268,7 @@ static int msm_dp_display_process_hpd_high(struct msm_dp_display_private *dp) >>>> const struct drm_display_info *info = &connector->display_info; >>>> int rc = 0; >>>> u8 dpcd[DP_RECEIVER_CAP_SIZE]; >>>> + const struct drm_edid *drm_edid; >>>> rc = drm_dp_read_dpcd_caps(dp->aux, dpcd); >>>> if (rc) >>>> @@ -275,10 +276,20 @@ static int msm_dp_display_process_hpd_high(struct msm_dp_display_private *dp) >>>> dp->link->lttpr_count = msm_dp_display_lttpr_init(dp, dpcd); >>>> - rc = msm_dp_panel_read_sink_caps(dp->panel, connector); >>>> + rc = msm_dp_panel_read_link_caps(dp->panel, connector); >>>> if (rc) >>>> goto end; >>>> + drm_edid = drm_edid_read_ddc(connector, &dp->aux->ddc); >>> >>> Where is it free? >>> >> Ohh, i miss it, will update next version >>>> + drm_edid_connector_update(connector, drm_edid); >>>> + >>>> + if (!drm_edid) { >>>> + DRM_ERROR("panel edid read failed\n"); >>>> + /* check edid read fail is due to unplug */ >>>> + if (!msm_dp_aux_is_link_connected(dp->aux)) >>> >>> Does this work for USB-C AltMode usecase? >>> >> For USB-C DP, i think it always TRUE, here should already existed before >> this patch.. > > I'd expect the answer without the 'i think' part. > Sorry.Add log and tested. For USB-C AltMode usecase msm_dp_aux_is_link_connected() always return 0. >>>> + return -ETIMEDOUT; >>>> + } >>>> + >>>> msm_dp_link_process_request(dp->link); >>>> if (!dp->msm_dp_display.is_edp) >>> >> >